Patchew URL: https://patchew.org/QEMU/1551968334-18982-1-git-send-email-thuth@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 1551968334-18982-1-git-send-email-thuth@redhat.com
Subject: [Qemu-devel] [PATCH v4 00/29] Kconfig dependencies for ARM machines
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/1551968334-18982-1-git-send-email-thuth@redhat.com -> patchew/1551968334-18982-1-git-send-email-thuth@redhat.com
Switched to a new branch 'test'
7a49f0e7fc hw/arm: Remove hard-enablement of the remaining PCI devices
5972e76d91 hw/arm: Express dependencies of the musca machines with Kconfig
2fe0991947 hw/arm: Express dependencies of the xlnx-versal-virt machine with Kconfig
89816717cc hw/arm: Express dependencies of the ZynqMP zcu102 machine with Kconfig
073ba3a043 hw/arm: Express dependencies of the microbit / nrf51 machine with Kconfig
b401ff6f8a hw/arm: Express dependencies for remaining IMX boards with Kconfig
2ed93aae1e hw/arm: Express dependencies of the MSF2 / EMCRAFT_SF2 machine with Kconfig
3238b4b7e3 hw/arm: Express dependencies of sabrelite with Kconfig
1c24fa816d hw/arm: Express dependencies of canon-a1100 with Kconfig
de1ad28241 hw/arm: Express dependencies of the raspi machines with Kconfig
543bf8a7a2 hw/arm: Express dependencies of the MPS2 boards with Kconfig
f52e0f02a0 hw/arm: Express dependencies of allwinner / cubieboard with Kconfig
58d1e7b58e hw/arm: Express dependencies of netduino / stm32f2xx with Kconfig
18f1a551d8 hw/arm: Express dependencies of the virt machine with Kconfig
fd99e7322f hw/arm: Express dependencies of the aspeed boards with Kconfig
e3342d6665 hw/arm: Express dependencies of collie with Kconfig
2b7d5906ca hw/arm: Express dependencies of xilinx-zynq with Kconfig
5e3d8a9740 hw/arm: Express dependencies of the PXA2xx machines with Kconfig
9f01ca8889 hw/arm: Express dependencies of realview, versatile and vexpress with Kconfig
475f8aeca0 hw/arm: Express dependencies of stellaris with Kconfig
c21e5c7fb5 hw/arm: Express dependencies of the OMAP machines with Kconfig
7e669c51cf hw/arm: Express dependencies of musicpal with Kconfig
98422e5732 hw/arm: Express dependencies of the fsl-imx31 machine with Kconfig
94baf18b80 hw/arm: Express dependencies of integratorcp with Kconfig
80448178fe hw/arm: Express dependencies of the highbank machines with Kconfig
99200c7e4b hw/arm: Express dependencies of the exynos machines with Kconfig
a71ef12409 hw/sd/sdhci: Move PCI-related code into a separate file
15e1f1f48c hw/ide/ahci: Add a Kconfig switch for the AHDI-ICH9 device
91cd8d9338 hw/pci/pci-stub: Add msi_enabled() and msi_notify() to the pci stubs
=== OUTPUT BEGIN ===
1/29 Checking commit 91cd8d9338e2 (hw/pci/pci-stub: Add msi_enabled() and msi_notify() to the pci stubs)
2/29 Checking commit 15e1f1f48c73 (hw/ide/ahci: Add a Kconfig switch for the AHDI-ICH9 device)
3/29 Checking commit a71ef124095c (hw/sd/sdhci: Move PCI-related code into a separate file)
ERROR: Macros with complex values should be enclosed in parenthesis
#76: FILE: hw/sd/sdhci-internal.h:326:
+#define DEFINE_SDHCI_COMMON_PROPERTIES(_state) \
+ DEFINE_PROP_UINT8("sd-spec-version", _state, sd_spec_version, 2), \
+ DEFINE_PROP_UINT8("uhs", _state, uhs_mode, UHS_NOT_SUPPORTED), \
+ \
+ /* Capabilities registers provide information on supported
WARNING: Block comments use a leading /* on a separate line
#80: FILE: hw/sd/sdhci-internal.h:330:
+ /* Capabilities registers provide information on supported
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#93:
new file mode 100644
total: 1 errors, 2 warnings, 290 lines checked
Patch 3/29 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/29 Checking commit 99200c7e4b0b (hw/arm: Express dependencies of the exynos machines with Kconfig)
5/29 Checking commit 80448178fec7 (hw/arm: Express dependencies of the highbank machines with Kconfig)
6/29 Checking commit 94baf18b8031 (hw/arm: Express dependencies of integratorcp with Kconfig)
7/29 Checking commit 98422e573261 (hw/arm: Express dependencies of the fsl-imx31 machine with Kconfig)
8/29 Checking commit 7e669c51cf64 (hw/arm: Express dependencies of musicpal with Kconfig)
9/29 Checking commit c21e5c7fb52c (hw/arm: Express dependencies of the OMAP machines with Kconfig)
10/29 Checking commit 475f8aeca0b8 (hw/arm: Express dependencies of stellaris with Kconfig)
11/29 Checking commit 9f01ca888983 (hw/arm: Express dependencies of realview, versatile and vexpress with Kconfig)
12/29 Checking commit 5e3d8a97402c (hw/arm: Express dependencies of the PXA2xx machines with Kconfig)
13/29 Checking commit 2b7d5906ca99 (hw/arm: Express dependencies of xilinx-zynq with Kconfig)
14/29 Checking commit e3342d666514 (hw/arm: Express dependencies of collie with Kconfig)
15/29 Checking commit fd99e7322fc7 (hw/arm: Express dependencies of the aspeed boards with Kconfig)
16/29 Checking commit 18f1a551d87e (hw/arm: Express dependencies of the virt machine with Kconfig)
17/29 Checking commit 58d1e7b58e0f (hw/arm: Express dependencies of netduino / stm32f2xx with Kconfig)
18/29 Checking commit f52e0f02a06a (hw/arm: Express dependencies of allwinner / cubieboard with Kconfig)
19/29 Checking commit 543bf8a7a2ae (hw/arm: Express dependencies of the MPS2 boards with Kconfig)
20/29 Checking commit de1ad282418c (hw/arm: Express dependencies of the raspi machines with Kconfig)
21/29 Checking commit 1c24fa816d4e (hw/arm: Express dependencies of canon-a1100 with Kconfig)
22/29 Checking commit 3238b4b7e33a (hw/arm: Express dependencies of sabrelite with Kconfig)
23/29 Checking commit 2ed93aae1e68 (hw/arm: Express dependencies of the MSF2 / EMCRAFT_SF2 machine with Kconfig)
24/29 Checking commit b401ff6f8a73 (hw/arm: Express dependencies for remaining IMX boards with Kconfig)
25/29 Checking commit 073ba3a04384 (hw/arm: Express dependencies of the microbit / nrf51 machine with Kconfig)
26/29 Checking commit 89816717cce4 (hw/arm: Express dependencies of the ZynqMP zcu102 machine with Kconfig)
27/29 Checking commit 2fe0991947d4 (hw/arm: Express dependencies of the xlnx-versal-virt machine with Kconfig)
28/29 Checking commit 5972e76d91b5 (hw/arm: Express dependencies of the musca machines with Kconfig)
29/29 Checking commit 7a49f0e7fc3d (hw/arm: Remove hard-enablement of the remaining PCI devices)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/1551968334-18982-1-git-send-email-thuth@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com