MAINTAINERS | 2 + docs/devel/s390-dasd-ipl.txt | 133 ++++++++++++++ hw/s390x/ipl.c | 39 +++- hw/s390x/s390-ccw.c | 9 + hw/vfio/ccw.c | 2 +- include/hw/s390x/s390-ccw.h | 1 + include/hw/s390x/vfio-ccw.h | 28 +++ pc-bios/s390-ccw/Makefile | 2 +- pc-bios/s390-ccw/cio.c | 418 +++++++++++++++++++++++++++++++++++++++++++ pc-bios/s390-ccw/cio.h | 307 +++++++++++++++++++++++-------- pc-bios/s390-ccw/dasd-ipl.c | 250 ++++++++++++++++++++++++++ pc-bios/s390-ccw/dasd-ipl.h | 16 ++ pc-bios/s390-ccw/helper.h | 16 ++ pc-bios/s390-ccw/libc.h | 11 ++ pc-bios/s390-ccw/main.c | 159 ++++++++++------ pc-bios/s390-ccw/netboot.mak | 2 +- pc-bios/s390-ccw/netmain.c | 1 + pc-bios/s390-ccw/s390-arch.h | 115 ++++++++++++ pc-bios/s390-ccw/s390-ccw.h | 10 +- pc-bios/s390-ccw/start.S | 31 ++++ pc-bios/s390-ccw/virtio.c | 74 +++----- tests/boot-serial-test.c | 2 +- 22 files changed, 1422 insertions(+), 206 deletions(-) create mode 100644 docs/devel/s390-dasd-ipl.txt create mode 100644 include/hw/s390x/vfio-ccw.h create mode 100644 pc-bios/s390-ccw/cio.c create mode 100644 pc-bios/s390-ccw/dasd-ipl.c create mode 100644 pc-bios/s390-ccw/dasd-ipl.h create mode 100644 pc-bios/s390-ccw/helper.h create mode 100644 pc-bios/s390-ccw/s390-arch.h
This is to support booting from vfio-ccw dasd devices. We basically implement the real hardware ipl procedure. This allows for booting Linux guests on vfio-ccw devices. vfio-ccw's channel program prefetch algorithm complicates ipl because most ipl channel programs dynamically modify themselves. Details on the ipl process and how we worked around this issue can be found in docs/devel/s390-dasd-ipl.txt. Note to Connie: In the v2 review you mentioned some issues with the error handling code involving printing of the eckd dasd sense data. I've addressed those concerns in a new patch just to make those changes clearly stand out from the rest of the code. I can squash them into patches 10, 11, and 15 if you prefer that to having it as a separate patch. Changelog ========== v3 01/16: s390 vfio-ccw: Add bootindex property and IPLB data - Refactored s390_get_ccw_device() to return device type - Made VFIOCCWDevice private - Fixed copyright date - ipl.c: Remove unneeded cast - Add new file to maintainers 05/16: s390-bios: Factor finding boot device out of virtio code path - main.c: Remove redundant condition from assert statement 06/16: s390-bios: Clean up cio.h - Switch formating of bit fields to make checkpatch happy 07/16: s390-bios: Decouple channel i/o logic from virtio - Fixed copyright statement - Remove unneeded include in virtio-blkdev.c 08/16: s390-bios: Map low core memory - Removed packed attribute from psw structs, added static size asserts - Fix copyright date 09/16: s390-bios: ptr2u32 and u32toptr - Move new functions out of stdlib.h and into helper.h 10/16: s390-bios: Support for running format-0/1 channel programs - Rework do_cio (create __do_cio) to avoid possible infinite recursion in error cases. - Switch formating of bit fields to make checkpatch happy - cio.c: Include helper.c for new pointer conversion functions - cio.c: Rename sense_data_eckd_dasd to SenseDataEckdDasd 11/16: s390-bios: cio error handling - Only print dasd sense data if we have a dasd device, or on initial query of control unit type - Fixed ccw casting 12/16: s390-bios: Refactor virtio to run channel programs via cio - Include helper.c for new pointer conversion functions 15/16: s390-bios: Support booting from real dasd device - dasd-ipl.c: Fix sizeof's - s390-dasd-ipl.c: Fix section "How this all pertains to QEMU" to detail vfio-ccw driver's role. - s390-dasd-ipl.c: Replace all instances of Qemu with QEMU - Added docs/devel/s390-dasd-ipl.txt to MAINTAINERS - s390-dasd-ipl.c: Include helper.c for new pointer conversion functions Jason J. Herne (16): s390 vfio-ccw: Add bootindex property and IPLB data s390-bios: decouple cio setup from virtio s390-bios: decouple common boot logic from virtio s390-bios: Extend find_dev() for non-virtio devices s390-bios: Factor finding boot device out of virtio code path s390-bios: Clean up cio.h s390-bios: Decouple channel i/o logic from virtio s390-bios: Map low core memory s390-bios: ptr2u32 and u32toptr s390-bios: Support for running format-0/1 channel programs s390-bios: cio error handling s390-bios: Refactor virtio to run channel programs via cio s390-bios: Use control unit type to determine boot method s390-bios: Add channel command codes/structs needed for dasd-ipl s390-bios: Support booting from real dasd device s390-bios: dasd-ipl: Use control unit type to customize error data MAINTAINERS | 2 + docs/devel/s390-dasd-ipl.txt | 133 ++++++++++++++ hw/s390x/ipl.c | 39 +++- hw/s390x/s390-ccw.c | 9 + hw/vfio/ccw.c | 2 +- include/hw/s390x/s390-ccw.h | 1 + include/hw/s390x/vfio-ccw.h | 28 +++ pc-bios/s390-ccw/Makefile | 2 +- pc-bios/s390-ccw/cio.c | 418 +++++++++++++++++++++++++++++++++++++++++++ pc-bios/s390-ccw/cio.h | 307 +++++++++++++++++++++++-------- pc-bios/s390-ccw/dasd-ipl.c | 250 ++++++++++++++++++++++++++ pc-bios/s390-ccw/dasd-ipl.h | 16 ++ pc-bios/s390-ccw/helper.h | 16 ++ pc-bios/s390-ccw/libc.h | 11 ++ pc-bios/s390-ccw/main.c | 159 ++++++++++------ pc-bios/s390-ccw/netboot.mak | 2 +- pc-bios/s390-ccw/netmain.c | 1 + pc-bios/s390-ccw/s390-arch.h | 115 ++++++++++++ pc-bios/s390-ccw/s390-ccw.h | 10 +- pc-bios/s390-ccw/start.S | 31 ++++ pc-bios/s390-ccw/virtio.c | 74 +++----- tests/boot-serial-test.c | 2 +- 22 files changed, 1422 insertions(+), 206 deletions(-) create mode 100644 docs/devel/s390-dasd-ipl.txt create mode 100644 include/hw/s390x/vfio-ccw.h create mode 100644 pc-bios/s390-ccw/cio.c create mode 100644 pc-bios/s390-ccw/dasd-ipl.c create mode 100644 pc-bios/s390-ccw/dasd-ipl.h create mode 100644 pc-bios/s390-ccw/helper.h create mode 100644 pc-bios/s390-ccw/s390-arch.h -- 2.7.4
Patchew URL: https://patchew.org/QEMU/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1551466776-29123-1-git-send-email-jjherne@linux.ibm.com Subject: [Qemu-devel] [PATCH v3 00/16] s390: vfio-ccw dasd ipl support === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com -> patchew/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com Switched to a new branch 'test' f500a324be s390-bios: dasd-ipl: Use control unit type to customize error data 61683f31fd s390-bios: Support booting from real dasd device 59e5199d22 s390-bios: Add channel command codes/structs needed for dasd-ipl 9add6dde7e s390-bios: Use control unit type to determine boot method 45b1810ae5 s390-bios: Refactor virtio to run channel programs via cio f7fff67468 s390-bios: cio error handling 88f0121304 s390-bios: Support for running format-0/1 channel programs c689028ed0 s390-bios: ptr2u32 and u32toptr 6753adcac4 s390-bios: Map low core memory 13ab2fb569 s390-bios: Decouple channel i/o logic from virtio 634aaae0e9 s390-bios: Clean up cio.h 983db7d6f6 s390-bios: Factor finding boot device out of virtio code path 37c8283d8b s390-bios: Extend find_dev() for non-virtio devices 986462d0c6 s390-bios: decouple common boot logic from virtio 6eecc37451 s390-bios: decouple cio setup from virtio bab9fd0907 s390 vfio-ccw: Add bootindex property and IPLB data === OUTPUT BEGIN === 1/16 Checking commit bab9fd090720 (s390 vfio-ccw: Add bootindex property and IPLB data) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #205: new file mode 100644 total: 0 errors, 1 warnings, 181 lines checked Patch 1/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/16 Checking commit 6eecc3745137 (s390-bios: decouple cio setup from virtio) 3/16 Checking commit 986462d0c69c (s390-bios: decouple common boot logic from virtio) ERROR: externs should be avoided in .c files #31: FILE: pc-bios/s390-ccw/main.c:19: +IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE))); total: 1 errors, 0 warnings, 65 lines checked Patch 3/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/16 Checking commit 37c8283d8bde (s390-bios: Extend find_dev() for non-virtio devices) 5/16 Checking commit 983db7d6f6e6 (s390-bios: Factor finding boot device out of virtio code path) 6/16 Checking commit 634aaae0e93d (s390-bios: Clean up cio.h) 7/16 Checking commit 13ab2fb56962 (s390-bios: Decouple channel i/o logic from virtio) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 122 lines checked Patch 7/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/16 Checking commit 6753adcac48a (s390-bios: Map low core memory) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #35: new file mode 100644 total: 0 errors, 1 warnings, 116 lines checked Patch 8/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/16 Checking commit c689028ed00a (s390-bios: ptr2u32 and u32toptr) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #16: new file mode 100644 total: 0 errors, 1 warnings, 16 lines checked Patch 9/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/16 Checking commit 88f012130413 (s390-bios: Support for running format-0/1 channel programs) 11/16 Checking commit f7fff67468f5 (s390-bios: cio error handling) 12/16 Checking commit 45b1810ae5c8 (s390-bios: Refactor virtio to run channel programs via cio) WARNING: line over 80 characters #103: FILE: pc-bios/s390-ccw/virtio.c:298: + run_ccw(vdev, CCW_CMD_READ_VQ_CONF, &config, sizeof(config), false) == 0, WARNING: line over 80 characters #116: FILE: pc-bios/s390-ccw/virtio.c:308: + run_ccw(vdev, CCW_CMD_WRITE_STATUS, &status, sizeof(status), false) == 0, total: 0 errors, 2 warnings, 107 lines checked Patch 12/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/16 Checking commit 9add6dde7e5b (s390-bios: Use control unit type to determine boot method) 14/16 Checking commit 59e5199d2251 (s390-bios: Add channel command codes/structs needed for dasd-ipl) 15/16 Checking commit 61683f31fd6f (s390-bios: Support booting from real dasd device) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #25: new file mode 100644 total: 0 errors, 1 warnings, 446 lines checked Patch 15/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/16 Checking commit f500a324bed9 (s390-bios: dasd-ipl: Use control unit type to customize error data) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1551466776-29123-1-git-send-email-jjherne@linux.ibm.com Subject: [Qemu-devel] [PATCH v3 00/16] s390: vfio-ccw dasd ipl support === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com -> patchew/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com Switched to a new branch 'test' 0a9e3c7c9c s390-bios: dasd-ipl: Use control unit type to customize error data 7ef97319b7 s390-bios: Support booting from real dasd device ba2ef41e10 s390-bios: Add channel command codes/structs needed for dasd-ipl 33263b448e s390-bios: Use control unit type to determine boot method 24fc2d1e7d s390-bios: Refactor virtio to run channel programs via cio b1dca5b66a s390-bios: cio error handling 5a87891a44 s390-bios: Support for running format-0/1 channel programs c1e4f88640 s390-bios: ptr2u32 and u32toptr 2cc70e81c6 s390-bios: Map low core memory 62a450c7a8 s390-bios: Decouple channel i/o logic from virtio d907f80f02 s390-bios: Clean up cio.h 0dda9ad2ae s390-bios: Factor finding boot device out of virtio code path d91d27f0bf s390-bios: Extend find_dev() for non-virtio devices 8d085339e8 s390-bios: decouple common boot logic from virtio f698064311 s390-bios: decouple cio setup from virtio 7a8011e385 s390 vfio-ccw: Add bootindex property and IPLB data === OUTPUT BEGIN === 1/16 Checking commit 7a8011e38589 (s390 vfio-ccw: Add bootindex property and IPLB data) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #205: new file mode 100644 total: 0 errors, 1 warnings, 181 lines checked Patch 1/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/16 Checking commit f6980643114b (s390-bios: decouple cio setup from virtio) 3/16 Checking commit 8d085339e8d1 (s390-bios: decouple common boot logic from virtio) ERROR: externs should be avoided in .c files #31: FILE: pc-bios/s390-ccw/main.c:19: +IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE))); total: 1 errors, 0 warnings, 65 lines checked Patch 3/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/16 Checking commit d91d27f0bf15 (s390-bios: Extend find_dev() for non-virtio devices) 5/16 Checking commit 0dda9ad2aee5 (s390-bios: Factor finding boot device out of virtio code path) 6/16 Checking commit d907f80f026e (s390-bios: Clean up cio.h) 7/16 Checking commit 62a450c7a85d (s390-bios: Decouple channel i/o logic from virtio) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 122 lines checked Patch 7/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/16 Checking commit 2cc70e81c6ae (s390-bios: Map low core memory) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #35: new file mode 100644 total: 0 errors, 1 warnings, 116 lines checked Patch 8/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/16 Checking commit c1e4f886404f (s390-bios: ptr2u32 and u32toptr) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #16: new file mode 100644 total: 0 errors, 1 warnings, 16 lines checked Patch 9/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/16 Checking commit 5a87891a44c6 (s390-bios: Support for running format-0/1 channel programs) 11/16 Checking commit b1dca5b66a3e (s390-bios: cio error handling) 12/16 Checking commit 24fc2d1e7d93 (s390-bios: Refactor virtio to run channel programs via cio) WARNING: line over 80 characters #103: FILE: pc-bios/s390-ccw/virtio.c:298: + run_ccw(vdev, CCW_CMD_READ_VQ_CONF, &config, sizeof(config), false) == 0, WARNING: line over 80 characters #116: FILE: pc-bios/s390-ccw/virtio.c:308: + run_ccw(vdev, CCW_CMD_WRITE_STATUS, &status, sizeof(status), false) == 0, total: 0 errors, 2 warnings, 107 lines checked Patch 12/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/16 Checking commit 33263b448e9e (s390-bios: Use control unit type to determine boot method) 14/16 Checking commit ba2ef41e1004 (s390-bios: Add channel command codes/structs needed for dasd-ipl) 15/16 Checking commit 7ef97319b7d1 (s390-bios: Support booting from real dasd device) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #25: new file mode 100644 total: 0 errors, 1 warnings, 446 lines checked Patch 15/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/16 Checking commit 0a9e3c7c9c20 (s390-bios: dasd-ipl: Use control unit type to customize error data) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1551466776-29123-1-git-send-email-jjherne@linux.ibm.com Subject: [Qemu-devel] [PATCH v3 00/16] s390: vfio-ccw dasd ipl support === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com -> patchew/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com Switched to a new branch 'test' ea3f849172 s390-bios: dasd-ipl: Use control unit type to customize error data 861af1f24c s390-bios: Support booting from real dasd device cc519e5366 s390-bios: Add channel command codes/structs needed for dasd-ipl 931e58a5f0 s390-bios: Use control unit type to determine boot method f01741d9b4 s390-bios: Refactor virtio to run channel programs via cio afa1f9f876 s390-bios: cio error handling f33e472d62 s390-bios: Support for running format-0/1 channel programs 24afeab7ac s390-bios: ptr2u32 and u32toptr 511f57aef9 s390-bios: Map low core memory f8c6f0def0 s390-bios: Decouple channel i/o logic from virtio fd0a84ecad s390-bios: Clean up cio.h 063cbb9411 s390-bios: Factor finding boot device out of virtio code path 9c186bd53e s390-bios: Extend find_dev() for non-virtio devices 5badca2943 s390-bios: decouple common boot logic from virtio 8ceea012c1 s390-bios: decouple cio setup from virtio 1142cb1195 s390 vfio-ccw: Add bootindex property and IPLB data === OUTPUT BEGIN === 1/16 Checking commit 1142cb11950a (s390 vfio-ccw: Add bootindex property and IPLB data) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #205: new file mode 100644 total: 0 errors, 1 warnings, 181 lines checked Patch 1/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/16 Checking commit 8ceea012c10e (s390-bios: decouple cio setup from virtio) 3/16 Checking commit 5badca294319 (s390-bios: decouple common boot logic from virtio) ERROR: externs should be avoided in .c files #31: FILE: pc-bios/s390-ccw/main.c:19: +IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE))); total: 1 errors, 0 warnings, 65 lines checked Patch 3/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/16 Checking commit 9c186bd53ea2 (s390-bios: Extend find_dev() for non-virtio devices) 5/16 Checking commit 063cbb9411a3 (s390-bios: Factor finding boot device out of virtio code path) 6/16 Checking commit fd0a84ecadb1 (s390-bios: Clean up cio.h) 7/16 Checking commit f8c6f0def094 (s390-bios: Decouple channel i/o logic from virtio) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 122 lines checked Patch 7/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/16 Checking commit 511f57aef9bb (s390-bios: Map low core memory) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #36: new file mode 100644 total: 0 errors, 1 warnings, 116 lines checked Patch 8/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/16 Checking commit 24afeab7ac9a (s390-bios: ptr2u32 and u32toptr) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #17: new file mode 100644 total: 0 errors, 1 warnings, 16 lines checked Patch 9/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/16 Checking commit f33e472d6271 (s390-bios: Support for running format-0/1 channel programs) 11/16 Checking commit afa1f9f87611 (s390-bios: cio error handling) 12/16 Checking commit f01741d9b4b1 (s390-bios: Refactor virtio to run channel programs via cio) WARNING: line over 80 characters #103: FILE: pc-bios/s390-ccw/virtio.c:298: + run_ccw(vdev, CCW_CMD_READ_VQ_CONF, &config, sizeof(config), false) == 0, WARNING: line over 80 characters #116: FILE: pc-bios/s390-ccw/virtio.c:308: + run_ccw(vdev, CCW_CMD_WRITE_STATUS, &status, sizeof(status), false) == 0, total: 0 errors, 2 warnings, 107 lines checked Patch 12/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/16 Checking commit 931e58a5f0dc (s390-bios: Use control unit type to determine boot method) 14/16 Checking commit cc519e5366c0 (s390-bios: Add channel command codes/structs needed for dasd-ipl) 15/16 Checking commit 861af1f24cd1 (s390-bios: Support booting from real dasd device) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #26: new file mode 100644 total: 0 errors, 1 warnings, 446 lines checked Patch 15/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/16 Checking commit ea3f8491728b (s390-bios: dasd-ipl: Use control unit type to customize error data) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1551466776-29123-1-git-send-email-jjherne@linux.ibm.com Subject: [Qemu-devel] [PATCH v3 00/16] s390: vfio-ccw dasd ipl support === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com -> patchew/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com Switched to a new branch 'test' b7aaa9c703 s390-bios: dasd-ipl: Use control unit type to customize error data 52085b8f83 s390-bios: Support booting from real dasd device 69408610f4 s390-bios: Add channel command codes/structs needed for dasd-ipl cc0aaac6c7 s390-bios: Use control unit type to determine boot method 434eec95bf s390-bios: Refactor virtio to run channel programs via cio 66dd80c18c s390-bios: cio error handling 657592efa5 s390-bios: Support for running format-0/1 channel programs 1375c50da1 s390-bios: ptr2u32 and u32toptr 637b957361 s390-bios: Map low core memory 66e4245468 s390-bios: Decouple channel i/o logic from virtio 31d8ec0aff s390-bios: Clean up cio.h 88c8d0052e s390-bios: Factor finding boot device out of virtio code path fe2b50f585 s390-bios: Extend find_dev() for non-virtio devices ad96715604 s390-bios: decouple common boot logic from virtio 2541ee0520 s390-bios: decouple cio setup from virtio e08dc9e136 s390 vfio-ccw: Add bootindex property and IPLB data === OUTPUT BEGIN === 1/16 Checking commit e08dc9e1365f (s390 vfio-ccw: Add bootindex property and IPLB data) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #205: new file mode 100644 total: 0 errors, 1 warnings, 181 lines checked Patch 1/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/16 Checking commit 2541ee05208e (s390-bios: decouple cio setup from virtio) 3/16 Checking commit ad967156046b (s390-bios: decouple common boot logic from virtio) ERROR: externs should be avoided in .c files #31: FILE: pc-bios/s390-ccw/main.c:19: +IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE))); total: 1 errors, 0 warnings, 65 lines checked Patch 3/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/16 Checking commit fe2b50f585af (s390-bios: Extend find_dev() for non-virtio devices) 5/16 Checking commit 88c8d0052e0c (s390-bios: Factor finding boot device out of virtio code path) 6/16 Checking commit 31d8ec0aff5d (s390-bios: Clean up cio.h) 7/16 Checking commit 66e424546827 (s390-bios: Decouple channel i/o logic from virtio) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 122 lines checked Patch 7/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/16 Checking commit 637b95736185 (s390-bios: Map low core memory) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #36: new file mode 100644 total: 0 errors, 1 warnings, 116 lines checked Patch 8/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/16 Checking commit 1375c50da1bd (s390-bios: ptr2u32 and u32toptr) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #17: new file mode 100644 total: 0 errors, 1 warnings, 16 lines checked Patch 9/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/16 Checking commit 657592efa58a (s390-bios: Support for running format-0/1 channel programs) 11/16 Checking commit 66dd80c18cec (s390-bios: cio error handling) 12/16 Checking commit 434eec95bf37 (s390-bios: Refactor virtio to run channel programs via cio) WARNING: line over 80 characters #103: FILE: pc-bios/s390-ccw/virtio.c:298: + run_ccw(vdev, CCW_CMD_READ_VQ_CONF, &config, sizeof(config), false) == 0, WARNING: line over 80 characters #116: FILE: pc-bios/s390-ccw/virtio.c:308: + run_ccw(vdev, CCW_CMD_WRITE_STATUS, &status, sizeof(status), false) == 0, total: 0 errors, 2 warnings, 107 lines checked Patch 12/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/16 Checking commit cc0aaac6c7f4 (s390-bios: Use control unit type to determine boot method) 14/16 Checking commit 69408610f403 (s390-bios: Add channel command codes/structs needed for dasd-ipl) 15/16 Checking commit 52085b8f83c6 (s390-bios: Support booting from real dasd device) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #25: new file mode 100644 total: 0 errors, 1 warnings, 446 lines checked Patch 15/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/16 Checking commit b7aaa9c703e1 (s390-bios: dasd-ipl: Use control unit type to customize error data) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1551466776-29123-1-git-send-email-jjherne@linux.ibm.com Subject: [Qemu-devel] [PATCH v3 00/16] s390: vfio-ccw dasd ipl support === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com -> patchew/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com Switched to a new branch 'test' 9dceea1b14 s390-bios: dasd-ipl: Use control unit type to customize error data 32e8d139b3 s390-bios: Support booting from real dasd device 938b0da771 s390-bios: Add channel command codes/structs needed for dasd-ipl 4be4aaf6e1 s390-bios: Use control unit type to determine boot method 842817499f s390-bios: Refactor virtio to run channel programs via cio 2b2e643070 s390-bios: cio error handling 559e1945f8 s390-bios: Support for running format-0/1 channel programs 83b111ce4a s390-bios: ptr2u32 and u32toptr e05b6c3ada s390-bios: Map low core memory 6f706c8864 s390-bios: Decouple channel i/o logic from virtio 1f9f7b59a6 s390-bios: Clean up cio.h a4238c176e s390-bios: Factor finding boot device out of virtio code path d692e619f6 s390-bios: Extend find_dev() for non-virtio devices 0217b7e4a4 s390-bios: decouple common boot logic from virtio 5963e0293d s390-bios: decouple cio setup from virtio ac242eb901 s390 vfio-ccw: Add bootindex property and IPLB data === OUTPUT BEGIN === 1/16 Checking commit ac242eb90150 (s390 vfio-ccw: Add bootindex property and IPLB data) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #205: new file mode 100644 total: 0 errors, 1 warnings, 181 lines checked Patch 1/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/16 Checking commit 5963e0293dc3 (s390-bios: decouple cio setup from virtio) 3/16 Checking commit 0217b7e4a4e6 (s390-bios: decouple common boot logic from virtio) ERROR: externs should be avoided in .c files #31: FILE: pc-bios/s390-ccw/main.c:19: +IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE))); total: 1 errors, 0 warnings, 65 lines checked Patch 3/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/16 Checking commit d692e619f6cc (s390-bios: Extend find_dev() for non-virtio devices) 5/16 Checking commit a4238c176e9c (s390-bios: Factor finding boot device out of virtio code path) 6/16 Checking commit 1f9f7b59a60f (s390-bios: Clean up cio.h) 7/16 Checking commit 6f706c886483 (s390-bios: Decouple channel i/o logic from virtio) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 122 lines checked Patch 7/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/16 Checking commit e05b6c3adab4 (s390-bios: Map low core memory) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #36: new file mode 100644 total: 0 errors, 1 warnings, 116 lines checked Patch 8/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/16 Checking commit 83b111ce4ae6 (s390-bios: ptr2u32 and u32toptr) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #17: new file mode 100644 total: 0 errors, 1 warnings, 16 lines checked Patch 9/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/16 Checking commit 559e1945f8de (s390-bios: Support for running format-0/1 channel programs) 11/16 Checking commit 2b2e6430704d (s390-bios: cio error handling) 12/16 Checking commit 842817499f32 (s390-bios: Refactor virtio to run channel programs via cio) WARNING: line over 80 characters #103: FILE: pc-bios/s390-ccw/virtio.c:298: + run_ccw(vdev, CCW_CMD_READ_VQ_CONF, &config, sizeof(config), false) == 0, WARNING: line over 80 characters #116: FILE: pc-bios/s390-ccw/virtio.c:308: + run_ccw(vdev, CCW_CMD_WRITE_STATUS, &status, sizeof(status), false) == 0, total: 0 errors, 2 warnings, 107 lines checked Patch 12/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/16 Checking commit 4be4aaf6e1a9 (s390-bios: Use control unit type to determine boot method) 14/16 Checking commit 938b0da7715b (s390-bios: Add channel command codes/structs needed for dasd-ipl) 15/16 Checking commit 32e8d139b336 (s390-bios: Support booting from real dasd device) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #25: new file mode 100644 total: 0 errors, 1 warnings, 446 lines checked Patch 15/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/16 Checking commit 9dceea1b14bc (s390-bios: dasd-ipl: Use control unit type to customize error data) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1551466776-29123-1-git-send-email-jjherne@linux.ibm.com Subject: [Qemu-devel] [PATCH v3 00/16] s390: vfio-ccw dasd ipl support === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com -> patchew/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com Switched to a new branch 'test' 46caf3a119 s390-bios: dasd-ipl: Use control unit type to customize error data 14cba76f6c s390-bios: Support booting from real dasd device 67b3fe266d s390-bios: Add channel command codes/structs needed for dasd-ipl db787040a4 s390-bios: Use control unit type to determine boot method 97556e4f3e s390-bios: Refactor virtio to run channel programs via cio 9449a3f1e8 s390-bios: cio error handling 8204170c3a s390-bios: Support for running format-0/1 channel programs 476cd55407 s390-bios: ptr2u32 and u32toptr 86ab42c2f9 s390-bios: Map low core memory 299f41be09 s390-bios: Decouple channel i/o logic from virtio e944d771e7 s390-bios: Clean up cio.h d3d079f955 s390-bios: Factor finding boot device out of virtio code path 10bc58cea4 s390-bios: Extend find_dev() for non-virtio devices 1e45cd7e92 s390-bios: decouple common boot logic from virtio 382aadfbb2 s390-bios: decouple cio setup from virtio 007b05756b s390 vfio-ccw: Add bootindex property and IPLB data === OUTPUT BEGIN === 1/16 Checking commit 007b05756bc0 (s390 vfio-ccw: Add bootindex property and IPLB data) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #205: new file mode 100644 total: 0 errors, 1 warnings, 181 lines checked Patch 1/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/16 Checking commit 382aadfbb2ca (s390-bios: decouple cio setup from virtio) 3/16 Checking commit 1e45cd7e926a (s390-bios: decouple common boot logic from virtio) ERROR: externs should be avoided in .c files #31: FILE: pc-bios/s390-ccw/main.c:19: +IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE))); total: 1 errors, 0 warnings, 65 lines checked Patch 3/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/16 Checking commit 10bc58cea47a (s390-bios: Extend find_dev() for non-virtio devices) 5/16 Checking commit d3d079f9558e (s390-bios: Factor finding boot device out of virtio code path) 6/16 Checking commit e944d771e779 (s390-bios: Clean up cio.h) 7/16 Checking commit 299f41be09f9 (s390-bios: Decouple channel i/o logic from virtio) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 122 lines checked Patch 7/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/16 Checking commit 86ab42c2f93a (s390-bios: Map low core memory) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #36: new file mode 100644 total: 0 errors, 1 warnings, 116 lines checked Patch 8/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/16 Checking commit 476cd554074a (s390-bios: ptr2u32 and u32toptr) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #16: new file mode 100644 total: 0 errors, 1 warnings, 16 lines checked Patch 9/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/16 Checking commit 8204170c3a2f (s390-bios: Support for running format-0/1 channel programs) 11/16 Checking commit 9449a3f1e8fd (s390-bios: cio error handling) 12/16 Checking commit 97556e4f3e7f (s390-bios: Refactor virtio to run channel programs via cio) WARNING: line over 80 characters #103: FILE: pc-bios/s390-ccw/virtio.c:298: + run_ccw(vdev, CCW_CMD_READ_VQ_CONF, &config, sizeof(config), false) == 0, WARNING: line over 80 characters #116: FILE: pc-bios/s390-ccw/virtio.c:308: + run_ccw(vdev, CCW_CMD_WRITE_STATUS, &status, sizeof(status), false) == 0, total: 0 errors, 2 warnings, 107 lines checked Patch 12/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/16 Checking commit db787040a465 (s390-bios: Use control unit type to determine boot method) 14/16 Checking commit 67b3fe266da2 (s390-bios: Add channel command codes/structs needed for dasd-ipl) 15/16 Checking commit 14cba76f6cd2 (s390-bios: Support booting from real dasd device) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #25: new file mode 100644 total: 0 errors, 1 warnings, 446 lines checked Patch 15/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/16 Checking commit 46caf3a119e2 (s390-bios: dasd-ipl: Use control unit type to customize error data) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1551466776-29123-1-git-send-email-jjherne@linux.ibm.com Subject: [Qemu-devel] [PATCH v3 00/16] s390: vfio-ccw dasd ipl support === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu 88687719c8..b6179aaff9 master -> master t [tag update] patchew/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com -> patchew/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com Switched to a new branch 'test' 1255bffda9 s390-bios: dasd-ipl: Use control unit type to customize error data c5cbb3e0e3 s390-bios: Support booting from real dasd device 94998e8aef s390-bios: Add channel command codes/structs needed for dasd-ipl 8cab135f1f s390-bios: Use control unit type to determine boot method 0839e39d7e s390-bios: Refactor virtio to run channel programs via cio 47ecb89929 s390-bios: cio error handling 6ed51be6e9 s390-bios: Support for running format-0/1 channel programs e91f12a0e8 s390-bios: ptr2u32 and u32toptr ddb9098d6a s390-bios: Map low core memory fcbe10b9a4 s390-bios: Decouple channel i/o logic from virtio 7054d8f76c s390-bios: Clean up cio.h 8dd54ea4db s390-bios: Factor finding boot device out of virtio code path b2c9cd304a s390-bios: Extend find_dev() for non-virtio devices bc538e2273 s390-bios: decouple common boot logic from virtio 5921529560 s390-bios: decouple cio setup from virtio 771e74f350 s390 vfio-ccw: Add bootindex property and IPLB data === OUTPUT BEGIN === 1/16 Checking commit 771e74f3508a (s390 vfio-ccw: Add bootindex property and IPLB data) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #205: new file mode 100644 total: 0 errors, 1 warnings, 181 lines checked Patch 1/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/16 Checking commit 592152956073 (s390-bios: decouple cio setup from virtio) 3/16 Checking commit bc538e2273cc (s390-bios: decouple common boot logic from virtio) ERROR: externs should be avoided in .c files #31: FILE: pc-bios/s390-ccw/main.c:19: +IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE))); total: 1 errors, 0 warnings, 65 lines checked Patch 3/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/16 Checking commit b2c9cd304a79 (s390-bios: Extend find_dev() for non-virtio devices) 5/16 Checking commit 8dd54ea4dbb8 (s390-bios: Factor finding boot device out of virtio code path) 6/16 Checking commit 7054d8f76cdc (s390-bios: Clean up cio.h) 7/16 Checking commit fcbe10b9a4ce (s390-bios: Decouple channel i/o logic from virtio) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 122 lines checked Patch 7/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/16 Checking commit ddb9098d6af2 (s390-bios: Map low core memory) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #36: new file mode 100644 total: 0 errors, 1 warnings, 116 lines checked Patch 8/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/16 Checking commit e91f12a0e82d (s390-bios: ptr2u32 and u32toptr) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #16: new file mode 100644 total: 0 errors, 1 warnings, 16 lines checked Patch 9/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/16 Checking commit 6ed51be6e9de (s390-bios: Support for running format-0/1 channel programs) 11/16 Checking commit 47ecb89929ac (s390-bios: cio error handling) 12/16 Checking commit 0839e39d7ed3 (s390-bios: Refactor virtio to run channel programs via cio) WARNING: line over 80 characters #103: FILE: pc-bios/s390-ccw/virtio.c:298: + run_ccw(vdev, CCW_CMD_READ_VQ_CONF, &config, sizeof(config), false) == 0, WARNING: line over 80 characters #116: FILE: pc-bios/s390-ccw/virtio.c:308: + run_ccw(vdev, CCW_CMD_WRITE_STATUS, &status, sizeof(status), false) == 0, total: 0 errors, 2 warnings, 107 lines checked Patch 12/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/16 Checking commit 8cab135f1f9a (s390-bios: Use control unit type to determine boot method) 14/16 Checking commit 94998e8aef86 (s390-bios: Add channel command codes/structs needed for dasd-ipl) 15/16 Checking commit c5cbb3e0e34d (s390-bios: Support booting from real dasd device) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #25: new file mode 100644 total: 0 errors, 1 warnings, 446 lines checked Patch 15/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/16 Checking commit 1255bffda9a8 (s390-bios: dasd-ipl: Use control unit type to customize error data) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1551466776-29123-1-git-send-email-jjherne@linux.ibm.com Subject: [Qemu-devel] [PATCH v3 00/16] s390: vfio-ccw dasd ipl support === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com -> patchew/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com Switched to a new branch 'test' a5193e6d29 s390-bios: dasd-ipl: Use control unit type to customize error data ad12cecc19 s390-bios: Support booting from real dasd device 9c01c8fb4e s390-bios: Add channel command codes/structs needed for dasd-ipl fa18355faa s390-bios: Use control unit type to determine boot method aeee35ab15 s390-bios: Refactor virtio to run channel programs via cio d78017247a s390-bios: cio error handling 585ae5fd4b s390-bios: Support for running format-0/1 channel programs 87ce30846b s390-bios: ptr2u32 and u32toptr dafea5d56b s390-bios: Map low core memory 3b4a91b886 s390-bios: Decouple channel i/o logic from virtio 0ffabfab9e s390-bios: Clean up cio.h 95328bb6bc s390-bios: Factor finding boot device out of virtio code path 387a9d2875 s390-bios: Extend find_dev() for non-virtio devices e2bcf15817 s390-bios: decouple common boot logic from virtio 9402b93fa5 s390-bios: decouple cio setup from virtio 3167d5b7cb s390 vfio-ccw: Add bootindex property and IPLB data === OUTPUT BEGIN === 1/16 Checking commit 3167d5b7cbdb (s390 vfio-ccw: Add bootindex property and IPLB data) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #205: new file mode 100644 total: 0 errors, 1 warnings, 181 lines checked Patch 1/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/16 Checking commit 9402b93fa53a (s390-bios: decouple cio setup from virtio) 3/16 Checking commit e2bcf15817d2 (s390-bios: decouple common boot logic from virtio) ERROR: externs should be avoided in .c files #31: FILE: pc-bios/s390-ccw/main.c:19: +IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE))); total: 1 errors, 0 warnings, 65 lines checked Patch 3/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/16 Checking commit 387a9d287506 (s390-bios: Extend find_dev() for non-virtio devices) 5/16 Checking commit 95328bb6bcf7 (s390-bios: Factor finding boot device out of virtio code path) 6/16 Checking commit 0ffabfab9e57 (s390-bios: Clean up cio.h) 7/16 Checking commit 3b4a91b88650 (s390-bios: Decouple channel i/o logic from virtio) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 122 lines checked Patch 7/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/16 Checking commit dafea5d56b0a (s390-bios: Map low core memory) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #35: new file mode 100644 total: 0 errors, 1 warnings, 116 lines checked Patch 8/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/16 Checking commit 87ce30846b71 (s390-bios: ptr2u32 and u32toptr) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #16: new file mode 100644 total: 0 errors, 1 warnings, 16 lines checked Patch 9/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/16 Checking commit 585ae5fd4b46 (s390-bios: Support for running format-0/1 channel programs) 11/16 Checking commit d78017247ac4 (s390-bios: cio error handling) 12/16 Checking commit aeee35ab152a (s390-bios: Refactor virtio to run channel programs via cio) WARNING: line over 80 characters #103: FILE: pc-bios/s390-ccw/virtio.c:298: + run_ccw(vdev, CCW_CMD_READ_VQ_CONF, &config, sizeof(config), false) == 0, WARNING: line over 80 characters #116: FILE: pc-bios/s390-ccw/virtio.c:308: + run_ccw(vdev, CCW_CMD_WRITE_STATUS, &status, sizeof(status), false) == 0, total: 0 errors, 2 warnings, 107 lines checked Patch 12/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/16 Checking commit fa18355faaab (s390-bios: Use control unit type to determine boot method) 14/16 Checking commit 9c01c8fb4e3a (s390-bios: Add channel command codes/structs needed for dasd-ipl) 15/16 Checking commit ad12cecc1953 (s390-bios: Support booting from real dasd device) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #25: new file mode 100644 total: 0 errors, 1 warnings, 446 lines checked Patch 15/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/16 Checking commit a5193e6d297b (s390-bios: dasd-ipl: Use control unit type to customize error data) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
On Fri, 1 Mar 2019 13:59:20 -0500 "Jason J. Herne" <jjherne@linux.ibm.com> wrote: > This is to support booting from vfio-ccw dasd devices. We basically implement > the real hardware ipl procedure. This allows for booting Linux guests on > vfio-ccw devices. > > vfio-ccw's channel program prefetch algorithm complicates ipl because most ipl > channel programs dynamically modify themselves. Details on the ipl process and > how we worked around this issue can be found in docs/devel/s390-dasd-ipl.txt. > > Note to Connie: In the v2 review you mentioned some issues with the error > handling code involving printing of the eckd dasd sense data. I've addressed > those concerns in a new patch just to make those changes clearly stand out from > the rest of the code. I can squash them into patches 10, 11, and 15 if you > prefer that to having it as a separate patch. Whatever makes sense... but I'll let the s390 bios maintainers decide. Speaking of which: Please do keep Thomas on cc:... [This is probably a bit late for 4.0, as softfreeze is next Tuesday and pull requests for master need to be on-list by then... speaking of pull requests: I'd prefer to queue this via a pull request from the bios maintainers rather than picking the patches myself, if possible.]
On 04.03.2019 17:24, Cornelia Huck wrote: > On Fri, 1 Mar 2019 13:59:20 -0500 > "Jason J. Herne" <jjherne@linux.ibm.com> wrote: > >> This is to support booting from vfio-ccw dasd devices. We basically implement >> the real hardware ipl procedure. This allows for booting Linux guests on >> vfio-ccw devices. >> >> vfio-ccw's channel program prefetch algorithm complicates ipl because most ipl >> channel programs dynamically modify themselves. Details on the ipl process and >> how we worked around this issue can be found in docs/devel/s390-dasd-ipl.txt. >> >> Note to Connie: In the v2 review you mentioned some issues with the error >> handling code involving printing of the eckd dasd sense data. I've addressed >> those concerns in a new patch just to make those changes clearly stand out from >> the rest of the code. I can squash them into patches 10, 11, and 15 if you >> prefer that to having it as a separate patch. > > Whatever makes sense... but I'll let the s390 bios maintainers decide. Both variants are fine with me. > > Speaking of which: Please do keep Thomas on cc:... > > [This is probably a bit late for 4.0, as softfreeze is next Tuesday and > pull requests for master need to be on-list by then... speaking of pull > requests: I'd prefer to queue this via a pull request from the bios > maintainers rather than picking the patches myself, if possible.] there are still some minor discussions on the patch set, but I (or Thomas) can certainly pick up the next version and send a pull request. Thomas do you want to do it or shall I take care about it?
Patchew URL: https://patchew.org/QEMU/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1551466776-29123-1-git-send-email-jjherne@linux.ibm.com Subject: [Qemu-devel] [PATCH v3 00/16] s390: vfio-ccw dasd ipl support === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com -> patchew/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com Switched to a new branch 'test' 73739b0cc6 s390-bios: dasd-ipl: Use control unit type to customize error data 8733330492 s390-bios: Support booting from real dasd device 5a5c4b01ef s390-bios: Add channel command codes/structs needed for dasd-ipl d23ff47a3d s390-bios: Use control unit type to determine boot method 2af24581b4 s390-bios: Refactor virtio to run channel programs via cio 631002c644 s390-bios: cio error handling 44d5259870 s390-bios: Support for running format-0/1 channel programs 7244df5a79 s390-bios: ptr2u32 and u32toptr af222f5618 s390-bios: Map low core memory 281f64b37a s390-bios: Decouple channel i/o logic from virtio 4ac96c2c10 s390-bios: Clean up cio.h 06ea714695 s390-bios: Factor finding boot device out of virtio code path a99947c33d s390-bios: Extend find_dev() for non-virtio devices 9b82cabb3b s390-bios: decouple common boot logic from virtio 2e4c88a8ae s390-bios: decouple cio setup from virtio 648c3648c7 s390 vfio-ccw: Add bootindex property and IPLB data === OUTPUT BEGIN === 1/16 Checking commit 648c3648c73b (s390 vfio-ccw: Add bootindex property and IPLB data) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #205: new file mode 100644 total: 0 errors, 1 warnings, 181 lines checked Patch 1/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/16 Checking commit 2e4c88a8ae84 (s390-bios: decouple cio setup from virtio) 3/16 Checking commit 9b82cabb3b40 (s390-bios: decouple common boot logic from virtio) ERROR: externs should be avoided in .c files #31: FILE: pc-bios/s390-ccw/main.c:19: +IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE))); total: 1 errors, 0 warnings, 65 lines checked Patch 3/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/16 Checking commit a99947c33d4a (s390-bios: Extend find_dev() for non-virtio devices) 5/16 Checking commit 06ea71469510 (s390-bios: Factor finding boot device out of virtio code path) 6/16 Checking commit 4ac96c2c105e (s390-bios: Clean up cio.h) 7/16 Checking commit 281f64b37a69 (s390-bios: Decouple channel i/o logic from virtio) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 122 lines checked Patch 7/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/16 Checking commit af222f561810 (s390-bios: Map low core memory) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #35: new file mode 100644 total: 0 errors, 1 warnings, 116 lines checked Patch 8/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/16 Checking commit 7244df5a79fa (s390-bios: ptr2u32 and u32toptr) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #16: new file mode 100644 total: 0 errors, 1 warnings, 16 lines checked Patch 9/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/16 Checking commit 44d52598706f (s390-bios: Support for running format-0/1 channel programs) 11/16 Checking commit 631002c64417 (s390-bios: cio error handling) 12/16 Checking commit 2af24581b441 (s390-bios: Refactor virtio to run channel programs via cio) WARNING: line over 80 characters #103: FILE: pc-bios/s390-ccw/virtio.c:298: + run_ccw(vdev, CCW_CMD_READ_VQ_CONF, &config, sizeof(config), false) == 0, WARNING: line over 80 characters #116: FILE: pc-bios/s390-ccw/virtio.c:308: + run_ccw(vdev, CCW_CMD_WRITE_STATUS, &status, sizeof(status), false) == 0, total: 0 errors, 2 warnings, 107 lines checked Patch 12/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/16 Checking commit d23ff47a3d3c (s390-bios: Use control unit type to determine boot method) 14/16 Checking commit 5a5c4b01efbc (s390-bios: Add channel command codes/structs needed for dasd-ipl) 15/16 Checking commit 8733330492f4 (s390-bios: Support booting from real dasd device) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #25: new file mode 100644 total: 0 errors, 1 warnings, 446 lines checked Patch 15/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/16 Checking commit 73739b0cc6e1 (s390-bios: dasd-ipl: Use control unit type to customize error data) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1551466776-29123-1-git-send-email-jjherne@linux.ibm.com Subject: [Qemu-devel] [PATCH v3 00/16] s390: vfio-ccw dasd ipl support === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com -> patchew/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com Switched to a new branch 'test' 30a1fa38c4 s390-bios: dasd-ipl: Use control unit type to customize error data 2989c319fd s390-bios: Support booting from real dasd device b2085c405e s390-bios: Add channel command codes/structs needed for dasd-ipl f322225324 s390-bios: Use control unit type to determine boot method c6f03bc84f s390-bios: Refactor virtio to run channel programs via cio 65864585c0 s390-bios: cio error handling 097bccecd0 s390-bios: Support for running format-0/1 channel programs c8b8481de0 s390-bios: ptr2u32 and u32toptr 2b710b5d43 s390-bios: Map low core memory 16d1882b5f s390-bios: Decouple channel i/o logic from virtio 7a28a2573e s390-bios: Clean up cio.h b18ab082b0 s390-bios: Factor finding boot device out of virtio code path 67e5e992d6 s390-bios: Extend find_dev() for non-virtio devices 5f215da4ce s390-bios: decouple common boot logic from virtio b76737ee14 s390-bios: decouple cio setup from virtio e2d6b7499a s390 vfio-ccw: Add bootindex property and IPLB data === OUTPUT BEGIN === 1/16 Checking commit e2d6b7499af4 (s390 vfio-ccw: Add bootindex property and IPLB data) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #205: new file mode 100644 total: 0 errors, 1 warnings, 181 lines checked Patch 1/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/16 Checking commit b76737ee14b7 (s390-bios: decouple cio setup from virtio) 3/16 Checking commit 5f215da4ce76 (s390-bios: decouple common boot logic from virtio) ERROR: externs should be avoided in .c files #31: FILE: pc-bios/s390-ccw/main.c:19: +IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE))); total: 1 errors, 0 warnings, 65 lines checked Patch 3/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/16 Checking commit 67e5e992d625 (s390-bios: Extend find_dev() for non-virtio devices) 5/16 Checking commit b18ab082b084 (s390-bios: Factor finding boot device out of virtio code path) 6/16 Checking commit 7a28a2573eba (s390-bios: Clean up cio.h) 7/16 Checking commit 16d1882b5f7d (s390-bios: Decouple channel i/o logic from virtio) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 122 lines checked Patch 7/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/16 Checking commit 2b710b5d436c (s390-bios: Map low core memory) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #35: new file mode 100644 total: 0 errors, 1 warnings, 116 lines checked Patch 8/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/16 Checking commit c8b8481de0ac (s390-bios: ptr2u32 and u32toptr) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #16: new file mode 100644 total: 0 errors, 1 warnings, 16 lines checked Patch 9/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/16 Checking commit 097bccecd0e1 (s390-bios: Support for running format-0/1 channel programs) 11/16 Checking commit 65864585c097 (s390-bios: cio error handling) 12/16 Checking commit c6f03bc84fcb (s390-bios: Refactor virtio to run channel programs via cio) WARNING: line over 80 characters #103: FILE: pc-bios/s390-ccw/virtio.c:298: + run_ccw(vdev, CCW_CMD_READ_VQ_CONF, &config, sizeof(config), false) == 0, WARNING: line over 80 characters #116: FILE: pc-bios/s390-ccw/virtio.c:308: + run_ccw(vdev, CCW_CMD_WRITE_STATUS, &status, sizeof(status), false) == 0, total: 0 errors, 2 warnings, 107 lines checked Patch 12/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/16 Checking commit f32222532490 (s390-bios: Use control unit type to determine boot method) 14/16 Checking commit b2085c405e83 (s390-bios: Add channel command codes/structs needed for dasd-ipl) 15/16 Checking commit 2989c319fd28 (s390-bios: Support booting from real dasd device) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #25: new file mode 100644 total: 0 errors, 1 warnings, 446 lines checked Patch 15/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/16 Checking commit 30a1fa38c42e (s390-bios: dasd-ipl: Use control unit type to customize error data) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1551466776-29123-1-git-send-email-jjherne@linux.ibm.com Subject: [Qemu-devel] [PATCH v3 00/16] s390: vfio-ccw dasd ipl support === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 2b789b1c10 s390-bios: dasd-ipl: Use control unit type to customize error data f91457aeef s390-bios: Support booting from real dasd device 3071ef3fd7 s390-bios: Add channel command codes/structs needed for dasd-ipl bd9ebd495d s390-bios: Use control unit type to determine boot method 72c5351cf3 s390-bios: Refactor virtio to run channel programs via cio 48463c91d1 s390-bios: cio error handling 5a6410ee3c s390-bios: Support for running format-0/1 channel programs 87b21a627b s390-bios: ptr2u32 and u32toptr 6b4c168d0b s390-bios: Map low core memory 1579052645 s390-bios: Decouple channel i/o logic from virtio 6ed6d43be1 s390-bios: Clean up cio.h 49cafd73b0 s390-bios: Factor finding boot device out of virtio code path 9bcc2ca566 s390-bios: Extend find_dev() for non-virtio devices 9baff8187e s390-bios: decouple common boot logic from virtio 8ea363fa83 s390-bios: decouple cio setup from virtio 8ddaab89e7 s390 vfio-ccw: Add bootindex property and IPLB data === OUTPUT BEGIN === 1/16 Checking commit 8ddaab89e767 (s390 vfio-ccw: Add bootindex property and IPLB data) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #205: new file mode 100644 total: 0 errors, 1 warnings, 181 lines checked Patch 1/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/16 Checking commit 8ea363fa8353 (s390-bios: decouple cio setup from virtio) 3/16 Checking commit 9baff8187ec5 (s390-bios: decouple common boot logic from virtio) ERROR: externs should be avoided in .c files #31: FILE: pc-bios/s390-ccw/main.c:19: +IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE))); total: 1 errors, 0 warnings, 65 lines checked Patch 3/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/16 Checking commit 9bcc2ca566bc (s390-bios: Extend find_dev() for non-virtio devices) 5/16 Checking commit 49cafd73b044 (s390-bios: Factor finding boot device out of virtio code path) 6/16 Checking commit 6ed6d43be161 (s390-bios: Clean up cio.h) 7/16 Checking commit 1579052645a0 (s390-bios: Decouple channel i/o logic from virtio) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 122 lines checked Patch 7/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/16 Checking commit 6b4c168d0bba (s390-bios: Map low core memory) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #35: new file mode 100644 total: 0 errors, 1 warnings, 116 lines checked Patch 8/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/16 Checking commit 87b21a627bda (s390-bios: ptr2u32 and u32toptr) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #16: new file mode 100644 total: 0 errors, 1 warnings, 16 lines checked Patch 9/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/16 Checking commit 5a6410ee3ce0 (s390-bios: Support for running format-0/1 channel programs) 11/16 Checking commit 48463c91d1ab (s390-bios: cio error handling) 12/16 Checking commit 72c5351cf34d (s390-bios: Refactor virtio to run channel programs via cio) WARNING: line over 80 characters #103: FILE: pc-bios/s390-ccw/virtio.c:298: + run_ccw(vdev, CCW_CMD_READ_VQ_CONF, &config, sizeof(config), false) == 0, WARNING: line over 80 characters #116: FILE: pc-bios/s390-ccw/virtio.c:308: + run_ccw(vdev, CCW_CMD_WRITE_STATUS, &status, sizeof(status), false) == 0, total: 0 errors, 2 warnings, 107 lines checked Patch 12/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/16 Checking commit bd9ebd495d0b (s390-bios: Use control unit type to determine boot method) 14/16 Checking commit 3071ef3fd73d (s390-bios: Add channel command codes/structs needed for dasd-ipl) 15/16 Checking commit f91457aeef9b (s390-bios: Support booting from real dasd device) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #25: new file mode 100644 total: 0 errors, 1 warnings, 446 lines checked Patch 15/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/16 Checking commit 2b789b1c108a (s390-bios: dasd-ipl: Use control unit type to customize error data) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1551466776-29123-1-git-send-email-jjherne@linux.ibm.com Subject: [Qemu-devel] [PATCH v3 00/16] s390: vfio-ccw dasd ipl support === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com -> patchew/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com Switched to a new branch 'test' 9b84ebcc24 s390-bios: dasd-ipl: Use control unit type to customize error data c9372490a1 s390-bios: Support booting from real dasd device 47171b2cdd s390-bios: Add channel command codes/structs needed for dasd-ipl 6f2050908e s390-bios: Use control unit type to determine boot method 0f97bb921e s390-bios: Refactor virtio to run channel programs via cio d2c9f6cce7 s390-bios: cio error handling f298cecd8f s390-bios: Support for running format-0/1 channel programs dfdc554721 s390-bios: ptr2u32 and u32toptr 1b096b1bf8 s390-bios: Map low core memory 3be0b00270 s390-bios: Decouple channel i/o logic from virtio e6032c6187 s390-bios: Clean up cio.h 12d9848de1 s390-bios: Factor finding boot device out of virtio code path db71bdf357 s390-bios: Extend find_dev() for non-virtio devices 80c8b669bd s390-bios: decouple common boot logic from virtio cdd504e999 s390-bios: decouple cio setup from virtio bc57bb5989 s390 vfio-ccw: Add bootindex property and IPLB data === OUTPUT BEGIN === 1/16 Checking commit bc57bb598935 (s390 vfio-ccw: Add bootindex property and IPLB data) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #205: new file mode 100644 total: 0 errors, 1 warnings, 181 lines checked Patch 1/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/16 Checking commit cdd504e99929 (s390-bios: decouple cio setup from virtio) 3/16 Checking commit 80c8b669bd0a (s390-bios: decouple common boot logic from virtio) ERROR: externs should be avoided in .c files #31: FILE: pc-bios/s390-ccw/main.c:19: +IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE))); total: 1 errors, 0 warnings, 65 lines checked Patch 3/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/16 Checking commit db71bdf3578b (s390-bios: Extend find_dev() for non-virtio devices) 5/16 Checking commit 12d9848de1f4 (s390-bios: Factor finding boot device out of virtio code path) 6/16 Checking commit e6032c61879f (s390-bios: Clean up cio.h) 7/16 Checking commit 3be0b0027017 (s390-bios: Decouple channel i/o logic from virtio) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #28: new file mode 100644 total: 0 errors, 1 warnings, 122 lines checked Patch 7/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/16 Checking commit 1b096b1bf8e3 (s390-bios: Map low core memory) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #35: new file mode 100644 total: 0 errors, 1 warnings, 116 lines checked Patch 8/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 9/16 Checking commit dfdc55472161 (s390-bios: ptr2u32 and u32toptr) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #16: new file mode 100644 total: 0 errors, 1 warnings, 16 lines checked Patch 9/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 10/16 Checking commit f298cecd8f83 (s390-bios: Support for running format-0/1 channel programs) 11/16 Checking commit d2c9f6cce7ce (s390-bios: cio error handling) 12/16 Checking commit 0f97bb921e27 (s390-bios: Refactor virtio to run channel programs via cio) WARNING: line over 80 characters #103: FILE: pc-bios/s390-ccw/virtio.c:298: + run_ccw(vdev, CCW_CMD_READ_VQ_CONF, &config, sizeof(config), false) == 0, WARNING: line over 80 characters #116: FILE: pc-bios/s390-ccw/virtio.c:308: + run_ccw(vdev, CCW_CMD_WRITE_STATUS, &status, sizeof(status), false) == 0, total: 0 errors, 2 warnings, 107 lines checked Patch 12/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 13/16 Checking commit 6f2050908e93 (s390-bios: Use control unit type to determine boot method) 14/16 Checking commit 47171b2cddcf (s390-bios: Add channel command codes/structs needed for dasd-ipl) 15/16 Checking commit c9372490a158 (s390-bios: Support booting from real dasd device) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #25: new file mode 100644 total: 0 errors, 1 warnings, 446 lines checked Patch 15/16 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 16/16 Checking commit 9b84ebcc2486 (s390-bios: dasd-ipl: Use control unit type to customize error data) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1551466776-29123-1-git-send-email-jjherne@linux.ibm.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
© 2016 - 2024 Red Hat, Inc.