[Qemu-devel] [PATCH v2 0/9] vhost: enable for all targets

Paolo Bonzini posted 9 patches 5 years, 2 months ago
Test asan passed
Test docker-mingw@fedora passed
Test docker-clang@ubuntu failed
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1550165756-21617-1-git-send-email-pbonzini@redhat.com
backends/Makefile.objs     |   5 +-
configure                  | 102 ++++++++++++++++++-----------
default-configs/virtio.mak |   4 +-
hw/net/Makefile.objs       |   4 +-
hw/net/vhost_net-stub.c    |  92 ++++++++++++++++++++++++++
hw/net/vhost_net.c         |  85 ++----------------------
hw/virtio/Makefile.objs    |   8 ++-
hw/virtio/vhost-backend.c  |  12 +++-
hw/virtio/vhost-user.c     |  13 +++-
hw/virtio/vhost.c          |   2 +-
include/exec/poison.h      |   1 -
net/Makefile.objs          |   4 +-
net/net.c                  |   2 +-
net/vhost-user-stub.c      |  23 +++++++
net/vhost-user.c           |  13 ++++
tests/Makefile.include     |   5 +-
tests/vhost-user-test.c    | 160 +++++++++++++++++++++++----------------------
17 files changed, 319 insertions(+), 216 deletions(-)
create mode 100644 hw/net/vhost_net-stub.c
create mode 100644 net/vhost-user-stub.c
[Qemu-devel] [PATCH v2 0/9] vhost: enable for all targets
Posted by Paolo Bonzini 5 years, 2 months ago
See also "[PATCH for-3.2 00/10] vhost: preparation for qgraph
conversion of vhost-user-test".  Some of the other vhost-user-test
patches have gone in already, and this is what is left.

These patches are a prerequisite for both kconfig and qgraph.

I will probably test them on macOS myself before these are included
in a pull request, since the previous versions had some issues.
Michael, let me know if you want me to send the pull request.

Thanks,

Paolo

Paolo Bonzini (9):
  vhost-net: move stubs to a separate file
  vhost-net-user: add stubs for when no virtio-net device is present
  vhost: restrict Linux dependency to kernel vhost
  vhost-user: support cross-endian vnet headers
  vhost-net: compile it on all targets that have virtio-net.
  vhost-net: revamp configure logic
  vhost-user-test: create a main loop per TestServer
  vhost-user-test: small changes to init_hugepagefs
  vhost-user-test: create a temporary directory per TestServer

 backends/Makefile.objs     |   5 +-
 configure                  | 102 ++++++++++++++++++-----------
 default-configs/virtio.mak |   4 +-
 hw/net/Makefile.objs       |   4 +-
 hw/net/vhost_net-stub.c    |  92 ++++++++++++++++++++++++++
 hw/net/vhost_net.c         |  85 ++----------------------
 hw/virtio/Makefile.objs    |   8 ++-
 hw/virtio/vhost-backend.c  |  12 +++-
 hw/virtio/vhost-user.c     |  13 +++-
 hw/virtio/vhost.c          |   2 +-
 include/exec/poison.h      |   1 -
 net/Makefile.objs          |   4 +-
 net/net.c                  |   2 +-
 net/vhost-user-stub.c      |  23 +++++++
 net/vhost-user.c           |  13 ++++
 tests/Makefile.include     |   5 +-
 tests/vhost-user-test.c    | 160 +++++++++++++++++++++++----------------------
 17 files changed, 319 insertions(+), 216 deletions(-)
 create mode 100644 hw/net/vhost_net-stub.c
 create mode 100644 net/vhost-user-stub.c

-- 
1.8.3.1


Re: [Qemu-devel] [PATCH v2 0/9] vhost: enable for all targets
Posted by Michael S. Tsirkin 5 years, 2 months ago
On Thu, Feb 14, 2019 at 06:35:47PM +0100, Paolo Bonzini wrote:
> See also "[PATCH for-3.2 00/10] vhost: preparation for qgraph
> conversion of vhost-user-test".  Some of the other vhost-user-test
> patches have gone in already, and this is what is left.
> 
> These patches are a prerequisite for both kconfig and qgraph.
> 
> I will probably test them on macOS myself before these are included
> in a pull request, since the previous versions had some issues.
> Michael, let me know if you want me to send the pull request.
> 
> Thanks,
> 
> Paolo

Not sure why, it's all vhost so my tree seems appropriate.
BTW for the future, can you please try fixing the subject so all patches
have "v2"? I think it's generated by some tool you use,
and it seems that others are using it as well with the
same result. Makes it harder to see which patch belongs where.


> Paolo Bonzini (9):
>   vhost-net: move stubs to a separate file
>   vhost-net-user: add stubs for when no virtio-net device is present
>   vhost: restrict Linux dependency to kernel vhost
>   vhost-user: support cross-endian vnet headers
>   vhost-net: compile it on all targets that have virtio-net.
>   vhost-net: revamp configure logic
>   vhost-user-test: create a main loop per TestServer
>   vhost-user-test: small changes to init_hugepagefs
>   vhost-user-test: create a temporary directory per TestServer
> 
>  backends/Makefile.objs     |   5 +-
>  configure                  | 102 ++++++++++++++++++-----------
>  default-configs/virtio.mak |   4 +-
>  hw/net/Makefile.objs       |   4 +-
>  hw/net/vhost_net-stub.c    |  92 ++++++++++++++++++++++++++
>  hw/net/vhost_net.c         |  85 ++----------------------
>  hw/virtio/Makefile.objs    |   8 ++-
>  hw/virtio/vhost-backend.c  |  12 +++-
>  hw/virtio/vhost-user.c     |  13 +++-
>  hw/virtio/vhost.c          |   2 +-
>  include/exec/poison.h      |   1 -
>  net/Makefile.objs          |   4 +-
>  net/net.c                  |   2 +-
>  net/vhost-user-stub.c      |  23 +++++++
>  net/vhost-user.c           |  13 ++++
>  tests/Makefile.include     |   5 +-
>  tests/vhost-user-test.c    | 160 +++++++++++++++++++++++----------------------
>  17 files changed, 319 insertions(+), 216 deletions(-)
>  create mode 100644 hw/net/vhost_net-stub.c
>  create mode 100644 net/vhost-user-stub.c
> 
> -- 
> 1.8.3.1

Re: [Qemu-devel] [PATCH v2 0/9] vhost: enable for all targets
Posted by Michael S. Tsirkin 5 years, 2 months ago
On Thu, Feb 14, 2019 at 06:35:47PM +0100, Paolo Bonzini wrote:
> See also "[PATCH for-3.2 00/10] vhost: preparation for qgraph
> conversion of vhost-user-test".  Some of the other vhost-user-test
> patches have gone in already, and this is what is left.
> 
> These patches are a prerequisite for both kconfig and qgraph.
> 
> I will probably test them on macOS myself before these are included
> in a pull request, since the previous versions had some issues.
> Michael, let me know if you want me to send the pull request.
> 
> Thanks,
> 
> Paolo

what's the changelog from v1?

> Paolo Bonzini (9):
>   vhost-net: move stubs to a separate file
>   vhost-net-user: add stubs for when no virtio-net device is present
>   vhost: restrict Linux dependency to kernel vhost
>   vhost-user: support cross-endian vnet headers
>   vhost-net: compile it on all targets that have virtio-net.
>   vhost-net: revamp configure logic
>   vhost-user-test: create a main loop per TestServer
>   vhost-user-test: small changes to init_hugepagefs
>   vhost-user-test: create a temporary directory per TestServer
> 
>  backends/Makefile.objs     |   5 +-
>  configure                  | 102 ++++++++++++++++++-----------
>  default-configs/virtio.mak |   4 +-
>  hw/net/Makefile.objs       |   4 +-
>  hw/net/vhost_net-stub.c    |  92 ++++++++++++++++++++++++++
>  hw/net/vhost_net.c         |  85 ++----------------------
>  hw/virtio/Makefile.objs    |   8 ++-
>  hw/virtio/vhost-backend.c  |  12 +++-
>  hw/virtio/vhost-user.c     |  13 +++-
>  hw/virtio/vhost.c          |   2 +-
>  include/exec/poison.h      |   1 -
>  net/Makefile.objs          |   4 +-
>  net/net.c                  |   2 +-
>  net/vhost-user-stub.c      |  23 +++++++
>  net/vhost-user.c           |  13 ++++
>  tests/Makefile.include     |   5 +-
>  tests/vhost-user-test.c    | 160 +++++++++++++++++++++++----------------------
>  17 files changed, 319 insertions(+), 216 deletions(-)
>  create mode 100644 hw/net/vhost_net-stub.c
>  create mode 100644 net/vhost-user-stub.c
> 
> -- 
> 1.8.3.1

Re: [Qemu-devel] [PATCH v2 0/9] vhost: enable for all targets
Posted by Paolo Bonzini 5 years, 2 months ago
On 14/02/19 20:28, Michael S. Tsirkin wrote:
> On Thu, Feb 14, 2019 at 06:35:47PM +0100, Paolo Bonzini wrote:
>> See also "[PATCH for-3.2 00/10] vhost: preparation for qgraph
>> conversion of vhost-user-test".  Some of the other vhost-user-test
>> patches have gone in already, and this is what is left.
>>
>> These patches are a prerequisite for both kconfig and qgraph.
>>
>> I will probably test them on macOS myself before these are included
>> in a pull request, since the previous versions had some issues.
>> Michael, let me know if you want me to send the pull request.
>>
>> Thanks,
>>
>> Paolo
> 
> what's the changelog from v1?

It's rebased and it includes the not-yet-merged parts of "vhost:
preparation for qgraph conversion of vhost-user-test", but otherwise
there are no changes.

Paolo

> 
>> Paolo Bonzini (9):
>>   vhost-net: move stubs to a separate file
>>   vhost-net-user: add stubs for when no virtio-net device is present
>>   vhost: restrict Linux dependency to kernel vhost
>>   vhost-user: support cross-endian vnet headers
>>   vhost-net: compile it on all targets that have virtio-net.
>>   vhost-net: revamp configure logic
>>   vhost-user-test: create a main loop per TestServer
>>   vhost-user-test: small changes to init_hugepagefs
>>   vhost-user-test: create a temporary directory per TestServer
>>
>>  backends/Makefile.objs     |   5 +-
>>  configure                  | 102 ++++++++++++++++++-----------
>>  default-configs/virtio.mak |   4 +-
>>  hw/net/Makefile.objs       |   4 +-
>>  hw/net/vhost_net-stub.c    |  92 ++++++++++++++++++++++++++
>>  hw/net/vhost_net.c         |  85 ++----------------------
>>  hw/virtio/Makefile.objs    |   8 ++-
>>  hw/virtio/vhost-backend.c  |  12 +++-
>>  hw/virtio/vhost-user.c     |  13 +++-
>>  hw/virtio/vhost.c          |   2 +-
>>  include/exec/poison.h      |   1 -
>>  net/Makefile.objs          |   4 +-
>>  net/net.c                  |   2 +-
>>  net/vhost-user-stub.c      |  23 +++++++
>>  net/vhost-user.c           |  13 ++++
>>  tests/Makefile.include     |   5 +-
>>  tests/vhost-user-test.c    | 160 +++++++++++++++++++++++----------------------
>>  17 files changed, 319 insertions(+), 216 deletions(-)
>>  create mode 100644 hw/net/vhost_net-stub.c
>>  create mode 100644 net/vhost-user-stub.c
>>
>> -- 
>> 1.8.3.1


Re: [Qemu-devel] [PATCH v2 0/9] vhost: enable for all targets
Posted by Michael S. Tsirkin 5 years, 2 months ago
On Thu, Feb 14, 2019 at 09:37:42PM +0100, Paolo Bonzini wrote:
> On 14/02/19 20:28, Michael S. Tsirkin wrote:
> > On Thu, Feb 14, 2019 at 06:35:47PM +0100, Paolo Bonzini wrote:
> >> See also "[PATCH for-3.2 00/10] vhost: preparation for qgraph
> >> conversion of vhost-user-test".  Some of the other vhost-user-test
> >> patches have gone in already, and this is what is left.
> >>
> >> These patches are a prerequisite for both kconfig and qgraph.
> >>
> >> I will probably test them on macOS myself before these are included
> >> in a pull request, since the previous versions had some issues.
> >> Michael, let me know if you want me to send the pull request.
> >>
> >> Thanks,
> >>
> >> Paolo
> > 
> > what's the changelog from v1?
> 
> It's rebased and it includes the not-yet-merged parts of "vhost:
> preparation for qgraph conversion of vhost-user-test", but otherwise
> there are no changes.
> 
> Paolo

Peter could you help out by trying my pci branch on
non-linux now? Did runtime failures get fixed?

Would be vry much appreciated.

Thanks a lot!


> > 
> >> Paolo Bonzini (9):
> >>   vhost-net: move stubs to a separate file
> >>   vhost-net-user: add stubs for when no virtio-net device is present
> >>   vhost: restrict Linux dependency to kernel vhost
> >>   vhost-user: support cross-endian vnet headers
> >>   vhost-net: compile it on all targets that have virtio-net.
> >>   vhost-net: revamp configure logic
> >>   vhost-user-test: create a main loop per TestServer
> >>   vhost-user-test: small changes to init_hugepagefs
> >>   vhost-user-test: create a temporary directory per TestServer
> >>
> >>  backends/Makefile.objs     |   5 +-
> >>  configure                  | 102 ++++++++++++++++++-----------
> >>  default-configs/virtio.mak |   4 +-
> >>  hw/net/Makefile.objs       |   4 +-
> >>  hw/net/vhost_net-stub.c    |  92 ++++++++++++++++++++++++++
> >>  hw/net/vhost_net.c         |  85 ++----------------------
> >>  hw/virtio/Makefile.objs    |   8 ++-
> >>  hw/virtio/vhost-backend.c  |  12 +++-
> >>  hw/virtio/vhost-user.c     |  13 +++-
> >>  hw/virtio/vhost.c          |   2 +-
> >>  include/exec/poison.h      |   1 -
> >>  net/Makefile.objs          |   4 +-
> >>  net/net.c                  |   2 +-
> >>  net/vhost-user-stub.c      |  23 +++++++
> >>  net/vhost-user.c           |  13 ++++
> >>  tests/Makefile.include     |   5 +-
> >>  tests/vhost-user-test.c    | 160 +++++++++++++++++++++++----------------------
> >>  17 files changed, 319 insertions(+), 216 deletions(-)
> >>  create mode 100644 hw/net/vhost_net-stub.c
> >>  create mode 100644 net/vhost-user-stub.c
> >>
> >> -- 
> >> 1.8.3.1