[Qemu-devel] [PATCH] target/openrisc: Fix LGPL information in the file headers

Thomas Huth posted 1 patch 6 years, 11 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1550073577-4248-1-git-send-email-thuth@redhat.com
Test docker-mingw@fedora passed
Test asan passed
Test checkpatch passed
Test docker-clang@ubuntu passed
Maintainers: Jia Liu <proljc@gmail.com>, Stafford Horne <shorne@gmail.com>, Laurent Vivier <laurent@vivier.eu>, Riku Voipio <riku.voipio@iki.fi>
hw/openrisc/cputimer.c               | 2 +-
hw/openrisc/openrisc_sim.c           | 2 +-
hw/openrisc/pic_cpu.c                | 2 +-
linux-user/openrisc/target_cpu.h     | 2 +-
linux-user/openrisc/target_structs.h | 2 +-
target/openrisc/cpu.h                | 2 +-
target/openrisc/exception.c          | 2 +-
target/openrisc/exception_helper.c   | 2 +-
target/openrisc/fpu_helper.c         | 2 +-
target/openrisc/insns.decode         | 2 +-
target/openrisc/interrupt.c          | 2 +-
target/openrisc/machine.c            | 2 +-
target/openrisc/mmu.c                | 2 +-
13 files changed, 13 insertions(+), 13 deletions(-)
[Qemu-devel] [PATCH] target/openrisc: Fix LGPL information in the file headers
Posted by Thomas Huth 6 years, 11 months ago
It's either "GNU *Library* General Public License version 2" or "GNU
Lesser General Public License version *2.1*", but there was no "version
2.0" of the "Lesser" license. So assume that version 2.1 is meant here.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 hw/openrisc/cputimer.c               | 2 +-
 hw/openrisc/openrisc_sim.c           | 2 +-
 hw/openrisc/pic_cpu.c                | 2 +-
 linux-user/openrisc/target_cpu.h     | 2 +-
 linux-user/openrisc/target_structs.h | 2 +-
 target/openrisc/cpu.h                | 2 +-
 target/openrisc/exception.c          | 2 +-
 target/openrisc/exception_helper.c   | 2 +-
 target/openrisc/fpu_helper.c         | 2 +-
 target/openrisc/insns.decode         | 2 +-
 target/openrisc/interrupt.c          | 2 +-
 target/openrisc/machine.c            | 2 +-
 target/openrisc/mmu.c                | 2 +-
 13 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/hw/openrisc/cputimer.c b/hw/openrisc/cputimer.c
index 850f887..fe95efc 100644
--- a/hw/openrisc/cputimer.c
+++ b/hw/openrisc/cputimer.c
@@ -7,7 +7,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
diff --git a/hw/openrisc/openrisc_sim.c b/hw/openrisc/openrisc_sim.c
index 7d3b734..0a906d8 100644
--- a/hw/openrisc/openrisc_sim.c
+++ b/hw/openrisc/openrisc_sim.c
@@ -7,7 +7,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
diff --git a/hw/openrisc/pic_cpu.c b/hw/openrisc/pic_cpu.c
index 569b443..2f53cfc 100644
--- a/hw/openrisc/pic_cpu.c
+++ b/hw/openrisc/pic_cpu.c
@@ -7,7 +7,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
diff --git a/linux-user/openrisc/target_cpu.h b/linux-user/openrisc/target_cpu.h
index d1ea450..32ff135 100644
--- a/linux-user/openrisc/target_cpu.h
+++ b/linux-user/openrisc/target_cpu.h
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
diff --git a/linux-user/openrisc/target_structs.h b/linux-user/openrisc/target_structs.h
index afbb7ad..e98e2bc 100644
--- a/linux-user/openrisc/target_structs.h
+++ b/linux-user/openrisc/target_structs.h
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
diff --git a/target/openrisc/cpu.h b/target/openrisc/cpu.h
index f1b31bc..c104a4b 100644
--- a/target/openrisc/cpu.h
+++ b/target/openrisc/cpu.h
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
diff --git a/target/openrisc/exception.c b/target/openrisc/exception.c
index 49470be..28c1fce 100644
--- a/target/openrisc/exception.c
+++ b/target/openrisc/exception.c
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
diff --git a/target/openrisc/exception_helper.c b/target/openrisc/exception_helper.c
index 6073a5b..0797cc9 100644
--- a/target/openrisc/exception_helper.c
+++ b/target/openrisc/exception_helper.c
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
diff --git a/target/openrisc/fpu_helper.c b/target/openrisc/fpu_helper.c
index 265ce13..b9d2ebb 100644
--- a/target/openrisc/fpu_helper.c
+++ b/target/openrisc/fpu_helper.c
@@ -7,7 +7,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
diff --git a/target/openrisc/insns.decode b/target/openrisc/insns.decode
index dad68c8..7df81c1 100644
--- a/target/openrisc/insns.decode
+++ b/target/openrisc/insns.decode
@@ -6,7 +6,7 @@
 # This library is free software; you can redistribute it and/or
 # modify it under the terms of the GNU Lesser General Public
 # License as published by the Free Software Foundation; either
-# version 2 of the License, or (at your option) any later version.
+# version 2.1 of the License, or (at your option) any later version.
 #
 # This library is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
diff --git a/target/openrisc/interrupt.c b/target/openrisc/interrupt.c
index bbae956..ee280df 100644
--- a/target/openrisc/interrupt.c
+++ b/target/openrisc/interrupt.c
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
diff --git a/target/openrisc/machine.c b/target/openrisc/machine.c
index 5d822f7..c9e0848 100644
--- a/target/openrisc/machine.c
+++ b/target/openrisc/machine.c
@@ -6,7 +6,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
diff --git a/target/openrisc/mmu.c b/target/openrisc/mmu.c
index e7d5219..5dec68d 100644
--- a/target/openrisc/mmu.c
+++ b/target/openrisc/mmu.c
@@ -7,7 +7,7 @@
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
  * License as published by the Free Software Foundation; either
- * version 2 of the License, or (at your option) any later version.
+ * version 2.1 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
-- 
1.8.3.1


Re: [Qemu-devel] [PATCH] target/openrisc: Fix LGPL information in the file headers
Posted by Thomas Huth 6 years, 9 months ago
On 13/02/2019 16.59, Thomas Huth wrote:
> It's either "GNU *Library* General Public License version 2" or "GNU
> Lesser General Public License version *2.1*", but there was no "version
> 2.0" of the "Lesser" license. So assume that version 2.1 is meant here.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  hw/openrisc/cputimer.c               | 2 +-
>  hw/openrisc/openrisc_sim.c           | 2 +-
>  hw/openrisc/pic_cpu.c                | 2 +-
>  linux-user/openrisc/target_cpu.h     | 2 +-
>  linux-user/openrisc/target_structs.h | 2 +-
>  target/openrisc/cpu.h                | 2 +-
>  target/openrisc/exception.c          | 2 +-
>  target/openrisc/exception_helper.c   | 2 +-
>  target/openrisc/fpu_helper.c         | 2 +-
>  target/openrisc/insns.decode         | 2 +-
>  target/openrisc/interrupt.c          | 2 +-
>  target/openrisc/machine.c            | 2 +-
>  target/openrisc/mmu.c                | 2 +-
>  13 files changed, 13 insertions(+), 13 deletions(-)
> 
> diff --git a/hw/openrisc/cputimer.c b/hw/openrisc/cputimer.c
> index 850f887..fe95efc 100644
> --- a/hw/openrisc/cputimer.c
> +++ b/hw/openrisc/cputimer.c
> @@ -7,7 +7,7 @@
>   * This library is free software; you can redistribute it and/or
>   * modify it under the terms of the GNU Lesser General Public
>   * License as published by the Free Software Foundation; either
> - * version 2 of the License, or (at your option) any later version.
> + * version 2.1 of the License, or (at your option) any later version.
>   *
>   * This library is distributed in the hope that it will be useful,
>   * but WITHOUT ANY WARRANTY; without even the implied warranty of
> diff --git a/hw/openrisc/openrisc_sim.c b/hw/openrisc/openrisc_sim.c
> index 7d3b734..0a906d8 100644
> --- a/hw/openrisc/openrisc_sim.c
> +++ b/hw/openrisc/openrisc_sim.c
> @@ -7,7 +7,7 @@
>   * This library is free software; you can redistribute it and/or
>   * modify it under the terms of the GNU Lesser General Public
>   * License as published by the Free Software Foundation; either
> - * version 2 of the License, or (at your option) any later version.
> + * version 2.1 of the License, or (at your option) any later version.
>   *
>   * This library is distributed in the hope that it will be useful,
>   * but WITHOUT ANY WARRANTY; without even the implied warranty of
> diff --git a/hw/openrisc/pic_cpu.c b/hw/openrisc/pic_cpu.c
> index 569b443..2f53cfc 100644
> --- a/hw/openrisc/pic_cpu.c
> +++ b/hw/openrisc/pic_cpu.c
> @@ -7,7 +7,7 @@
>   * This library is free software; you can redistribute it and/or
>   * modify it under the terms of the GNU Lesser General Public
>   * License as published by the Free Software Foundation; either
> - * version 2 of the License, or (at your option) any later version.
> + * version 2.1 of the License, or (at your option) any later version.
>   *
>   * This library is distributed in the hope that it will be useful,
>   * but WITHOUT ANY WARRANTY; without even the implied warranty of
> diff --git a/linux-user/openrisc/target_cpu.h b/linux-user/openrisc/target_cpu.h
> index d1ea450..32ff135 100644
> --- a/linux-user/openrisc/target_cpu.h
> +++ b/linux-user/openrisc/target_cpu.h
> @@ -6,7 +6,7 @@
>   * This library is free software; you can redistribute it and/or
>   * modify it under the terms of the GNU Lesser General Public
>   * License as published by the Free Software Foundation; either
> - * version 2 of the License, or (at your option) any later version.
> + * version 2.1 of the License, or (at your option) any later version.
>   *
>   * This library is distributed in the hope that it will be useful,
>   * but WITHOUT ANY WARRANTY; without even the implied warranty of
> diff --git a/linux-user/openrisc/target_structs.h b/linux-user/openrisc/target_structs.h
> index afbb7ad..e98e2bc 100644
> --- a/linux-user/openrisc/target_structs.h
> +++ b/linux-user/openrisc/target_structs.h
> @@ -6,7 +6,7 @@
>   * This library is free software; you can redistribute it and/or
>   * modify it under the terms of the GNU Lesser General Public
>   * License as published by the Free Software Foundation; either
> - * version 2 of the License, or (at your option) any later version.
> + * version 2.1 of the License, or (at your option) any later version.
>   *
>   * This library is distributed in the hope that it will be useful,
>   * but WITHOUT ANY WARRANTY; without even the implied warranty of
> diff --git a/target/openrisc/cpu.h b/target/openrisc/cpu.h
> index f1b31bc..c104a4b 100644
> --- a/target/openrisc/cpu.h
> +++ b/target/openrisc/cpu.h
> @@ -6,7 +6,7 @@
>   * This library is free software; you can redistribute it and/or
>   * modify it under the terms of the GNU Lesser General Public
>   * License as published by the Free Software Foundation; either
> - * version 2 of the License, or (at your option) any later version.
> + * version 2.1 of the License, or (at your option) any later version.
>   *
>   * This library is distributed in the hope that it will be useful,
>   * but WITHOUT ANY WARRANTY; without even the implied warranty of
> diff --git a/target/openrisc/exception.c b/target/openrisc/exception.c
> index 49470be..28c1fce 100644
> --- a/target/openrisc/exception.c
> +++ b/target/openrisc/exception.c
> @@ -6,7 +6,7 @@
>   * This library is free software; you can redistribute it and/or
>   * modify it under the terms of the GNU Lesser General Public
>   * License as published by the Free Software Foundation; either
> - * version 2 of the License, or (at your option) any later version.
> + * version 2.1 of the License, or (at your option) any later version.
>   *
>   * This library is distributed in the hope that it will be useful,
>   * but WITHOUT ANY WARRANTY; without even the implied warranty of
> diff --git a/target/openrisc/exception_helper.c b/target/openrisc/exception_helper.c
> index 6073a5b..0797cc9 100644
> --- a/target/openrisc/exception_helper.c
> +++ b/target/openrisc/exception_helper.c
> @@ -6,7 +6,7 @@
>   * This library is free software; you can redistribute it and/or
>   * modify it under the terms of the GNU Lesser General Public
>   * License as published by the Free Software Foundation; either
> - * version 2 of the License, or (at your option) any later version.
> + * version 2.1 of the License, or (at your option) any later version.
>   *
>   * This library is distributed in the hope that it will be useful,
>   * but WITHOUT ANY WARRANTY; without even the implied warranty of
> diff --git a/target/openrisc/fpu_helper.c b/target/openrisc/fpu_helper.c
> index 265ce13..b9d2ebb 100644
> --- a/target/openrisc/fpu_helper.c
> +++ b/target/openrisc/fpu_helper.c
> @@ -7,7 +7,7 @@
>   * This library is free software; you can redistribute it and/or
>   * modify it under the terms of the GNU Lesser General Public
>   * License as published by the Free Software Foundation; either
> - * version 2 of the License, or (at your option) any later version.
> + * version 2.1 of the License, or (at your option) any later version.
>   *
>   * This library is distributed in the hope that it will be useful,
>   * but WITHOUT ANY WARRANTY; without even the implied warranty of
> diff --git a/target/openrisc/insns.decode b/target/openrisc/insns.decode
> index dad68c8..7df81c1 100644
> --- a/target/openrisc/insns.decode
> +++ b/target/openrisc/insns.decode
> @@ -6,7 +6,7 @@
>  # This library is free software; you can redistribute it and/or
>  # modify it under the terms of the GNU Lesser General Public
>  # License as published by the Free Software Foundation; either
> -# version 2 of the License, or (at your option) any later version.
> +# version 2.1 of the License, or (at your option) any later version.
>  #
>  # This library is distributed in the hope that it will be useful,
>  # but WITHOUT ANY WARRANTY; without even the implied warranty of
> diff --git a/target/openrisc/interrupt.c b/target/openrisc/interrupt.c
> index bbae956..ee280df 100644
> --- a/target/openrisc/interrupt.c
> +++ b/target/openrisc/interrupt.c
> @@ -6,7 +6,7 @@
>   * This library is free software; you can redistribute it and/or
>   * modify it under the terms of the GNU Lesser General Public
>   * License as published by the Free Software Foundation; either
> - * version 2 of the License, or (at your option) any later version.
> + * version 2.1 of the License, or (at your option) any later version.
>   *
>   * This library is distributed in the hope that it will be useful,
>   * but WITHOUT ANY WARRANTY; without even the implied warranty of
> diff --git a/target/openrisc/machine.c b/target/openrisc/machine.c
> index 5d822f7..c9e0848 100644
> --- a/target/openrisc/machine.c
> +++ b/target/openrisc/machine.c
> @@ -6,7 +6,7 @@
>   * This library is free software; you can redistribute it and/or
>   * modify it under the terms of the GNU Lesser General Public
>   * License as published by the Free Software Foundation; either
> - * version 2 of the License, or (at your option) any later version.
> + * version 2.1 of the License, or (at your option) any later version.
>   *
>   * This library is distributed in the hope that it will be useful,
>   * but WITHOUT ANY WARRANTY; without even the implied warranty of
> diff --git a/target/openrisc/mmu.c b/target/openrisc/mmu.c
> index e7d5219..5dec68d 100644
> --- a/target/openrisc/mmu.c
> +++ b/target/openrisc/mmu.c
> @@ -7,7 +7,7 @@
>   * This library is free software; you can redistribute it and/or
>   * modify it under the terms of the GNU Lesser General Public
>   * License as published by the Free Software Foundation; either
> - * version 2 of the License, or (at your option) any later version.
> + * version 2.1 of the License, or (at your option) any later version.
>   *
>   * This library is distributed in the hope that it will be useful,
>   * but WITHOUT ANY WARRANTY; without even the implied warranty of
> 

Ping?

 Thomas

Re: [Qemu-devel] [PATCH] target/openrisc: Fix LGPL information in the file headers
Posted by Stafford Horne 6 years, 9 months ago
Hello,

On Mon, May 06, 2019 at 07:53:45AM +0200, Thomas Huth wrote:
> On 13/02/2019 16.59, Thomas Huth wrote:
> > It's either "GNU *Library* General Public License version 2" or "GNU
> > Lesser General Public License version *2.1*", but there was no "version
> > 2.0" of the "Lesser" license. So assume that version 2.1 is meant here.

Acked-by: Stafford Horne <shorne@gmail.com>

> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> > ---
> >  hw/openrisc/cputimer.c               | 2 +-
> >  hw/openrisc/openrisc_sim.c           | 2 +-
> >  hw/openrisc/pic_cpu.c                | 2 +-
> >  linux-user/openrisc/target_cpu.h     | 2 +-
> >  linux-user/openrisc/target_structs.h | 2 +-
> >  target/openrisc/cpu.h                | 2 +-
> >  target/openrisc/exception.c          | 2 +-
> >  target/openrisc/exception_helper.c   | 2 +-
> >  target/openrisc/fpu_helper.c         | 2 +-
> >  target/openrisc/insns.decode         | 2 +-
> >  target/openrisc/interrupt.c          | 2 +-
> >  target/openrisc/machine.c            | 2 +-
> >  target/openrisc/mmu.c                | 2 +-
> >  13 files changed, 13 insertions(+), 13 deletions(-)
> > 
[...]
> > 
> 
> Ping?

Sorry, I must have missed this.  What is your plan for sending upstream?  I
don't really have anything in my queue right now so if you have another queue
that would be great.  If not let me know and I can queue it.

-Stafford

Re: [Qemu-devel] [PATCH] target/openrisc: Fix LGPL information in the file headers
Posted by Thomas Huth 6 years, 9 months ago
 Hi Stafford,

On 06/05/2019 11.09, Stafford Horne wrote:
> 
> On Mon, May 06, 2019 at 07:53:45AM +0200, Thomas Huth wrote:
>> On 13/02/2019 16.59, Thomas Huth wrote:
>>> It's either "GNU *Library* General Public License version 2" or "GNU
>>> Lesser General Public License version *2.1*", but there was no "version
>>> 2.0" of the "Lesser" license. So assume that version 2.1 is meant here.
> 
> Acked-by: Stafford Horne <shorne@gmail.com>
> 
>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>> ---
>>>  hw/openrisc/cputimer.c               | 2 +-
>>>  hw/openrisc/openrisc_sim.c           | 2 +-
>>>  hw/openrisc/pic_cpu.c                | 2 +-
>>>  linux-user/openrisc/target_cpu.h     | 2 +-
>>>  linux-user/openrisc/target_structs.h | 2 +-
>>>  target/openrisc/cpu.h                | 2 +-
>>>  target/openrisc/exception.c          | 2 +-
>>>  target/openrisc/exception_helper.c   | 2 +-
>>>  target/openrisc/fpu_helper.c         | 2 +-
>>>  target/openrisc/insns.decode         | 2 +-
>>>  target/openrisc/interrupt.c          | 2 +-
>>>  target/openrisc/machine.c            | 2 +-
>>>  target/openrisc/mmu.c                | 2 +-
>>>  13 files changed, 13 insertions(+), 13 deletions(-)
>>>
> [...]
>>>
>>
>> Ping?
> 
> Sorry, I must have missed this.  What is your plan for sending upstream?  I
> don't really have anything in my queue right now so if you have another queue
> that would be great.  If not let me know and I can queue it.

I think this could go via qemu-trivial now that you've provided an
"Acked-by" ... otherwise I can also sneak it in when I send a pull
request the next time.

 Thanks,
  Thomas