docs/multiseat.txt | 2 +- tests/docker/test-mingw | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-)
Patchew currently reports failures with the mingw docker test - this
is due to --with-sdlabi=2.0 configure flag which does not exist anymore.
Remove this remainder from the docker test and the docs now.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
docs/multiseat.txt | 2 +-
tests/docker/test-mingw | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/docs/multiseat.txt b/docs/multiseat.txt
index 8dde36c..11850c9 100644
--- a/docs/multiseat.txt
+++ b/docs/multiseat.txt
@@ -9,7 +9,7 @@ First you must compile qemu with a user interface supporting
multihead/multiseat and input event routing. Right now this
list includes sdl2, gtk (both 2+3) and vnc:
- ./configure --enable-sdl --with-sdlabi=2.0
+ ./configure --enable-sdl
or
diff --git a/tests/docker/test-mingw b/tests/docker/test-mingw
index b078f22..4b84cfe 100755
--- a/tests/docker/test-mingw
+++ b/tests/docker/test-mingw
@@ -27,8 +27,7 @@ for prefix in x86_64-w64-mingw32- i686-w64-mingw32-; do
--enable-curl \
--enable-vnc \
--enable-bzip2 \
- --enable-guest-agent \
- --with-sdlabi=2.0
+ --enable-guest-agent
install_qemu
make clean
--
1.8.3.1
On Mon, Feb 04, 2019 at 09:25:43AM +0100, Thomas Huth wrote: > Patchew currently reports failures with the mingw docker test - this > is due to --with-sdlabi=2.0 configure flag which does not exist anymore. > Remove this remainder from the docker test and the docs now. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > docs/multiseat.txt | 2 +- > tests/docker/test-mingw | 3 +-- > 2 files changed, 2 insertions(+), 3 deletions(-) Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
Hi Alex, On 2/4/19 11:19 AM, Daniel P. Berrangé wrote: > On Mon, Feb 04, 2019 at 09:25:43AM +0100, Thomas Huth wrote: >> Patchew currently reports failures with the mingw docker test - this >> is due to --with-sdlabi=2.0 configure flag which does not exist anymore. >> Remove this remainder from the docker test and the docs now. >> >> Signed-off-by: Thomas Huth <thuth@redhat.com> >> --- >> docs/multiseat.txt | 2 +- >> tests/docker/test-mingw | 3 +-- >> 2 files changed, 2 insertions(+), 3 deletions(-) > > Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com> IMHO this patch can probably get directly applied as a build-fix, rather than going thru qemu-trivial. Alex is that OK with you? Regards, Phil.
Thomas Huth <thuth@redhat.com> writes: > Patchew currently reports failures with the mingw docker test - this > is due to --with-sdlabi=2.0 configure flag which does not exist anymore. > Remove this remainder from the docker test and the docs now. > > Signed-off-by: Thomas Huth <thuth@redhat.com> Acked-by: Alex Bennée <alex.bennee@linaro.org> I'm happy for this to be applied directly by Peter. > --- > docs/multiseat.txt | 2 +- > tests/docker/test-mingw | 3 +-- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/docs/multiseat.txt b/docs/multiseat.txt > index 8dde36c..11850c9 100644 > --- a/docs/multiseat.txt > +++ b/docs/multiseat.txt > @@ -9,7 +9,7 @@ First you must compile qemu with a user interface supporting > multihead/multiseat and input event routing. Right now this > list includes sdl2, gtk (both 2+3) and vnc: > > - ./configure --enable-sdl --with-sdlabi=2.0 > + ./configure --enable-sdl > > or > > diff --git a/tests/docker/test-mingw b/tests/docker/test-mingw > index b078f22..4b84cfe 100755 > --- a/tests/docker/test-mingw > +++ b/tests/docker/test-mingw > @@ -27,8 +27,7 @@ for prefix in x86_64-w64-mingw32- i686-w64-mingw32-; do > --enable-curl \ > --enable-vnc \ > --enable-bzip2 \ > - --enable-guest-agent \ > - --with-sdlabi=2.0 > + --enable-guest-agent > install_qemu > make clean -- Alex Bennée
On Mon, 4 Feb 2019 at 13:35, Alex Bennée <alex.bennee@linaro.org> wrote: > > > Thomas Huth <thuth@redhat.com> writes: > > > Patchew currently reports failures with the mingw docker test - this > > is due to --with-sdlabi=2.0 configure flag which does not exist anymore. > > Remove this remainder from the docker test and the docs now. > > > > Signed-off-by: Thomas Huth <thuth@redhat.com> > > Acked-by: Alex Bennée <alex.bennee@linaro.org> > > I'm happy for this to be applied directly by Peter. Applied to master as a buildfix, thanks. -- PMM
© 2016 - 2024 Red Hat, Inc.