[Qemu-devel] [PATCH v2 2/5] ppc: Express dependencies of the 'prep' and '40p' machines with kconfig

Thomas Huth posted 5 patches 7 years ago
[Qemu-devel] [PATCH v2 2/5] ppc: Express dependencies of the 'prep' and '40p' machines with kconfig
Posted by Thomas Huth 7 years ago
Select the required devices in hw/ppc/Kconfig instead, so that
ppc-softmmu.mak only contains the user-selectable PREP switch.
Plug-in devices like NE2000_ISA are pulled in automatically by the
Kconfig build system now.

Cc: Hervé Poussineau <hpoussin@reactos.org>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 default-configs/ppc-softmmu.mak | 8 --------
 hw/ppc/Kconfig                  | 8 ++++++++
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/default-configs/ppc-softmmu.mak b/default-configs/ppc-softmmu.mak
index 05ba726..422f1b7 100644
--- a/default-configs/ppc-softmmu.mak
+++ b/default-configs/ppc-softmmu.mak
@@ -57,11 +57,3 @@ CONFIG_MAC_NEWWORLD=y
 
 # For PReP
 CONFIG_PREP=y
-CONFIG_PREP_PCI=y
-CONFIG_RS6000_MC=y
-CONFIG_I82374=y
-CONFIG_I82378=y
-CONFIG_PCKBD=y
-CONFIG_NE2000_ISA=y
-CONFIG_PC87312=y
-CONFIG_CS4231A=y
diff --git a/hw/ppc/Kconfig b/hw/ppc/Kconfig
index 4dbf866..b1c3a30 100644
--- a/hw/ppc/Kconfig
+++ b/hw/ppc/Kconfig
@@ -33,6 +33,14 @@ config SAM460EX
 
 config PREP
     bool
+    select CS4231A
+    select PREP_PCI
+    select I82374
+    select I82378
+    select LSI_SCSI_PCI
+    select M48T59
+    select PC87312
+    select RS6000_MC
 
 config RS6000_MC
     bool
-- 
1.8.3.1


Re: [Qemu-devel] [PATCH v2 2/5] ppc: Express dependencies of the 'prep' and '40p' machines with kconfig
Posted by Hervé Poussineau 7 years ago
Le 31/01/2019 à 14:53, Thomas Huth a écrit :
> Select the required devices in hw/ppc/Kconfig instead, so that
> ppc-softmmu.mak only contains the user-selectable PREP switch.
> Plug-in devices like NE2000_ISA are pulled in automatically by the
> Kconfig build system now.
> 
> Cc: Hervé Poussineau <hpoussin@reactos.org>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   default-configs/ppc-softmmu.mak | 8 --------
>   hw/ppc/Kconfig                  | 8 ++++++++
>   2 files changed, 8 insertions(+), 8 deletions(-)
> 

Reviewed-by: Hervé Poussineau <hpoussin@reactos.org>