hw/ppc/spapr: Add support for "-vga cirrus"

[Qemu-devel] [PATCH] hw/ppc/spapr: Add support for "-vga cirrus"

Thomas Huth posted 1 patch 6 years, 9 months ago

Download mbox

Test docker-mingw@fedora passed

Test asan passed

Test checkpatch passed

Test docker-clang@ubuntu passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1548855399-31273-1-git-send-email-thuth@redhat.com

Maintainers: David Gibson <david@gibson.dropbear.id.au>

hw/ppc/spapr.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[Qemu-devel] [PATCH] hw/ppc/spapr: Add support for "-vga cirrus"

Posted by Thomas Huth 6 years, 9 months ago

The cirrus VGA card has been enabled in the PPC builds with
commit 29f9cef39eb1ae55e82c ("ppc: Include vga cirrus card into
the compiling process") last year. It also works on the pseries
machine, even SLOF contains support for this card, so we can
also support this for the "-vga" parameter here.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 hw/ppc/spapr.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 71fe552..2323974 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -1717,6 +1717,7 @@ static bool spapr_vga_init(PCIBus *pci_bus, Error **errp)
         return true;
     case VGA_STD:
     case VGA_VIRTIO:
+    case VGA_CIRRUS:
         return pci_vga_init(pci_bus) != NULL;
     default:
         error_setg(errp,
-- 
1.8.3.1

Re: [Qemu-devel] [PATCH] hw/ppc/spapr: Add support for "-vga cirrus"

Posted by David Gibson 6 years, 9 months ago

On Wed, Jan 30, 2019 at 02:36:39PM +0100, Thomas Huth wrote:
> The cirrus VGA card has been enabled in the PPC builds with
> commit 29f9cef39eb1ae55e82c ("ppc: Include vga cirrus card into
> the compiling process") last year. It also works on the pseries
> machine, even SLOF contains support for this card, so we can
> also support this for the "-vga" parameter here.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Applied to ppc-for-4.0.

> ---
>  hw/ppc/spapr.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index 71fe552..2323974 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -1717,6 +1717,7 @@ static bool spapr_vga_init(PCIBus *pci_bus, Error **errp)
>          return true;
>      case VGA_STD:
>      case VGA_VIRTIO:
> +    case VGA_CIRRUS:
>          return pci_vga_init(pci_bus) != NULL;
>      default:
>          error_setg(errp,

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson