decodetree: re.fullmatch was added in 3.4

[Qemu-devel] [PATCH] decodetree: re.fullmatch was added in 3.4

Paolo Bonzini posted 1 patch 6 years, 9 months ago

Download mbox

Test asan passed

Test docker-clang@ubuntu passed

Test docker-mingw@fedora passed

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1548410602-16008-1-git-send-email-pbonzini@redhat.com

Maintainers: Eduardo Habkost <ehabkost@redhat.com>, Cleber Rosa <crosa@redhat.com>

scripts/decodetree.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[Qemu-devel] [PATCH] decodetree: re.fullmatch was added in 3.4

Posted by Paolo Bonzini 6 years, 9 months ago

Python 3 versions earlier than 3.4 do not have it, use the
same workaround that is in place for 3.0.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 scripts/decodetree.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/decodetree.py b/scripts/decodetree.py
index 0bc73b5..e342d27 100755
--- a/scripts/decodetree.py
+++ b/scripts/decodetree.py
@@ -204,7 +204,7 @@ def output(*args):
         output_fd.write(a)
 
 
-if sys.version_info >= (3, 0):
+if sys.version_info >= (3, 4):
     re_fullmatch = re.fullmatch
 else:
     def re_fullmatch(pat, str):
-- 
1.8.3.1

Re: [Qemu-devel] [PATCH] decodetree: re.fullmatch was added in 3.4

Posted by Philippe Mathieu-Daudé 6 years, 9 months ago

Cc'ing maintainers :P

$ ./scripts/get_maintainer.pl -f scripts/decodetree.py
Eduardo Habkost <ehabkost@redhat.com> (odd fixer:Python scripts)
Cleber Rosa <crosa@redhat.com> (odd fixer:Python scripts)

On 1/25/19 11:03 AM, Paolo Bonzini wrote:
> Python 3 versions earlier than 3.4 do not have it, use the
> same workaround that is in place for 3.0.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>  scripts/decodetree.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/decodetree.py b/scripts/decodetree.py
> index 0bc73b5..e342d27 100755
> --- a/scripts/decodetree.py
> +++ b/scripts/decodetree.py
> @@ -204,7 +204,7 @@ def output(*args):
>          output_fd.write(a)
>  
>  
> -if sys.version_info >= (3, 0):
> +if sys.version_info >= (3, 4):
>      re_fullmatch = re.fullmatch
>  else:
>      def re_fullmatch(pat, str):
>

Re: [Qemu-devel] [PATCH] decodetree: re.fullmatch was added in 3.4

Posted by Eduardo Habkost 6 years, 9 months ago

On Fri, Jan 25, 2019 at 01:45:00PM +0100, Philippe Mathieu-Daudé wrote:
> Cc'ing maintainers :P
> 
> $ ./scripts/get_maintainer.pl -f scripts/decodetree.py
> Eduardo Habkost <ehabkost@redhat.com> (odd fixer:Python scripts)
> Cleber Rosa <crosa@redhat.com> (odd fixer:Python scripts)
> 
> On 1/25/19 11:03 AM, Paolo Bonzini wrote:
> > Python 3 versions earlier than 3.4 do not have it, use the
> > same workaround that is in place for 3.0.
> > 
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> 
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Queued, thanks!

-- 
Eduardo