[Qemu-devel] [PULL 00/25] ivshmem deprecation, qtests, typedefs and gnu99

Thomas Huth posted 25 patches 6 years, 9 months ago
Test asan passed
Test checkpatch passed
Test docker-clang@ubuntu passed
Test docker-mingw@fedora passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1547460140-1473-1-git-send-email-thuth@redhat.com
Maintainers: Laurent Vivier <lvivier@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, "Cédric Le Goater" <clg@kaod.org>, Richard Henderson <rth@twiddle.net>, Peter Maydell <peter.maydell@linaro.org>, Riku Voipio <riku.voipio@iki.fi>, Alistair Francis <alistair@alistair23.me>, Eduardo Habkost <ehabkost@redhat.com>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Peter Crosthwaite <crosthwaite.peter@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, Thomas Huth <thuth@redhat.com>, John Snow <jsnow@redhat.com>, David Gibson <david@gibson.dropbear.id.au>, "Michael S. Tsirkin" <mst@redhat.com>, Andrzej Zaborowski <balrogg@gmail.com>, Laurent Vivier <laurent@vivier.eu>, Su Hang <suhang16@mails.ucas.ac.cn>
There is a newer version of this series
audio/audio_int.h           |   4 +-
configure                   |   5 +-
docs/specs/ivshmem-spec.txt |   8 +-
hw/arm/strongarm.h          |   1 +
hw/i386/pc_piix.c           |   1 -
hw/intc/xics_kvm.c          |   1 +
hw/intc/xics_spapr.c        |   1 +
hw/misc/ivshmem.c           | 210 +---------------------------
hw/ppc/spapr_irq.c          |   1 +
hw/virtio/vhost-user.c      |   2 +-
include/hw/arm/pxa.h        |   2 +
include/hw/char/serial.h    |   4 +-
include/hw/i2c/smbus.h      |   2 +
include/hw/i386/pc.h        |   4 +-
include/hw/ide/ahci.h       |   4 +-
include/hw/input/ps2.h      |   2 +
include/hw/pcmcia.h         |   4 +-
include/hw/ppc/spapr.h      |   5 +-
include/hw/ppc/spapr_xive.h |   2 -
include/hw/ppc/xics.h       |   7 -
include/hw/ppc/xics_spapr.h |  37 +++++
include/hw/ssi/pl022.h      |   1 +
include/hw/ssi/ssi.h        |   1 +
include/qemu/compiler.h     |   4 +
include/qemu/typedefs.h     |  12 --
include/sysemu/bt.h         |   4 +-
include/ui/console.h        |  10 +-
linux-user/qemu.h           |   6 +-
qemu-deprecated.texi        |   5 -
scripts/device-crash-test   |   1 -
target/ppc/cpu.h            |  13 +-
tests/Makefile.include      |  22 +--
tests/boot-order-test.c     |  59 ++++----
tests/endianness-test.c     | 329 ++++++++++++++++++++++----------------------
tests/hexloader-test.c      |   2 +-
tests/ivshmem-test.c        |  67 ++++-----
tests/pnv-xscom-test.c      |  29 ++--
tests/vhost-user-test.c     |   2 +-
util/oslib-posix.c          |   8 +-
39 files changed, 352 insertions(+), 530 deletions(-)
create mode 100644 include/hw/ppc/xics_spapr.h
[Qemu-devel] [PULL 00/25] ivshmem deprecation, qtests, typedefs and gnu99
Posted by Thomas Huth 6 years, 9 months ago
 Hi Peter,

the following changes since commit 27df21ca3886fff4dd3d70e515517667963a52f1:

  Merge remote-tracking branch 'remotes/kraxel/tags/misc-20190111-pull-request' into staging (2019-01-11 16:45:59 +0000)

are available in the git repository at:

  https://gitlab.com/huth/qemu.git tags/pull-request-2019-01-14

for you to fetch changes up to 62c36a5f7cad3048bfc41ac24c0593f466b408f4:

  tests/hexloader-test: Don't pass -nographic to the QEMU under test (2019-01-14 10:50:40 +0100)

----------------------------------------------------------------
- Remove deprecated "ivshmem" legacy device
- Bug fix for vhost-user-test
- Use more CONFIG Makefile switches for qtests
- Get rid of global_qtests in some more qtests
- typedef cleanups
- Fixes for compiling with Clang
- Force C standard to gnu99
----------------------------------------------------------------

Li Qiang (3):
      tests: vhost-user-test: initialize 'fd' in chr_read
      vhost-user: fix ioeventfd_enabled
      util: check the return value of fcntl in qemu_set_{block, nonblock}

Peter Maydell (1):
      tests/hexloader-test: Don't pass -nographic to the QEMU under test

Philippe Mathieu-Daudé (11):
      hw/input/ps2: Remove PS2State from "qemu/typedefs.h"
      hw/pcmcia: Remove PCMCIACardState from "qemu/typedefs.h"
      hw/ssi: Remove SSIBus from "qemu/typedefs.h"
      hw/ide/ahci: Remove AllwinnerAHCIState from "qemu/typedefs.h"
      hw/i2c/smbus: Remove SMBusDevice from "qemu/typedefs.h"
      hw/bt: Remove HCIInfo from "qemu/typedefs.h"
      hw/char/serial: Remove SerialState from "qemu/typedefs.h"
      hw/i386: Remove PCMachineClass from "qemu/typedefs.h"
      audio: Remove AudioState from "qemu/typedefs.h"
      ui/console: Remove QemuDmaBuf from "qemu/typedefs.h"
      ui/console: Remove DisplayState/DisplaySurface from "qemu/typedefs.h"

Thomas Huth (10):
      hw/misc/ivshmem: Remove deprecated "ivshmem" legacy device
      tests/Makefile: Use some more CONFIG switches for x86 tests
      tests/Makefile: Use some more CONFIG switches for ppc tests
      tests/endianesss: Make test independent of global_qtest
      tests/boot-order: Make test independent of global_qtest
      tests/pnv-xscom: Make test independent of global_qtest
      linux-user: Fix compilation with clang 3.4
      ppc: Move spapr-related prototypes from xics.h into a seperate header file
      ppc: Fix duplicated typedefs to be able to compile with Clang in gnu99 mode
      configure: Force the C standard to gnu99

 audio/audio_int.h           |   4 +-
 configure                   |   5 +-
 docs/specs/ivshmem-spec.txt |   8 +-
 hw/arm/strongarm.h          |   1 +
 hw/i386/pc_piix.c           |   1 -
 hw/intc/xics_kvm.c          |   1 +
 hw/intc/xics_spapr.c        |   1 +
 hw/misc/ivshmem.c           | 210 +---------------------------
 hw/ppc/spapr_irq.c          |   1 +
 hw/virtio/vhost-user.c      |   2 +-
 include/hw/arm/pxa.h        |   2 +
 include/hw/char/serial.h    |   4 +-
 include/hw/i2c/smbus.h      |   2 +
 include/hw/i386/pc.h        |   4 +-
 include/hw/ide/ahci.h       |   4 +-
 include/hw/input/ps2.h      |   2 +
 include/hw/pcmcia.h         |   4 +-
 include/hw/ppc/spapr.h      |   5 +-
 include/hw/ppc/spapr_xive.h |   2 -
 include/hw/ppc/xics.h       |   7 -
 include/hw/ppc/xics_spapr.h |  37 +++++
 include/hw/ssi/pl022.h      |   1 +
 include/hw/ssi/ssi.h        |   1 +
 include/qemu/compiler.h     |   4 +
 include/qemu/typedefs.h     |  12 --
 include/sysemu/bt.h         |   4 +-
 include/ui/console.h        |  10 +-
 linux-user/qemu.h           |   6 +-
 qemu-deprecated.texi        |   5 -
 scripts/device-crash-test   |   1 -
 target/ppc/cpu.h            |  13 +-
 tests/Makefile.include      |  22 +--
 tests/boot-order-test.c     |  59 ++++----
 tests/endianness-test.c     | 329 ++++++++++++++++++++++----------------------
 tests/hexloader-test.c      |   2 +-
 tests/ivshmem-test.c        |  67 ++++-----
 tests/pnv-xscom-test.c      |  29 ++--
 tests/vhost-user-test.c     |   2 +-
 util/oslib-posix.c          |   8 +-
 39 files changed, 352 insertions(+), 530 deletions(-)
 create mode 100644 include/hw/ppc/xics_spapr.h

Re: [Qemu-devel] [PULL 00/25] ivshmem deprecation, qtests, typedefs and gnu99
Posted by Peter Maydell 6 years, 9 months ago
On Mon, 14 Jan 2019 at 10:02, Thomas Huth <thuth@redhat.com> wrote:
>
>  Hi Peter,
>
> the following changes since commit 27df21ca3886fff4dd3d70e515517667963a52f1:
>
>   Merge remote-tracking branch 'remotes/kraxel/tags/misc-20190111-pull-request' into staging (2019-01-11 16:45:59 +0000)
>
> are available in the git repository at:
>
>   https://gitlab.com/huth/qemu.git tags/pull-request-2019-01-14
>
> for you to fetch changes up to 62c36a5f7cad3048bfc41ac24c0593f466b408f4:
>
>   tests/hexloader-test: Don't pass -nographic to the QEMU under test (2019-01-14 10:50:40 +0100)
>
> ----------------------------------------------------------------
> - Remove deprecated "ivshmem" legacy device
> - Bug fix for vhost-user-test
> - Use more CONFIG Makefile switches for qtests
> - Get rid of global_qtests in some more qtests
> - typedef cleanups
> - Fixes for compiling with Clang
> - Force C standard to gnu99
> ----------------------------------------------------------------

Compile failure, ppc64 host:

In file included from /home/pm215/qemu/block/iscsi.c:52:0:
/usr/include/iscsi/scsi-lowlevel.h:810:13: error: inline function
‘scsi_set_uint16’ declared but never defined [-Werror]
 inline void scsi_set_uint16(unsigned char *c, uint16_t val);
             ^
/usr/include/iscsi/scsi-lowlevel.h:809:13: error: inline function
‘scsi_set_uint32’ declared but never defined [-Werror]
 inline void scsi_set_uint32(unsigned char *c, uint32_t val);
             ^
/usr/include/iscsi/scsi-lowlevel.h:808:17: error: inline function
‘scsi_get_uint16’ declared but never defined [-Werror]
 inline uint16_t scsi_get_uint16(const unsigned char *c);
                 ^
/usr/include/iscsi/scsi-lowlevel.h:807:17: error: inline function
‘scsi_get_uint32’ declared but never defined [-Werror]
 inline uint32_t scsi_get_uint32(const unsigned char *c);
                 ^
/usr/include/iscsi/scsi-lowlevel.h:810:13: error: inline function
‘scsi_set_uint16’ declared but never defined [-Werror]
 inline void scsi_set_uint16(unsigned char *c, uint16_t val);
             ^
/usr/include/iscsi/scsi-lowlevel.h:809:13: error: inline function
‘scsi_set_uint32’ declared but never defined [-Werror]
 inline void scsi_set_uint32(unsigned char *c, uint32_t val);
             ^
/usr/include/iscsi/scsi-lowlevel.h:808:17: error: inline function
‘scsi_get_uint16’ declared but never defined [-Werror]
 inline uint16_t scsi_get_uint16(const unsigned char *c);
                 ^
/usr/include/iscsi/scsi-lowlevel.h:807:17: error: inline function
‘scsi_get_uint32’ declared but never defined [-Werror]
 inline uint32_t scsi_get_uint32(const unsigned char *c);
                 ^

thanks
-- PMM

Re: [Qemu-devel] [PULL 00/25] ivshmem deprecation, qtests, typedefs and gnu99
Posted by Thomas Huth 6 years, 9 months ago
On 2019-01-14 13:52, Peter Maydell wrote:
> On Mon, 14 Jan 2019 at 10:02, Thomas Huth <thuth@redhat.com> wrote:
>>
>>  Hi Peter,
>>
>> the following changes since commit 27df21ca3886fff4dd3d70e515517667963a52f1:
>>
>>   Merge remote-tracking branch 'remotes/kraxel/tags/misc-20190111-pull-request' into staging (2019-01-11 16:45:59 +0000)
>>
>> are available in the git repository at:
>>
>>   https://gitlab.com/huth/qemu.git tags/pull-request-2019-01-14
>>
>> for you to fetch changes up to 62c36a5f7cad3048bfc41ac24c0593f466b408f4:
>>
>>   tests/hexloader-test: Don't pass -nographic to the QEMU under test (2019-01-14 10:50:40 +0100)
>>
>> ----------------------------------------------------------------
>> - Remove deprecated "ivshmem" legacy device
>> - Bug fix for vhost-user-test
>> - Use more CONFIG Makefile switches for qtests
>> - Get rid of global_qtests in some more qtests
>> - typedef cleanups
>> - Fixes for compiling with Clang
>> - Force C standard to gnu99
>> ----------------------------------------------------------------
> 
> Compile failure, ppc64 host:
> 
> In file included from /home/pm215/qemu/block/iscsi.c:52:0:
> /usr/include/iscsi/scsi-lowlevel.h:810:13: error: inline function
> ‘scsi_set_uint16’ declared but never defined [-Werror]
>  inline void scsi_set_uint16(unsigned char *c, uint16_t val);
>              ^

What the .... in a system header?? That's not fair... sigh, let me think
of a work-around...

 Thomas