[Qemu-devel] [PATCH v5 0/3] Force the C standard to gnu99

Thomas Huth posted 3 patches 5 years, 3 months ago
Test asan passed
Test checkpatch passed
Test docker-clang@ubuntu passed
Test docker-mingw@fedora passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1547194672-24169-1-git-send-email-thuth@redhat.com
Maintainers: "Cédric Le Goater" <clg@kaod.org>, David Gibson <david@gibson.dropbear.id.au>
configure                   |  5 ++++-
hw/intc/xics_kvm.c          |  1 +
hw/intc/xics_spapr.c        |  1 +
hw/ppc/spapr_irq.c          |  1 +
include/hw/ppc/spapr.h      |  5 +++--
include/hw/ppc/spapr_xive.h |  2 --
include/hw/ppc/xics.h       |  7 -------
include/hw/ppc/xics_spapr.h | 37 +++++++++++++++++++++++++++++++++++++
target/ppc/cpu.h            | 13 +++++++++----
9 files changed, 56 insertions(+), 16 deletions(-)
create mode 100644 include/hw/ppc/xics_spapr.h
[Qemu-devel] [PATCH v5 0/3] Force the C standard to gnu99
Posted by Thomas Huth 5 years, 3 months ago
Different versions of GCC and Clang use different versions of the C
standard by default. To avoid compilation problems with different
compilers in the future, we should enforce one language level
for all compilers. Since "gnu99" is the only usable option right now
(later versions are still marked as experimental in GCC v4.8),
we enforce compiling with -std=gnu99 now (in the third patch).
This caused some new warnings/erros to appear with clang, which are
fixed by the first two patches.

v5:
 - Prefer to include headers instead of plain struct forward declarations
   in the second patch.

v4:
 - Avoid circular inclusion of headers and introduce xics_spapr.h

v3:
 - Compile C++ code with -std=gnu++98

v2:
 - Use gnu99 instead of gnu11

Thomas Huth (3):
  ppc: Move spapr-related prototypes from xics.h into a seperate header
    file
  ppc: Fix duplicated typedefs to be able to compile with Clang in gnu99
    mode
  configure: Force the C standard to gnu99

 configure                   |  5 ++++-
 hw/intc/xics_kvm.c          |  1 +
 hw/intc/xics_spapr.c        |  1 +
 hw/ppc/spapr_irq.c          |  1 +
 include/hw/ppc/spapr.h      |  5 +++--
 include/hw/ppc/spapr_xive.h |  2 --
 include/hw/ppc/xics.h       |  7 -------
 include/hw/ppc/xics_spapr.h | 37 +++++++++++++++++++++++++++++++++++++
 target/ppc/cpu.h            | 13 +++++++++----
 9 files changed, 56 insertions(+), 16 deletions(-)
 create mode 100644 include/hw/ppc/xics_spapr.h

-- 
1.8.3.1