1. Patchew
  2. QEMU
  3. View series

[Qemu-devel] [PATCH] target/ppc/kvm: Drop useless include directive

Greg Kurz posted 1 patch 5 years, 3 months ago
Test asan passed
Test checkpatch passed
Test docker-clang@ubuntu passed
Test docker-mingw@fedora passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/154713023826.379171.4010754027183178230.stgit@bahia.lan
Maintainers: David Gibson <david@gibson.dropbear.id.au>
target/ppc/kvm.c |    1 -
1 file changed, 1 deletion(-)
[Qemu-devel] [PATCH] target/ppc/kvm: Drop useless include directive
Posted by Greg Kurz 5 years, 3 months ago 
It has been there since the enablement of PR KVM for PAPR, ie, commit
f61b4bedaf35 in 2011. Not sure why at that time, but it is definitely
not needed with the current code.

Signed-off-by: Greg Kurz <groug@kaod.org>
---
 target/ppc/kvm.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c
index ebbb48c42f25..d01852fe3112 100644
--- a/target/ppc/kvm.c
+++ b/target/ppc/kvm.c
@@ -36,7 +36,6 @@
 
 #include "hw/sysbus.h"
 #include "hw/ppc/spapr.h"
-#include "hw/ppc/spapr_vio.h"
 #include "hw/ppc/spapr_cpu_core.h"
 #include "hw/ppc/ppc.h"
 #include "sysemu/watchdog.h"
Re: [Qemu-devel] [PATCH] target/ppc/kvm: Drop useless include directive
Posted by David Gibson 5 years, 3 months ago 
On Thu, Jan 10, 2019 at 03:23:58PM +0100, Greg Kurz wrote:
> It has been there since the enablement of PR KVM for PAPR, ie, commit
> f61b4bedaf35 in 2011. Not sure why at that time, but it is definitely
> not needed with the current code.
> 
> Signed-off-by: Greg Kurz <groug@kaod.org>

Applied to ppc-for-4.0, thanks.

> ---
>  target/ppc/kvm.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c
> index ebbb48c42f25..d01852fe3112 100644
> --- a/target/ppc/kvm.c
> +++ b/target/ppc/kvm.c
> @@ -36,7 +36,6 @@
>  
>  #include "hw/sysbus.h"
>  #include "hw/ppc/spapr.h"
> -#include "hw/ppc/spapr_vio.h"
>  #include "hw/ppc/spapr_cpu_core.h"
>  #include "hw/ppc/ppc.h"
>  #include "sysemu/watchdog.h"
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson
Re: [Qemu-devel] [PATCH] target/ppc/kvm: Drop useless include directive
Posted by no-reply@patchew.org 5 years, 3 months ago 
Patchew URL: https://patchew.org/QEMU/154713023826.379171.4010754027183178230.stgit@bahia.lan/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH] target/ppc/kvm: Drop useless include directive
Type: series
Message-id: 154713023826.379171.4010754027183178230.stgit@bahia.lan

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback --color=always base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Traceback (most recent call last):
  File "patchew-tester8/src/patchew-cli", line 521, in test_one
    git_clone_repo(clone, r["repo"], r["head"], logf, True)
  File "patchew-tester8/src/patchew-cli", line 48, in git_clone_repo
    stdout=logf, stderr=logf)
  File "/usr/lib64/python3.3/subprocess.py", line 544, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['git', 'remote', 'add', '-f', '--mirror=fetch', '3c8cf5a9c21ff8782164d1def7f44bd888713384', 'https://github.com/patchew-project/qemu']' returned non-zero exit status -9



The full log is available at
http://patchew.org/logs/154713023826.379171.4010754027183178230.stgit@bahia.lan/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [Qemu-devel] [PATCH] target/ppc/kvm: Drop useless include directive
Posted by no-reply@patchew.org 5 years, 3 months ago 
Patchew URL: https://patchew.org/QEMU/154713023826.379171.4010754027183178230.stgit@bahia.lan/



Hi,

This series failed the docker-quick@centos7 build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
time make docker-test-quick@centos7 SHOW_ENV=1 J=8
=== TEST SCRIPT END ===




The full log is available at
http://patchew.org/logs/154713023826.379171.4010754027183178230.stgit@bahia.lan/testing.docker-quick@centos7/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [Qemu-devel] [PATCH] target/ppc/kvm: Drop useless include directive
Posted by no-reply@patchew.org 5 years, 3 months ago 
Patchew URL: https://patchew.org/QEMU/154713023826.379171.4010754027183178230.stgit@bahia.lan/



Hi,

This series failed the docker-mingw@fedora build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
time make docker-test-mingw@fedora SHOW_ENV=1 J=8
=== TEST SCRIPT END ===




The full log is available at
http://patchew.org/logs/154713023826.379171.4010754027183178230.stgit@bahia.lan/testing.docker-mingw@fedora/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Patchew 2.1-devel-0870f84

© 2016 - 2024 Red Hat, Inc.