hw/audio/marvell: Don't include unnecessary i2c.h header file

[Qemu-devel] [PATCH] hw/audio/marvell: Don't include unnecessary i2c.h header file

Thomas Huth posted 1 patch 5 years, 3 months ago

Download mbox

Test asan passed

Test checkpatch passed

Test docker-mingw@fedora passed

Test docker-quick@centos7 passed

Test docker-clang@ubuntu passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1546614146-10525-1-git-send-email-thuth@redhat.com

hw/audio/marvell_88w8618.c | 1 -
1 file changed, 1 deletion(-)

Expand all Fold all

[Qemu-devel] [PATCH] hw/audio/marvell: Don't include unnecessary i2c.h header file

Posted by Thomas Huth 5 years, 3 months ago

This device does not use I2C, so no need to include the header file here.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 hw/audio/marvell_88w8618.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/audio/marvell_88w8618.c b/hw/audio/marvell_88w8618.c
index 6600ab4..035dd76 100644
--- a/hw/audio/marvell_88w8618.c
+++ b/hw/audio/marvell_88w8618.c
@@ -12,7 +12,6 @@
 #include "qemu/osdep.h"
 #include "hw/sysbus.h"
 #include "hw/hw.h"
-#include "hw/i2c/i2c.h"
 #include "hw/audio/wm8750.h"
 #include "audio/audio.h"
 #include "qapi/error.h"
-- 
1.8.3.1

Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw/audio/marvell: Don't include unnecessary i2c.h header file

Posted by Laurent Vivier 5 years, 3 months ago

On 04/01/2019 16:02, Thomas Huth wrote:
> This device does not use I2C, so no need to include the header file here.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  hw/audio/marvell_88w8618.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/hw/audio/marvell_88w8618.c b/hw/audio/marvell_88w8618.c
> index 6600ab4..035dd76 100644
> --- a/hw/audio/marvell_88w8618.c
> +++ b/hw/audio/marvell_88w8618.c
> @@ -12,7 +12,6 @@
>  #include "qemu/osdep.h"
>  #include "hw/sysbus.h"
>  #include "hw/hw.h"
> -#include "hw/i2c/i2c.h"
>  #include "hw/audio/wm8750.h"
>  #include "audio/audio.h"
>  #include "qapi/error.h"
> 


Applied to my trivial-patches branch.

Thanks,
Laurent

Re: [Qemu-devel] [PATCH] hw/audio/marvell: Don't include unnecessary i2c.h header file

Posted by Gerd Hoffmann 5 years, 3 months ago

On Fri, Jan 04, 2019 at 04:02:26PM +0100, Thomas Huth wrote:
> This device does not use I2C, so no need to include the header file here.

Added to audio queue.

thanks,
  Gerd