[Qemu-devel] [PATCH v6 00/26] disas: nanoMIPS: Clean up several issues

Aleksandar Markovic posted 26 patches 5 years, 4 months ago
Test asan passed
Test checkpatch passed
Test docker-mingw@fedora passed
Test docker-quick@centos7 passed
Test docker-clang@ubuntu passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1545920586-17815-1-git-send-email-aleksandar.markovic@rt-rk.com
disas/nanomips.cpp | 2135 ++++++++++++++++++++++++++--------------------------
disas/nanomips.h   |  115 ++-
2 files changed, 1111 insertions(+), 1139 deletions(-)
[Qemu-devel] [PATCH v6 00/26] disas: nanoMIPS: Clean up several issues
Posted by Aleksandar Markovic 5 years, 4 months ago
From: Aleksandar Markovic <amarkovic@wavecomp.com>

Clean up several misc issues in nanoMIPS disassembler. There are
more issues to be cleaned, and this is meant to be just the first
phase. Complete cleanup should happen over the course of next
few months.

All these changes should not and do not affect any functionality.

v5->v6:

  - patches that deal with adding format specifiers [16] and [49]
    removed, until we determine what is the most appropriate form,
    and how to be more in sync with objdump output and inline
    assembler allowed formats
  - added 14 patches on reformating grp decoders
  - added a patch that adds documentation as reference

v4->v5:

  - renamed patch "Fix comments for 48-bit instructions" to
      "Clean up handling of 48-bit instructions"
  - added patch "Clean up handling of 16-bit logic instructions"
  - added eight patches on improving gpr decoders
  - minor addition to patch "Fix order of more invocations"
  - minor cleanups of previous commit messages

v3->v4:

  - added patch "Name more functions in a more descriptive way"
  - added patch "Fix order of more invocations"
  - added patch "Fix comments for 48-bit instructions"
  - minor cleanups of previous commit messages

v2->v3:

  - added three patches that fix function misnomers.
  - minor changes in commit messages.

v1->v2:

  - patch 5 was somehow lost in v1, now should be fine.

Aleksandar Markovic (26):
  disas: nanoMIPS: Fix preamble text in nanomips.* files
  disas: nanoMIPS: Remove functions that are not used
  disas: nanoMIPS: Fix a function misnomer
  disas: nanoMIPS: Fix order of some invocations
  disas: nanoMIPS: Name some functions in a more descriptive way
  disas: nanoMIPS: Fix an FP-related misnomer 1
  disas: nanoMIPS: Fix an FP-related misnomer 2
  disas: nanoMIPS: Fix an FP-related misnomer 3
  disas: nanoMIPS: Name more functions in a more descriptive way
  disas: nanoMIPS: Fix order of more invocations
  disas: nanoMIPS: Rename the decoder of 'gpr3' gpr encoding type
  disas: nanoMIPS: Comment the decoder of 'gpr3' gpr encoding type
  disas: nanoMIPS: Rename the decoder of 'gpr3.src.store' gpr encoding
    type
  disas: nanoMIPS: Comment the decoder of 'gpr3.src.store' gpr encoding
    type
  disas: nanoMIPS: Rename the decoder of 'gpr4' gpr encoding type
  disas: nanoMIPS: Comment the decoder of 'gpr4' gpr encoding type
  disas: nanoMIPS: Rename the decoder of 'gpr4.zero' gpr encoding type
  disas: nanoMIPS: Comment the decoder of 'gpr4.zero' gpr encoding type
  disas: nanoMIPS: Rename the decoder of 'gpr2.reg1' gpr encoding type
  disas: nanoMIPS: Comment the decoder of 'gpr2.reg1' gpr encoding type
  disas: nanoMIPS: Rename the decoder of 'gpr2.reg2' gpr encoding type
  disas: nanoMIPS: Comment the decoder of 'gpr2.reg2' gpr encoding type
  disas: nanoMIPS: Rename the decoder of 'gpr1' gpr encoding type
  disas: nanoMIPS: Comment the decoder of 'gpr1' gpr encoding type
  disas: nanoMIPS: Reorder declarations and definitions of gpr decoders
  disas: nanoMIPS: Add a note on documentation

 disas/nanomips.cpp | 2135 ++++++++++++++++++++++++++--------------------------
 disas/nanomips.h   |  115 ++-
 2 files changed, 1111 insertions(+), 1139 deletions(-)

-- 
2.7.4


Re: [Qemu-devel] [PATCH v6 00/26] disas: nanoMIPS: Clean up several issues
Posted by Aleksandar Rikalo 5 years, 4 months ago
> From: Aleksandar Markovic <aleksandar.markovic@rt-rk.com>
> Sent: Thursday, December 27, 2018 3:22 PM
> To: qemu-devel@nongnu.org
> Cc: aurelien@aurel32.net; Aleksandar Markovic; Stefan Markovic; Aleksandar Rikalo
> Subject: [PATCH v6 00/26] disas: nanoMIPS: Clean up several issues
>
> From: Aleksandar Markovic <amarkovic@wavecomp.com>
>
> Clean up several misc issues in nanoMIPS disassembler. There are
> more issues to be cleaned, and this is meant to be just the first
> phase. Complete cleanup should happen over the course of next
> few months.
>
> All these changes should not and do not affect any functionality.

For the whole series:
Reviewed-by: Aleksandar Rikalo <arikalo@wavecomp.com>

> v5->v6:
>
>   - patches that deal with adding format specifiers [16] and [49]
>     removed, until we determine what is the most appropriate form,
>     and how to be more in sync with objdump output and inline
>     assembler allowed formats
>   - added 14 patches on reformating grp decoders
>   - added a patch that adds documentation as reference
>
> v4->v5:
>
>   - renamed patch "Fix comments for 48-bit instructions" to
>       "Clean up handling of 48-bit instructions"
>   - added patch "Clean up handling of 16-bit logic instructions"
>   - added eight patches on improving gpr decoders
>   - minor addition to patch "Fix order of more invocations"
>   - minor cleanups of previous commit messages
>
> v3->v4:
>
>   - added patch "Name more functions in a more descriptive way"
>   - added patch "Fix order of more invocations"
>   - added patch "Fix comments for 48-bit instructions"
>   - minor cleanups of previous commit messages
>
> v2->v3:
>
>   - added three patches that fix function misnomers.
>   - minor changes in commit messages.
>
> v1->v2:
>
>   - patch 5 was somehow lost in v1, now should be fine.
>
> Aleksandar Markovic (26):
>   disas: nanoMIPS: Fix preamble text in nanomips.* files
>   disas: nanoMIPS: Remove functions that are not used
>   disas: nanoMIPS: Fix a function misnomer
>   disas: nanoMIPS: Fix order of some invocations
>   disas: nanoMIPS: Name some functions in a more descriptive way
>   disas: nanoMIPS: Fix an FP-related misnomer 1
>   disas: nanoMIPS: Fix an FP-related misnomer 2
>   disas: nanoMIPS: Fix an FP-related misnomer 3
>   disas: nanoMIPS: Name more functions in a more descriptive way
>   disas: nanoMIPS: Fix order of more invocations
>   disas: nanoMIPS: Rename the decoder of 'gpr3' gpr encoding type
>   disas: nanoMIPS: Comment the decoder of 'gpr3' gpr encoding type
>   disas: nanoMIPS: Rename the decoder of 'gpr3.src.store' gpr encoding
>     type
>   disas: nanoMIPS: Comment the decoder of 'gpr3.src.store' gpr encoding
>     type
>   disas: nanoMIPS: Rename the decoder of 'gpr4' gpr encoding type
>   disas: nanoMIPS: Comment the decoder of 'gpr4' gpr encoding type
>   disas: nanoMIPS: Rename the decoder of 'gpr4.zero' gpr encoding type
>   disas: nanoMIPS: Comment the decoder of 'gpr4.zero' gpr encoding type
>   disas: nanoMIPS: Rename the decoder of 'gpr2.reg1' gpr encoding type
>   disas: nanoMIPS: Comment the decoder of 'gpr2.reg1' gpr encoding type
>   disas: nanoMIPS: Rename the decoder of 'gpr2.reg2' gpr encoding type
>   disas: nanoMIPS: Comment the decoder of 'gpr2.reg2' gpr encoding type
>   disas: nanoMIPS: Rename the decoder of 'gpr1' gpr encoding type
>   disas: nanoMIPS: Comment the decoder of 'gpr1' gpr encoding type
>   disas: nanoMIPS: Reorder declarations and definitions of gpr decoders
>   disas: nanoMIPS: Add a note on documentation
>
>  disas/nanomips.cpp | 2135 ++++++++++++++++++++++++++--------------------------
>  disas/nanomips.h   |  115 ++-
>  2 files changed, 1111 insertions(+), 1139 deletions(-)
>
> --
> 2.7.4