[Qemu-devel] [PULL 0/8] Set minimum compiler versions to GCC 4.8 and Clang 3.4

Thomas Huth posted 8 patches 5 years, 4 months ago
Test asan passed
Test checkpatch passed
Test docker-mingw@fedora failed
Test docker-quick@centos7 passed
Test docker-clang@ubuntu passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1544606032-16924-1-git-send-email-thuth@redhat.com
Makefile.target             |  3 ---
audio/alsaaudio.c           |  2 --
configure                   | 47 +++++++++++++++++++++++++--------------------
hw/i2c/bitbang_i2c.h        |  2 --
include/hw/i2c/i2c.h        |  2 ++
include/hw/i2c/ppc4xx_i2c.h |  3 ---
include/qemu/compiler.h     |  8 +-------
include/qemu/host-utils.h   |  4 ++--
scripts/checkpatch.pl       |  1 -
scripts/cocci-macro-file.h  |  1 -
tcg/tcg.h                   |  4 +---
11 files changed, 32 insertions(+), 45 deletions(-)
[Qemu-devel] [PULL 0/8] Set minimum compiler versions to GCC 4.8 and Clang 3.4
Posted by Thomas Huth 5 years, 4 months ago
 Hi Peter,

the following changes since commit bb9bf94b3e8926553290bc9a7cb84315af422086:

  Merge remote-tracking branch 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2018-12-11 19:18:58 +0000)

are available in the git repository at:

  https://gitlab.com/huth/qemu.git tags/pull-request-2018-12-12

for you to fetch changes up to 2b4c1125ac3db2734222ff43c25388a16aca4a99:

  i2c: Move typedef of bitbang_i2c_interface to i2c.h (2018-12-12 10:01:13 +0100)

----------------------------------------------------------------
Explicitly check for minimum compiler versions.
Remove obsolete code for old compilers that is now not required anymore.
Fix a duplicated typedef for Clang 3.4.
----------------------------------------------------------------

BALATON Zoltan (1):
      i2c: Move typedef of bitbang_i2c_interface to i2c.h

Thomas Huth (7):
      configure: Add a test for the minimum compiler version
      configure: Remove obsolete check for Clang < 3.2
      configure: Remove old -fno-gcse workaround for GCC 4.6.x and 4.7.[012]
      tcg/tcg.h: Remove GCC check for tcg_debug_assert() macro
      audio/alsaaudio: Remove compiler check around pragma
      includes: Replace QEMU_GNUC_PREREQ with "__has_builtin || !defined(__clang__)"
      Remove QEMU_ARTIFICIAL macro

 Makefile.target             |  3 ---
 audio/alsaaudio.c           |  2 --
 configure                   | 47 +++++++++++++++++++++++++--------------------
 hw/i2c/bitbang_i2c.h        |  2 --
 include/hw/i2c/i2c.h        |  2 ++
 include/hw/i2c/ppc4xx_i2c.h |  3 ---
 include/qemu/compiler.h     |  8 +-------
 include/qemu/host-utils.h   |  4 ++--
 scripts/checkpatch.pl       |  1 -
 scripts/cocci-macro-file.h  |  1 -
 tcg/tcg.h                   |  4 +---
 11 files changed, 32 insertions(+), 45 deletions(-)

Re: [Qemu-devel] [PULL 0/8] Set minimum compiler versions to GCC 4.8 and Clang 3.4
Posted by no-reply@patchew.org 5 years, 4 months ago
Patchew URL: https://patchew.org/QEMU/1544606032-16924-1-git-send-email-thuth@redhat.com/



Hi,

This series failed the docker-mingw@fedora build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
time make docker-test-mingw@fedora SHOW_ENV=1 J=8
=== TEST SCRIPT END ===




The full log is available at
http://patchew.org/logs/1544606032-16924-1-git-send-email-thuth@redhat.com/testing.docker-mingw@fedora/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [Qemu-devel] [PULL 0/8] Set minimum compiler versions to GCC 4.8 and Clang 3.4
Posted by Thomas Huth 5 years, 4 months ago
On 2018-12-12 11:01, no-reply@patchew.org wrote:
> Patchew URL: https://patchew.org/QEMU/1544606032-16924-1-git-send-email-thuth@redhat.com/
> 
> Hi,
> 
> This series failed the docker-mingw@fedora build test. Please find the testing commands and
> their output below. If you have Docker installed, you can probably reproduce it
> locally.
> 
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
> time make docker-test-mingw@fedora SHOW_ENV=1 J=8
> === TEST SCRIPT END ===
> 
> The full log is available at
> http://patchew.org/logs/1544606032-16924-1-git-send-email-thuth@redhat.com/testing.docker-mingw@fedora/?type=message.

That looks like a networking error?

 Thomas

Re: [Qemu-devel] [PULL 0/8] Set minimum compiler versions to GCC 4.8 and Clang 3.4
Posted by Peter Maydell 5 years, 4 months ago
On Wed, 12 Dec 2018 at 09:13, Thomas Huth <thuth@redhat.com> wrote:
>
>  Hi Peter,
>
> the following changes since commit bb9bf94b3e8926553290bc9a7cb84315af422086:
>
>   Merge remote-tracking branch 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2018-12-11 19:18:58 +0000)
>
> are available in the git repository at:
>
>   https://gitlab.com/huth/qemu.git tags/pull-request-2018-12-12
>
> for you to fetch changes up to 2b4c1125ac3db2734222ff43c25388a16aca4a99:
>
>   i2c: Move typedef of bitbang_i2c_interface to i2c.h (2018-12-12 10:01:13 +0100)
>
> ----------------------------------------------------------------
> Explicitly check for minimum compiler versions.
> Remove obsolete code for old compilers that is now not required anymore.
> Fix a duplicated typedef for Clang 3.4.

Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/4.0
for any user-visible changes (we have a section for build environment
requirements at the bottom).

-- PMM

Re: [Qemu-devel] [PULL 0/8] Set minimum compiler versions to GCC 4.8 and Clang 3.4
Posted by Eric Blake 5 years, 4 months ago
On 12/12/18 3:13 AM, Thomas Huth wrote:
>   Hi Peter,
> 
> the following changes since commit bb9bf94b3e8926553290bc9a7cb84315af422086:
> 
>    Merge remote-tracking branch 'remotes/ehabkost/tags/machine-next-pull-request' into staging (2018-12-11 19:18:58 +0000)
> 
> are available in the git repository at:
> 
>    https://gitlab.com/huth/qemu.git tags/pull-request-2018-12-12
> 
> for you to fetch changes up to 2b4c1125ac3db2734222ff43c25388a16aca4a99:
> 
>    i2c: Move typedef of bitbang_i2c_interface to i2c.h (2018-12-12 10:01:13 +0100)
> 
> ----------------------------------------------------------------
> Explicitly check for minimum compiler versions.
> Remove obsolete code for old compilers that is now not required anymore.
> Fix a duplicated typedef for Clang 3.4.

Paolo's pending request includes some of the same patches. Git will 
probably do the right thing even if a patch is introduced twice through 
two arms of a merge, but I'm flagging it just in case either maintainer 
wants to coordinate sending a v2 pull request in time for Peter to not 
have to worry about the duplication.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org