[Qemu-devel] [PATCH v2 0/3] Guest Support for Diagnose 318

Collin Walling posted 3 patches 5 years, 4 months ago
Test checkpatch failed
Test docker-quick@centos7 passed
Test docker-clang@ubuntu passed
Test docker-mingw@fedora passed
Test asan passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1544135058-21380-1-git-send-email-walling@linux.ibm.com
hw/s390x/ipl.c                  |  3 +++
hw/s390x/s390-virtio-ccw.c      |  3 +++
hw/s390x/sclp.c                 |  2 ++
include/hw/s390x/sclp.h         |  2 ++
linux-headers/asm-s390/kvm.h    |  5 ++++
target/s390x/cpu.h              |  2 +-
target/s390x/cpu_features.c     |  3 +++
target/s390x/cpu_features.h     |  1 +
target/s390x/cpu_features_def.h |  3 +++
target/s390x/diag.c             | 52 +++++++++++++++++++++++++++++++++++++++++
target/s390x/gen-features.c     |  1 +
target/s390x/internal.h         |  4 +++-
target/s390x/kvm-stub.c         | 10 ++++++++
target/s390x/kvm.c              | 23 ++++++++++++++++++
target/s390x/kvm_s390x.h        |  2 ++
15 files changed, 114 insertions(+), 2 deletions(-)
[Qemu-devel] [PATCH v2 0/3] Guest Support for Diagnose 318
Posted by Collin Walling 5 years, 4 months ago
Changelog:

    RFC -> v1
        - introduced kvm stubs for set/get cpc
        - s/fac134/byte_134
        - moved diag318 vmstate description to diag.c
        - reduced S390_VCPU_MAX to 247

     v1 -> v2
        - split patches into header sync, cpu model feat, and diag migration / reset
        - tiny cleanups

Collin Walling (3):
  s390: linux header sync for diag318
  s390: cpu feature for diagnose 318 andlimit max VCPUs to 247
  s390: migration and reset support for diagnose 318

 hw/s390x/ipl.c                  |  3 +++
 hw/s390x/s390-virtio-ccw.c      |  3 +++
 hw/s390x/sclp.c                 |  2 ++
 include/hw/s390x/sclp.h         |  2 ++
 linux-headers/asm-s390/kvm.h    |  5 ++++
 target/s390x/cpu.h              |  2 +-
 target/s390x/cpu_features.c     |  3 +++
 target/s390x/cpu_features.h     |  1 +
 target/s390x/cpu_features_def.h |  3 +++
 target/s390x/diag.c             | 52 +++++++++++++++++++++++++++++++++++++++++
 target/s390x/gen-features.c     |  1 +
 target/s390x/internal.h         |  4 +++-
 target/s390x/kvm-stub.c         | 10 ++++++++
 target/s390x/kvm.c              | 23 ++++++++++++++++++
 target/s390x/kvm_s390x.h        |  2 ++
 15 files changed, 114 insertions(+), 2 deletions(-)

-- 
2.7.4


Re: [Qemu-devel] [PATCH v2 0/3] Guest Support for Diagnose 318
Posted by no-reply@patchew.org 5 years, 4 months ago
Patchew URL: https://patchew.org/QEMU/1544135058-21380-1-git-send-email-walling@linux.ibm.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Subject: [Qemu-devel] [PATCH v2 0/3] Guest Support for Diagnose 318
Message-id: 1544135058-21380-1-git-send-email-walling@linux.ibm.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
5a34ba6 s390: migration and reset support for diagnose 318
744ef90 s390: cpu feature for diagnose 318 andlimit max VCPUs to 247
4205e50 s390: linux header sync for diagnose 318

=== OUTPUT BEGIN ===
Checking PATCH 1/3: s390: linux header sync for diagnose 318...
Checking PATCH 2/3: s390: cpu feature for diagnose 318 andlimit max VCPUs to 247...
Checking PATCH 3/3: s390: migration and reset support for diagnose 318...
ERROR: adding a line without newline at end of file
#169: FILE: target/s390x/kvm-stub.c:116:
+}

total: 1 errors, 0 warnings, 159 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1544135058-21380-1-git-send-email-walling@linux.ibm.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com