[v3] hw: vmmouse: use link property instead of DEFINE_PROP_PTR

[Qemu-devel] [PATCH v3 0/2] hw: vmmouse: use link property instead of DEFINE_PROP_PTR

Li Qiang posted 2 patches 5 years, 4 months ago

Diff against v1 v2
Download series mbox

Test asan passed

Test checkpatch passed

Test docker-quick@centos7 passed

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1543467132-2873-1-git-send-email-liq3ea@gmail.com

hw/i386/pc.c         |  9 +++++----
hw/i386/vmmouse.c    | 18 +++++++++++-------
include/hw/i386/pc.h |  3 +++
3 files changed, 19 insertions(+), 11 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH v3 0/2] hw: vmmouse: use link property instead of DEFINE_PROP_PTR

Posted by Li Qiang 5 years, 4 months ago

According https://wiki.qemu.org/Contribute/BiteSizedTasks
the 'DEFINE_PROP_PTR' should be replaced by QOM link property.
The first patch replace constant strings with TYPE_XXXX and move some
definition to pc.h header file so that the second patch can work.

Change since v2: detail commit message
Change since v1: fix some issues per Markus' review

Li Qiang (2):
  hw: pc: use TYPE_XXX instead of constant strings
  hw: vmmouse: Use link instead of pointer property

 hw/i386/pc.c         |  9 +++++----
 hw/i386/vmmouse.c    | 18 +++++++++++-------
 include/hw/i386/pc.h |  3 +++
 3 files changed, 19 insertions(+), 11 deletions(-)

-- 
2.11.0

Re: [Qemu-devel] [PATCH v3 0/2] hw: vmmouse: use link property instead of DEFINE_PROP_PTR

Posted by Li Qiang 5 years, 4 months ago

Ping....Paolo, could these patches go to your misc tree?

Thanks,
Li Qiang

Li Qiang <liq3ea@gmail.com> 于2018年11月29日周四 下午12:53写道：

> According https://wiki.qemu.org/Contribute/BiteSizedTasks
> the 'DEFINE_PROP_PTR' should be replaced by QOM link property.
> The first patch replace constant strings with TYPE_XXXX and move some
> definition to pc.h header file so that the second patch can work.
>
> Change since v2: detail commit message
> Change since v1: fix some issues per Markus' review
>
> Li Qiang (2):
>   hw: pc: use TYPE_XXX instead of constant strings
>   hw: vmmouse: Use link instead of pointer property
>
>  hw/i386/pc.c         |  9 +++++----
>  hw/i386/vmmouse.c    | 18 +++++++++++-------
>  include/hw/i386/pc.h |  3 +++
>  3 files changed, 19 insertions(+), 11 deletions(-)
>
> --
> 2.11.0
>
>

Re: [Qemu-devel] [PATCH v3 0/2] hw: vmmouse: use link property instead of DEFINE_PROP_PTR

Posted by Michael S. Tsirkin 5 years, 4 months ago

On Mon, Dec 17, 2018 at 09:10:06AM +0800, Li Qiang wrote:
> Ping....Paolo, could these patches go to your misc tree?
> 
> Thanks,
> Li Qiang


Fine by me

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

> Li Qiang <liq3ea@gmail.com> 于2018年11月29日周四下午12:53写道：
> 
>     According https://wiki.qemu.org/Contribute/BiteSizedTasks
>     the 'DEFINE_PROP_PTR' should be replaced by QOM link property.
>     The first patch replace constant strings with TYPE_XXXX and move some
>     definition to pc.h header file so that the second patch can work.
> 
>     Change since v2: detail commit message
>     Change since v1: fix some issues per Markus' review
> 
>     Li Qiang (2):
>       hw: pc: use TYPE_XXX instead of constant strings
>       hw: vmmouse: Use link instead of pointer property
> 
>      hw/i386/pc.c         |  9 +++++----
>      hw/i386/vmmouse.c    | 18 +++++++++++-------
>      include/hw/i386/pc.h |  3 +++
>      3 files changed, 19 insertions(+), 11 deletions(-)
> 
>     --
>     2.11.0
> 
>