[v2] fw_cfg: fix boot bootsplash and reboot-timeout error checking

[Qemu-devel] [PATCH v2 0/3] fw_cfg: fix boot bootsplash and reboot-timeout error checking

Li Qiang posted 3 patches 5 years, 4 months ago

Diff against v1
Download series mbox

Test asan passed

Test checkpatch passed

Test docker-quick@centos7 passed

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1542777026-2788-1-git-send-email-liq3ea@gmail.com

hw/nvram/fw_cfg.c       | 63 +++++++++++++++++++++----------------------------
include/sysemu/sysemu.h |  1 -
vl.c                    |  4 ++--
3 files changed, 29 insertions(+), 39 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH v2 0/3] fw_cfg: fix boot bootsplash and reboot-timeout error checking

Posted by Li Qiang 5 years, 4 months ago

And also do some code cleanup.
A lot of thanks to Markus's review and advice.

v2: fix some small issue per Markus's review.

Li Qiang (3):
  fw_cfg: fix -boot bootsplash error checking
  fw_cfg: fix -boot reboot-timeout error checking
  fw_cfg: make qemu_extra_params_fw locally

 hw/nvram/fw_cfg.c       | 63 +++++++++++++++++++++----------------------------
 include/sysemu/sysemu.h |  1 -
 vl.c                    |  4 ++--
 3 files changed, 29 insertions(+), 39 deletions(-)

-- 
2.11.0

Re: [Qemu-devel] [PATCH v2 0/3] fw_cfg: fix boot bootsplash and reboot-timeout error checking

Posted by Gerd Hoffmann 5 years, 4 months ago

On Tue, Nov 20, 2018 at 09:10:23PM -0800, Li Qiang wrote:
> And also do some code cleanup.
> A lot of thanks to Markus's review and advice.
> 
> v2: fix some small issue per Markus's review.
> 
> Li Qiang (3):
>   fw_cfg: fix -boot bootsplash error checking
>   fw_cfg: fix -boot reboot-timeout error checking
>   fw_cfg: make qemu_extra_params_fw locally

Series is
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>

Re: [Qemu-devel] [PATCH v2 0/3] fw_cfg: fix boot bootsplash and reboot-timeout error checking

Posted by Philippe Mathieu-Daudé 5 years, 4 months ago

On 11/21/18 6:10 AM, Li Qiang wrote:
> And also do some code cleanup.
> A lot of thanks to Markus's review and advice.
> 
> v2: fix some small issue per Markus's review.
> 
> Li Qiang (3):
>   fw_cfg: fix -boot bootsplash error checking
>   fw_cfg: fix -boot reboot-timeout error checking
>   fw_cfg: make qemu_extra_params_fw locally
> 
>  hw/nvram/fw_cfg.c       | 63 +++++++++++++++++++++----------------------------
>  include/sysemu/sysemu.h |  1 -
>  vl.c                    |  4 ++--
>  3 files changed, 29 insertions(+), 39 deletions(-)
> 

Thanks, I've queued this series for when 4.0 opens up.

Regards,

Phil.