target/mips: Add two missing breaks for NM_LLWPE and NM_SCWPE decoder cases

[Qemu-devel] [PATCH] target/mips: Add two missing breaks for NM_LLWPE and NM_SCWPE decoder cases

Aleksandar Markovic posted 1 patch 7 years ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1540811730-15660-1-git-send-email-aleksandar.markovic@rt-rk.com

Test docker-clang@ubuntu passed

Test checkpatch passed

Test asan passed

Test docker-quick@centos7 passed

target/mips/translate.c | 2 ++
1 file changed, 2 insertions(+)

Expand all Fold all

[Qemu-devel] [PATCH] target/mips: Add two missing breaks for NM_LLWPE and NM_SCWPE decoder cases

Posted by Aleksandar Markovic 7 years ago

From: Aleksandar Markovic <amarkovic@wavecomp.com>

Coverity found two fallthroughs that lack break statements. Fix them.

Signed-off-by: Aleksandar Markovic <amarkovic@wavecomp.com>
---
 target/mips/translate.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/target/mips/translate.c b/target/mips/translate.c
index b8ace0b..813ad19 100644
--- a/target/mips/translate.c
+++ b/target/mips/translate.c
@@ -21402,6 +21402,7 @@ static int decode_nanomips_32_48_opc(CPUMIPSState *env, DisasContext *ctx)
                         check_eva(ctx);
                         check_cp0_enabled(ctx);
                         gen_llwp(ctx, rs, 0, rt, extract32(ctx->opcode, 3, 5));
+                        break;
                     default:
                         generate_exception_end(ctx, EXCP_RI);
                         break;
@@ -21420,6 +21421,7 @@ static int decode_nanomips_32_48_opc(CPUMIPSState *env, DisasContext *ctx)
                         check_eva(ctx);
                         check_cp0_enabled(ctx);
                         gen_scwp(ctx, rs, 0, rt, extract32(ctx->opcode, 3, 5));
+                        break;
                     default:
                         generate_exception_end(ctx, EXCP_RI);
                         break;
-- 
2.7.4

Re: [Qemu-devel] [PATCH] target/mips: Add two missing breaks for NM_LLWPE and NM_SCWPE decoder cases

Posted by Stefan Markovic 7 years ago

On 29.10.18. 12:15, Aleksandar Markovic wrote:
> From: Aleksandar Markovic <amarkovic@wavecomp.com>
>
> Coverity found two fallthroughs that lack break statements. Fix them.
>
> Signed-off-by: Aleksandar Markovic <amarkovic@wavecomp.com>
> ---
>   target/mips/translate.c | 2 ++
>   1 file changed, 2 insertions(+)


Reviewed-by: Stefan Markovic <smarkovic@wavecomp.com>


> diff --git a/target/mips/translate.c b/target/mips/translate.c
> index b8ace0b..813ad19 100644
> --- a/target/mips/translate.c
> +++ b/target/mips/translate.c
> @@ -21402,6 +21402,7 @@ static int decode_nanomips_32_48_opc(CPUMIPSState *env, DisasContext *ctx)
>                           check_eva(ctx);
>                           check_cp0_enabled(ctx);
>                           gen_llwp(ctx, rs, 0, rt, extract32(ctx->opcode, 3, 5));
> +                        break;
>                       default:
>                           generate_exception_end(ctx, EXCP_RI);
>                           break;
> @@ -21420,6 +21421,7 @@ static int decode_nanomips_32_48_opc(CPUMIPSState *env, DisasContext *ctx)
>                           check_eva(ctx);
>                           check_cp0_enabled(ctx);
>                           gen_scwp(ctx, rs, 0, rt, extract32(ctx->opcode, 3, 5));
> +                        break;
>                       default:
>                           generate_exception_end(ctx, EXCP_RI);
>                           break;