[Qemu-devel] [PATCH 0/7] vfio: some trivial fixes

Li Qiang posted 7 patches 5 years, 6 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1539926412-21831-1-git-send-email-liq3ea@gmail.com
Test docker-clang@ubuntu passed
Test checkpatch passed
Test asan passed
Test docker-mingw@fedora failed
Test docker-quick@centos7 passed
hw/s390x/ap-device.c         |  2 +-
hw/vfio/amd-xgbe.c           |  2 +-
hw/vfio/ap.c                 | 12 ++++++------
hw/vfio/calxeda-xgmac.c      |  2 +-
hw/vfio/ccw.c                |  2 +-
hw/vfio/pci.c                |  6 ++++--
hw/vfio/platform.c           | 12 ++++++++----
include/hw/s390x/ap-device.h |  4 ++--
8 files changed, 24 insertions(+), 18 deletions(-)
[Qemu-devel] [PATCH 0/7] vfio: some trivial fixes
Posted by Li Qiang 5 years, 6 months ago
This patch set contains some trivial issue such as
QOMConvetion, typo and resources leak in vfio.

Li Qiang (7):
  vfio-pci: make "vfio-pci-nohotplug" as MACRO
  vfio: ap-device: make it more QOMConventional
  vfio: drop TYPE_FOO MACRO in VMStateDescription
  vfio: paltform: fix a typo
  vfio: platform: cleanup the notifier in error path
  vfio: platform: free timer in error path
  vfio: platform: destory mutex in error path

 hw/s390x/ap-device.c         |  2 +-
 hw/vfio/amd-xgbe.c           |  2 +-
 hw/vfio/ap.c                 | 12 ++++++------
 hw/vfio/calxeda-xgmac.c      |  2 +-
 hw/vfio/ccw.c                |  2 +-
 hw/vfio/pci.c                |  6 ++++--
 hw/vfio/platform.c           | 12 ++++++++----
 include/hw/s390x/ap-device.h |  4 ++--
 8 files changed, 24 insertions(+), 18 deletions(-)

-- 
1.8.3.1


Re: [Qemu-devel] [PATCH 0/7] vfio: some trivial fixes
Posted by Philippe Mathieu-Daudé 5 years, 6 months ago
On 19/10/2018 07:20, Li Qiang wrote:
> This patch set contains some trivial issue such as
> QOMConvetion, typo and resources leak in vfio.
> 
> Li Qiang (7):
>   vfio-pci: make "vfio-pci-nohotplug" as MACRO
>   vfio: ap-device: make it more QOMConventional
>   vfio: drop TYPE_FOO MACRO in VMStateDescription
>   vfio: paltform: fix a typo

For patches 1-4 that are indeed trivial:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

>   vfio: platform: cleanup the notifier in error path
>   vfio: platform: free timer in error path
>   vfio: platform: destory mutex in error path

Those are less trivial ;)

> 
>  hw/s390x/ap-device.c         |  2 +-
>  hw/vfio/amd-xgbe.c           |  2 +-
>  hw/vfio/ap.c                 | 12 ++++++------
>  hw/vfio/calxeda-xgmac.c      |  2 +-
>  hw/vfio/ccw.c                |  2 +-
>  hw/vfio/pci.c                |  6 ++++--
>  hw/vfio/platform.c           | 12 ++++++++----
>  include/hw/s390x/ap-device.h |  4 ++--
>  8 files changed, 24 insertions(+), 18 deletions(-)
>