tests: docker: update test-mingw for GTK+ 2.0 removal

[Qemu-devel] [PATCH] tests: docker: update test-mingw for GTK+ 2.0 removal

Posted by Paolo Bonzini 5 years, 6 months ago

--with-gtkabi does not exist anymore; remove it from the configure invocation.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 tests/docker/test-mingw | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/docker/test-mingw b/tests/docker/test-mingw
index 7cca7e1..b078f22 100755
--- a/tests/docker/test-mingw
+++ b/tests/docker/test-mingw
@@ -28,8 +28,7 @@ for prefix in x86_64-w64-mingw32- i686-w64-mingw32-; do
         --enable-vnc \
         --enable-bzip2 \
         --enable-guest-agent \
-        --with-sdlabi=2.0 \
-        --with-gtkabi=3.0
+        --with-sdlabi=2.0
     install_qemu
     make clean
 
-- 
1.8.3.1

Re: [Qemu-devel] [PATCH] tests: docker: update test-mingw for GTK+ 2.0 removal

Posted by Thomas Huth 5 years, 6 months ago

On 2018-10-18 20:10, Paolo Bonzini wrote:
> --with-gtkabi does not exist anymore; remove it from the configure invocation.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  tests/docker/test-mingw | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/tests/docker/test-mingw b/tests/docker/test-mingw
> index 7cca7e1..b078f22 100755
> --- a/tests/docker/test-mingw
> +++ b/tests/docker/test-mingw
> @@ -28,8 +28,7 @@ for prefix in x86_64-w64-mingw32- i686-w64-mingw32-; do
>          --enable-vnc \
>          --enable-bzip2 \
>          --enable-guest-agent \
> -        --with-sdlabi=2.0 \
> -        --with-gtkabi=3.0
> +        --with-sdlabi=2.0
>      install_qemu
>      make clean
>  
> 

Fixes: 89d85cde75143325205e332dd97bf1bb8402d7c1

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [Qemu-devel] [PATCH] tests: docker: update test-mingw for GTK+ 2.0 removal

Posted by Philippe Mathieu-Daudé 5 years, 6 months ago

On 18/10/2018 20:10, Paolo Bonzini wrote:
> --with-gtkabi does not exist anymore; remove it from the configure invocation.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  tests/docker/test-mingw | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/tests/docker/test-mingw b/tests/docker/test-mingw
> index 7cca7e1..b078f22 100755
> --- a/tests/docker/test-mingw
> +++ b/tests/docker/test-mingw
> @@ -28,8 +28,7 @@ for prefix in x86_64-w64-mingw32- i686-w64-mingw32-; do
>          --enable-vnc \
>          --enable-bzip2 \
>          --enable-guest-agent \
> -        --with-sdlabi=2.0 \
> -        --with-gtkabi=3.0
> +        --with-sdlabi=2.0
>      install_qemu
>      make clean
>  
> 

$ ./configure ...
C compiler        i686-w64-mingw32.shared-gcc
SDL support       yes (2.0.5)
GTK support       no
GTK GL support    no
mingw32 support   yes

$ make
...
  LINK    arm-softmmu/qemu-system-armw.exe
  GEN     arm-softmmu/qemu-system-arm.exe

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Re: [Qemu-devel] [PATCH] tests: docker: update test-mingw for GTK+ 2.0 removal

Posted by Fam Zheng 5 years, 6 months ago

On Thu, 10/18 20:10, Paolo Bonzini wrote:
> --with-gtkabi does not exist anymore; remove it from the configure invocation.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  tests/docker/test-mingw | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/tests/docker/test-mingw b/tests/docker/test-mingw
> index 7cca7e1..b078f22 100755
> --- a/tests/docker/test-mingw
> +++ b/tests/docker/test-mingw
> @@ -28,8 +28,7 @@ for prefix in x86_64-w64-mingw32- i686-w64-mingw32-; do
>          --enable-vnc \
>          --enable-bzip2 \
>          --enable-guest-agent \
> -        --with-sdlabi=2.0 \
> -        --with-gtkabi=3.0
> +        --with-sdlabi=2.0
>      install_qemu
>      make clean
>  
> -- 
> 1.8.3.1
> 

Queued, thanks.

Fam