Signed-off-by: Li Qiang <liq3ea@gmail.com>
---
include/exec/memory.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/exec/memory.h b/include/exec/memory.h
index 3a427aa..1fbbdaf 100644
--- a/include/exec/memory.h
+++ b/include/exec/memory.h
@@ -935,7 +935,7 @@ uint64_t memory_region_size(MemoryRegion *mr);
/**
* memory_region_is_ram: check whether a memory region is random access
*
- * Returns %true is a memory region is random access.
+ * Returns %true if a memory region is random access.
*
* @mr: the memory region being queried
*/
@@ -947,7 +947,7 @@ static inline bool memory_region_is_ram(MemoryRegion *mr)
/**
* memory_region_is_ram_device: check whether a memory region is a ram device
*
- * Returns %true is a memory region is a device backed ram region
+ * Returns %true if a memory region is a device backed ram region
*
* @mr: the memory region being queried
*/
@@ -1161,7 +1161,7 @@ uint8_t memory_region_get_dirty_log_mask(MemoryRegion *mr);
/**
* memory_region_is_rom: check whether a memory region is ROM
*
- * Returns %true is a memory region is read-only memory.
+ * Returns %true if a memory region is read-only memory.
*
* @mr: the memory region being queried
*/
--
1.8.3.1
On 9 October 2018 at 11:21, Li Qiang <liq3ea@gmail.com> wrote: > Signed-off-by: Li Qiang <liq3ea@gmail.com> > --- > include/exec/memory.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Thanks. Contents of patch Reviewed-by: Peter Maydell <peter.maydell@linaro.org> but the commit message should say "fix typos", not "fix types" (a 'typo' is a typing mistake; a 'type' is something like "uint32_t".) thanks -- PMM
Peter Maydell <peter.maydell@linaro.org> 于2018年10月9日周二 下午6:26写道: > On 9 October 2018 at 11:21, Li Qiang <liq3ea@gmail.com> wrote: > > Signed-off-by: Li Qiang <liq3ea@gmail.com> > > --- > > include/exec/memory.h | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > Thanks. Contents of patch > Reviewed-by: Peter Maydell <peter.maydell@linaro.org> > > but the commit message should say "fix typos", not "fix types" > (a 'typo' is a typing mistake; a 'type' is something like "uint32_t".) > > Indeed, hope the maintainer can fix this typo when queuing this patch, :) In additon, Cc: qemu-trivial@nongnu.org > > thanks > -- PMM >
On 09/10/2018 11:37, Li Qiang wrote: > > > Peter Maydell <peter.maydell@linaro.org > <mailto:peter.maydell@linaro.org>> 于2018年10月9日周二 下午6:26写道: > > On 9 October 2018 at 11:21, Li Qiang <liq3ea@gmail.com > <mailto:liq3ea@gmail.com>> wrote: > > Signed-off-by: Li Qiang <liq3ea@gmail.com <mailto:liq3ea@gmail.com>> > > --- > > include/exec/memory.h | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > Thanks. Contents of patch > Reviewed-by: Peter Maydell <peter.maydell@linaro.org > <mailto:peter.maydell@linaro.org>> > > but the commit message should say "fix typos", not "fix types" > (a 'typo' is a typing mistake; a 'type' is something like "uint32_t".) > > > Indeed, hope the maintainer can fix this typo when queuing this patch, :) > > In additon, Cc: qemu-trivial@nongnu.org <mailto:qemu-trivial@nongnu.org> > Applied to qemu-trivial branch Thanks, Laurent
© 2016 - 2025 Red Hat, Inc.