Rom: change Rom's 'isrom' to bool type

[Qemu-devel] [PATCH] Rom: change Rom's 'isrom' to bool type

Li Qiang posted 1 patch 7 years ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1539068913-3796-1-git-send-email-liq3ea@gmail.com

Test docker-clang@ubuntu failed

Test checkpatch passed

hw/core/loader.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[Qemu-devel] [PATCH] Rom: change Rom's 'isrom' to bool type

Posted by Li Qiang 7 years ago

Signed-off-by: Li Qiang <liq3ea@gmail.com>
---
 hw/core/loader.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/core/loader.c b/hw/core/loader.c
index aa0b3fc867..910f9a97a9 100644
--- a/hw/core/loader.c
+++ b/hw/core/loader.c
@@ -837,7 +837,7 @@ struct Rom {
     uint8_t *data;
     MemoryRegion *mr;
     AddressSpace *as;
-    int isrom;
+    bool isrom;
     char *fw_dir;
     char *fw_file;
 
-- 
2.11.0

Re: [Qemu-devel] [PATCH] Rom: change Rom's 'isrom' to bool type

Posted by Philippe Mathieu-Daudé 7 years ago

On 09/10/2018 09:08, Li Qiang wrote:
> Signed-off-by: Li Qiang <liq3ea@gmail.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>  hw/core/loader.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/core/loader.c b/hw/core/loader.c
> index aa0b3fc867..910f9a97a9 100644
> --- a/hw/core/loader.c
> +++ b/hw/core/loader.c
> @@ -837,7 +837,7 @@ struct Rom {
>      uint8_t *data;
>      MemoryRegion *mr;
>      AddressSpace *as;
> -    int isrom;
> +    bool isrom;
>      char *fw_dir;
>      char *fw_file;
>  
>