[v2] Fix migration problems of s390x guests on Sparc hosts

[Qemu-devel] [PATCH v2 0/3] Fix migration problems of s390x guests on Sparc hosts

Thomas Huth posted 3 patches 5 years, 7 months ago

Diff against v1 v3
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1537947527-3336-1-git-send-email-thuth@redhat.com

Test docker-clang@ubuntu failed

Test checkpatch passed

There is a newer version of this series

hw/s390x/css.c            | 33 +++++++++++++++++----------------
hw/s390x/ipl.h            |  5 +++--
include/hw/s390x/css.h    |  6 +++---
include/hw/s390x/ioinst.h | 21 ++++++++++++++-------
4 files changed, 37 insertions(+), 28 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH v2 0/3] Fix migration problems of s390x guests on Sparc hosts

Posted by Thomas Huth 5 years, 7 months ago

The new migration test uncovered some alignment problems in the s390x
code:

https://lists.gnu.org/archive/html/qemu-devel/2018-09/msg03012.html

Here are some patches to fix these issues (only tested with
clang and -fsanitize=undefined, since I do not have access to
a Sparc machine, but I hope that covers the issues there, too).

v2:
 - Use static assert with offsetof in the first patch instead of comments
 - Use stw_be_p in the second patch and add a comment about SA22-7204

Thomas Huth (3):
  hw/s390x/ipl: Fix alignment problems of S390IPLState members
  hw/s390x/css: Remove QEMU_PACKED from struct SenseId
  hw/s390x/ioinst: Fix alignment problem in struct SubchDev

 hw/s390x/css.c            | 33 +++++++++++++++++----------------
 hw/s390x/ipl.h            |  5 +++--
 include/hw/s390x/css.h    |  6 +++---
 include/hw/s390x/ioinst.h | 21 ++++++++++++++-------
 4 files changed, 37 insertions(+), 28 deletions(-)

-- 
1.8.3.1