[Qemu-devel] [PATCH 0/3] Re-enable wdt_ib700, endianness and vmxnet3 tests

Thomas Huth posted 3 patches 7 years, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1537774933-20679-1-git-send-email-thuth@redhat.com
Test docker-clang@ubuntu failed
Test checkpatch passed
tests/Makefile.include | 22 +++++++++++++++++-----
1 file changed, 17 insertions(+), 5 deletions(-)
[Qemu-devel] [PATCH 0/3] Re-enable wdt_ib700, endianness and vmxnet3 tests
Posted by Thomas Huth 7 years, 1 month ago
The recent clean-up in the tests/Makefile.include file disabled some
tests accidentally: Adding tests directly to check-qtest-y does not
work since the variable is overwritten at the end of the file again.
Also the Makefile is only included once and not per target architecture,
so adding the tests to a generic variable can not work here. We've got
to keep the tests in the architecture specific variables instead.
When the qgraph patches have been merged, there will be a better way to
do this, but until then let's simply revert the patches to fix this issue.

Thomas Huth (3):
  Revert "check: Move wdt_ib700 test to common"
  Revert "check: Move endianess test to common"
  Revert "check: Move VMXNET3 test to common"

 tests/Makefile.include | 22 +++++++++++++++++-----
 1 file changed, 17 insertions(+), 5 deletions(-)

-- 
1.8.3.1


Re: [Qemu-devel] [PATCH 0/3] Re-enable wdt_ib700, endianness and vmxnet3 tests
Posted by Paolo Bonzini 7 years, 1 month ago
On 24/09/2018 09:42, Thomas Huth wrote:
> The recent clean-up in the tests/Makefile.include file disabled some
> tests accidentally: Adding tests directly to check-qtest-y does not
> work since the variable is overwritten at the end of the file again.
> Also the Makefile is only included once and not per target architecture,
> so adding the tests to a generic variable can not work here. We've got
> to keep the tests in the architecture specific variables instead.
> When the qgraph patches have been merged, there will be a better way to
> do this, but until then let's simply revert the patches to fix this issue.

Queued, thanks.

Paolo