1. Patchew
  2. QEMU
  3. View series

[Qemu-devel] [PATCH] tests/migration: Speed up the test on ppc64

Thomas Huth posted 1 patch 7 years, 1 month ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1537204330-16076-1-git-send-email-thuth@redhat.com
Test docker-clang@ubuntu failed
Test checkpatch passed
tests/migration-test.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
[Qemu-devel] [PATCH] tests/migration: Speed up the test on ppc64
Posted by Thomas Huth 7 years, 1 month ago 
The SLOF boot process is always quite slow ... but we can speed it up
a little bit by specifying "-nodefaults" and by using the "nvramrc"
variable instead of "boot-command" (since "nvramrc" is evaluated earlier
in the SLOF boot process than "boot-command").

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/migration-test.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/migration-test.c b/tests/migration-test.c
index 0e687b7..967e3d0 100644
--- a/tests/migration-test.c
+++ b/tests/migration-test.c
@@ -438,11 +438,11 @@ static int test_migrate_start(QTestState **from, QTestState **to,
                                   " -incoming %s",
                                   accel, tmpfs, bootpath, uri);
     } else if (strcmp(arch, "ppc64") == 0) {
-        cmd_src = g_strdup_printf("-machine accel=%s -m 256M"
+        cmd_src = g_strdup_printf("-machine accel=%s -m 256M -nodefaults"
                                   " -name source,debug-threads=on"
                                   " -serial file:%s/src_serial"
-                                  " -prom-env '"
-                                  "boot-command=hex .\" _\" begin %x %x "
+                                  " -prom-env 'use-nvramrc?=true' -prom-env "
+                                  "'nvramrc=hex .\" _\" begin %x %x "
                                   "do i c@ 1 + i c! 1000 +loop .\" B\" 0 "
                                   "until'",  accel, tmpfs, end_address,
                                   start_address);
-- 
1.8.3.1
Re: [Qemu-devel] [PATCH] tests/migration: Speed up the test on ppc64
Posted by Dr. David Alan Gilbert 7 years, 1 month ago 
* Thomas Huth (thuth@redhat.com) wrote:
> The SLOF boot process is always quite slow ... but we can speed it up
> a little bit by specifying "-nodefaults" and by using the "nvramrc"
> variable instead of "boot-command" (since "nvramrc" is evaluated earlier
> in the SLOF boot process than "boot-command").
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Queued

> ---
>  tests/migration-test.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/migration-test.c b/tests/migration-test.c
> index 0e687b7..967e3d0 100644
> --- a/tests/migration-test.c
> +++ b/tests/migration-test.c
> @@ -438,11 +438,11 @@ static int test_migrate_start(QTestState **from, QTestState **to,
>                                    " -incoming %s",
>                                    accel, tmpfs, bootpath, uri);
>      } else if (strcmp(arch, "ppc64") == 0) {
> -        cmd_src = g_strdup_printf("-machine accel=%s -m 256M"
> +        cmd_src = g_strdup_printf("-machine accel=%s -m 256M -nodefaults"
>                                    " -name source,debug-threads=on"
>                                    " -serial file:%s/src_serial"
> -                                  " -prom-env '"
> -                                  "boot-command=hex .\" _\" begin %x %x "
> +                                  " -prom-env 'use-nvramrc?=true' -prom-env "
> +                                  "'nvramrc=hex .\" _\" begin %x %x "
>                                    "do i c@ 1 + i c! 1000 +loop .\" B\" 0 "
>                                    "until'",  accel, tmpfs, end_address,
>                                    start_address);
> -- 
> 1.8.3.1
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
Re: [Qemu-devel] [PATCH] tests/migration: Speed up the test on ppc64
Posted by Dr. David Alan Gilbert 7 years, 1 month ago 
* Thomas Huth (thuth@redhat.com) wrote:
> The SLOF boot process is always quite slow ... but we can speed it up
> a little bit by specifying "-nodefaults" and by using the "nvramrc"
> variable instead of "boot-command" (since "nvramrc" is evaluated earlier
> in the SLOF boot process than "boot-command").
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

> ---
>  tests/migration-test.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/migration-test.c b/tests/migration-test.c
> index 0e687b7..967e3d0 100644
> --- a/tests/migration-test.c
> +++ b/tests/migration-test.c
> @@ -438,11 +438,11 @@ static int test_migrate_start(QTestState **from, QTestState **to,
>                                    " -incoming %s",
>                                    accel, tmpfs, bootpath, uri);
>      } else if (strcmp(arch, "ppc64") == 0) {
> -        cmd_src = g_strdup_printf("-machine accel=%s -m 256M"
> +        cmd_src = g_strdup_printf("-machine accel=%s -m 256M -nodefaults"
>                                    " -name source,debug-threads=on"
>                                    " -serial file:%s/src_serial"
> -                                  " -prom-env '"
> -                                  "boot-command=hex .\" _\" begin %x %x "
> +                                  " -prom-env 'use-nvramrc?=true' -prom-env "
> +                                  "'nvramrc=hex .\" _\" begin %x %x "
>                                    "do i c@ 1 + i c! 1000 +loop .\" B\" 0 "
>                                    "until'",  accel, tmpfs, end_address,
>                                    start_address);
> -- 
> 1.8.3.1
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
Re: [Qemu-devel] [PATCH] tests/migration: Speed up the test on ppc64
Posted by Laurent Vivier 7 years, 1 month ago 
On 17/09/2018 19:12, Thomas Huth wrote:
> The SLOF boot process is always quite slow ... but we can speed it up
> a little bit by specifying "-nodefaults" and by using the "nvramrc"
> variable instead of "boot-command" (since "nvramrc" is evaluated earlier
> in the SLOF boot process than "boot-command").
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  tests/migration-test.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/migration-test.c b/tests/migration-test.c
> index 0e687b7..967e3d0 100644
> --- a/tests/migration-test.c
> +++ b/tests/migration-test.c
> @@ -438,11 +438,11 @@ static int test_migrate_start(QTestState **from, QTestState **to,
>                                    " -incoming %s",
>                                    accel, tmpfs, bootpath, uri);
>      } else if (strcmp(arch, "ppc64") == 0) {
> -        cmd_src = g_strdup_printf("-machine accel=%s -m 256M"
> +        cmd_src = g_strdup_printf("-machine accel=%s -m 256M -nodefaults"
>                                    " -name source,debug-threads=on"
>                                    " -serial file:%s/src_serial"
> -                                  " -prom-env '"
> -                                  "boot-command=hex .\" _\" begin %x %x "
> +                                  " -prom-env 'use-nvramrc?=true' -prom-env "
> +                                  "'nvramrc=hex .\" _\" begin %x %x "
>                                    "do i c@ 1 + i c! 1000 +loop .\" B\" 0 "
>                                    "until'",  accel, tmpfs, end_address,
>                                    start_address);
> 

Reviewed-by: Laurent Vivier <lvivier@redhat.com>

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.