qom: fix comments for object_property_set_qobject function

[Qemu-devel] [PATCH] qom: fix comments for object_property_set_qobject function

Li Qiang posted 1 patch 7 years, 1 month ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1537152714-3162-1-git-send-email-liq3ea@gmail.com

Test docker-clang@ubuntu failed

Test checkpatch passed

include/qom/qom-qobject.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH] qom: fix comments for object_property_set_qobject function

Posted by Li Qiang 7 years, 1 month ago

Also make the definition and declare of this function's argument name
the same.

Signed-off-by: Li Qiang <liq3ea@gmail.com>
---
 include/qom/qom-qobject.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/qom/qom-qobject.h b/include/qom/qom-qobject.h
index 77cd717e3f..11803c6b57 100644
--- a/include/qom/qom-qobject.h
+++ b/include/qom/qom-qobject.h
@@ -30,13 +30,13 @@ struct QObject *object_property_get_qobject(Object *obj, const char *name,
 /**
  * object_property_set_qobject:
  * @obj: the object
- * @ret: The value that will be written to the property.
+ * @value: The value that will be written to the property.
  * @name: the name of the property
  * @errp: returns an error if this function fails
  *
  * Writes a property to a object.
  */
-void object_property_set_qobject(Object *obj, struct QObject *qobj,
+void object_property_set_qobject(Object *obj, struct QObject *value,
                                  const char *name, struct Error **errp);
 
 #endif
-- 
2.11.0

Re: [Qemu-devel] [PATCH] qom: fix comments for object_property_set_qobject function

Posted by Markus Armbruster 7 years, 1 month ago

Li Qiang <liq3ea@gmail.com> writes:

> Also make the definition and declare of this function's argument name
> the same.
>
> Signed-off-by: Li Qiang <liq3ea@gmail.com>
> ---
>  include/qom/qom-qobject.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/qom/qom-qobject.h b/include/qom/qom-qobject.h
> index 77cd717e3f..11803c6b57 100644
> --- a/include/qom/qom-qobject.h
> +++ b/include/qom/qom-qobject.h
> @@ -30,13 +30,13 @@ struct QObject *object_property_get_qobject(Object *obj, const char *name,
>  /**
>   * object_property_set_qobject:
>   * @obj: the object
> - * @ret: The value that will be written to the property.
> + * @value: The value that will be written to the property.
>   * @name: the name of the property
>   * @errp: returns an error if this function fails
>   *
>   * Writes a property to a object.
>   */
> -void object_property_set_qobject(Object *obj, struct QObject *qobj,
> +void object_property_set_qobject(Object *obj, struct QObject *value,
>                                   const char *name, struct Error **errp);
>  
>  #endif

Reviewed-by: Markus Armbruster <armbru@redhat.com>