hw: edu: replace device name with macro

[Qemu-devel] [PATCH] hw: edu: replace device name with macro

Li Qiang posted 1 patch 7 years, 1 month ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1536901871-2729-1-git-send-email-liq3ea@gmail.com

Test docker-clang@ubuntu failed

Test checkpatch passed

hw/misc/edu.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH] hw: edu: replace device name with macro

Posted by Li Qiang 7 years, 1 month ago

Just as other devices do.

Signed-off-by: Li Qiang <liq3ea@gmail.com>
---
 hw/misc/edu.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/hw/misc/edu.c b/hw/misc/edu.c
index df26a4d046..0687ffd343 100644
--- a/hw/misc/edu.c
+++ b/hw/misc/edu.c
@@ -30,7 +30,8 @@
 #include "qemu/main-loop.h" /* iothread mutex */
 #include "qapi/visitor.h"
 
-#define EDU(obj)        OBJECT_CHECK(EduState, obj, "edu")
+#define TYPE_PCI_EDU_DEVICE "edu"
+#define EDU(obj)        OBJECT_CHECK(EduState, obj, TYPE_PCI_EDU_DEVICE)
 
 #define FACT_IRQ        0x00000001
 #define DMA_IRQ         0x00000100
@@ -414,7 +415,7 @@ static void pci_edu_register_types(void)
         { },
     };
     static const TypeInfo edu_info = {
-        .name          = "edu",
+        .name          = TYPE_PCI_EDU_DEVICE,
         .parent        = TYPE_PCI_DEVICE,
         .instance_size = sizeof(EduState),
         .instance_init = edu_instance_init,
-- 
2.11.0

Re: [Qemu-devel] [PATCH] hw: edu: replace device name with macro

Posted by Paolo Bonzini 7 years, 1 month ago

On 14/09/2018 07:11, Li Qiang wrote:
> Just as other devices do.
> 
> Signed-off-by: Li Qiang <liq3ea@gmail.com>
> ---
>  hw/misc/edu.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/misc/edu.c b/hw/misc/edu.c
> index df26a4d046..0687ffd343 100644
> --- a/hw/misc/edu.c
> +++ b/hw/misc/edu.c
> @@ -30,7 +30,8 @@
>  #include "qemu/main-loop.h" /* iothread mutex */
>  #include "qapi/visitor.h"
>  
> -#define EDU(obj)        OBJECT_CHECK(EduState, obj, "edu")
> +#define TYPE_PCI_EDU_DEVICE "edu"
> +#define EDU(obj)        OBJECT_CHECK(EduState, obj, TYPE_PCI_EDU_DEVICE)
>  
>  #define FACT_IRQ        0x00000001
>  #define DMA_IRQ         0x00000100
> @@ -414,7 +415,7 @@ static void pci_edu_register_types(void)
>          { },
>      };
>      static const TypeInfo edu_info = {
> -        .name          = "edu",
> +        .name          = TYPE_PCI_EDU_DEVICE,
>          .parent        = TYPE_PCI_DEVICE,
>          .instance_size = sizeof(EduState),
>          .instance_init = edu_instance_init,
> 

Queued, thanks.

Paolo