[v8] deprecate incorrect CPUs topolog

[Qemu-devel] [PATCH v8 0/2] deprecate incorrect CPUs topolog

Igor Mammedov posted 2 patches 7 years, 1 month ago

Diff against v7
Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1536836762-273036-1-git-send-email-imammedo@redhat.com

Test docker-clang@ubuntu failed

Test checkpatch passed

qemu-deprecated.texi | 12 ++++++++++++
vl.c                 | 12 +++++++++++-
2 files changed, 23 insertions(+), 1 deletion(-)

Expand all Fold all

[Qemu-devel] [PATCH v8 0/2] deprecate incorrect CPUs topolog

Posted by Igor Mammedov 7 years, 1 month ago

Changelog since v7:
  * drop repetitive sentence in deprication doc (Eric Blake <eblake@redhat.com>)
Changelog since v5:
  * add(v6) and then remove(v7) Notes section to/from deprication doc
     (Eduardo Habkost <ehabkost@redhat.com>)
  * fix up wording and math formating in deprication doc
     (Eduardo Habkost <ehabkost@redhat.com>)
  * drop !socket check as it always evaluates to true at that point
     (Eduardo Habkost <ehabkost@redhat.com>)
Changelog since v4:
  * extend deprication doc, adding that maxcpus should be multiple of
        present on CLI [sockets/cores/threads] options
        (Eduardo Habkost <ehabkost@redhat.com>)

series bundles together 2 related patches posted separately earlier:
  vl.c deprecate incorrect CPUs topology
  vl:c: make sure that sockets are calculated  correctly in '-smp X' case

Goal is to depricate invalid topologies so we could make sure that topology
configuration is correct by forbidding invalid input once deprecation
period ends.


CC: eblake@redhat.com
CC: ehabkost@redhat.com

Igor Mammedov (2):
  vl.c deprecate incorrect CPUs topology
  vl:c: make sure that sockets are calculated correctly in '-smp X' case

 qemu-deprecated.texi | 12 ++++++++++++
 vl.c                 | 12 +++++++++++-
 2 files changed, 23 insertions(+), 1 deletion(-)

-- 
2.7.4

Re: [Qemu-devel] [PATCH v8 0/2] deprecate incorrect CPUs topolog

Posted by Eduardo Habkost 7 years ago

On Thu, Sep 13, 2018 at 01:06:00PM +0200, Igor Mammedov wrote:
> Changelog since v7:
>   * drop repetitive sentence in deprication doc (Eric Blake <eblake@redhat.com>)
> Changelog since v5:
>   * add(v6) and then remove(v7) Notes section to/from deprication doc
>      (Eduardo Habkost <ehabkost@redhat.com>)
>   * fix up wording and math formating in deprication doc
>      (Eduardo Habkost <ehabkost@redhat.com>)
>   * drop !socket check as it always evaluates to true at that point
>      (Eduardo Habkost <ehabkost@redhat.com>)
> Changelog since v4:
>   * extend deprication doc, adding that maxcpus should be multiple of
>         present on CLI [sockets/cores/threads] options
>         (Eduardo Habkost <ehabkost@redhat.com>)
> 
> series bundles together 2 related patches posted separately earlier:
>   vl.c deprecate incorrect CPUs topology
>   vl:c: make sure that sockets are calculated  correctly in '-smp X' case
> 
> Goal is to depricate invalid topologies so we could make sure that topology
> configuration is correct by forbidding invalid input once deprecation
> period ends.

Thanks, queued on machine-next.

-- 
Eduardo