qdev: fix a typo in comment

[Qemu-devel] [PATCH] qdev: fix a typo in comment

Li Qiang posted 1 patch 7 years, 2 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1536130141-2742-1-git-send-email-liq3ea@gmail.com

Test docker-clang@ubuntu failed

Test checkpatch passed

hw/core/qdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[Qemu-devel] [PATCH] qdev: fix a typo in comment

Posted by Li Qiang 7 years, 2 months ago

Found by reading code.

Signed-off-by: Li Qiang <liq3ea@gmail.com>
---
 hw/core/qdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/core/qdev.c b/hw/core/qdev.c
index 529b82de18..7e4bfcb8f7 100644
--- a/hw/core/qdev.c
+++ b/hw/core/qdev.c
@@ -643,7 +643,7 @@ static void qdev_get_legacy_property(Object *obj, Visitor *v,
  * the string depends on the property type.  Legacy properties are only
  * needed for "info qtree".
  *
- * Do not use this is new code!  QOM Properties added through this interface
+ * Do not use this in new code!  QOM Properties added through this interface
  * will be given names in the "legacy" namespace.
  */
 static void qdev_property_add_legacy(DeviceState *dev, Property *prop,
-- 
2.11.0

Re: [Qemu-devel] [PATCH] qdev: fix a typo in comment

Posted by Markus Armbruster 7 years, 1 month ago

Could be merged via qemu-trivial (cc'ed).

Li Qiang <liq3ea@gmail.com> writes:

> Found by reading code.
>
> Signed-off-by: Li Qiang <liq3ea@gmail.com>
> ---
>  hw/core/qdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/core/qdev.c b/hw/core/qdev.c
> index 529b82de18..7e4bfcb8f7 100644
> --- a/hw/core/qdev.c
> +++ b/hw/core/qdev.c
> @@ -643,7 +643,7 @@ static void qdev_get_legacy_property(Object *obj, Visitor *v,
>   * the string depends on the property type.  Legacy properties are only
>   * needed for "info qtree".
>   *
> - * Do not use this is new code!  QOM Properties added through this interface
> + * Do not use this in new code!  QOM Properties added through this interface
>   * will be given names in the "legacy" namespace.
>   */
>  static void qdev_property_add_legacy(DeviceState *dev, Property *prop,