[Qemu-devel] [PATCH V5 3/4] target-i386: add rtc 0x70 port as coalesced_pio

Peng Hao posted 4 patches 7 years, 2 months ago
[Qemu-devel] [PATCH V5 3/4] target-i386: add rtc 0x70 port as coalesced_pio
Posted by Peng Hao 7 years, 2 months ago
Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
---
 hw/timer/mc146818rtc.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc.c
index 6f1f723..b19ef51 100644
--- a/hw/timer/mc146818rtc.c
+++ b/hw/timer/mc146818rtc.c
@@ -70,6 +70,7 @@ typedef struct RTCState {
     ISADevice parent_obj;
 
     MemoryRegion io;
+    MemoryRegion coalesced_io;
     uint8_t cmos_data[128];
     uint8_t cmos_index;
     int32_t base_year;
@@ -990,6 +991,13 @@ static void rtc_realizefn(DeviceState *dev, Error **errp)
     memory_region_init_io(&s->io, OBJECT(s), &cmos_ops, s, "rtc", 2);
     isa_register_ioport(isadev, &s->io, base);
 
+    /* register rtc 0x70 port as coalesced_pio */
+    memory_region_set_flush_coalesced(&s->io);
+    memory_region_init_io(&s->coalesced_io, OBJECT(s), &cmos_ops,
+                          s, "rtc1", 1);
+    isa_register_ioport(isadev, &s->coalesced_io, base);
+    memory_region_add_coalescing(&s->coalesced_io, 0, 1);
+
     qdev_set_legacy_instance_id(dev, base, 3);
     qemu_register_reset(rtc_reset, s);
 
-- 
1.8.3.1


Re: [Qemu-devel] [PATCH V5 3/4] target-i386: add rtc 0x70 port as coalesced_pio
Posted by Eduardo Habkost 7 years, 2 months ago
On Thu, Aug 30, 2018 at 11:50:15PM +0800, Peng Hao wrote:
> Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
> Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>

There has been a misunderstanding.  I never sent a Reviewed-by
line for this patch.

-- 
Eduardo