pci-bridge/dec: remove unused code

[Qemu-devel] [PATCH] pci-bridge/dec: remove unused code

Peng Hao posted 1 patch 7 years, 2 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1534943694-42729-1-git-send-email-peng.hao2@zte.com.cn

Test docker-clang@ubuntu failed

Test checkpatch passed

hw/pci-bridge/dec.c | 10 ----------
1 file changed, 10 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH] pci-bridge/dec: remove unused code

Posted by Peng Hao 7 years, 2 months ago

Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
---
 hw/pci-bridge/dec.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/hw/pci-bridge/dec.c b/hw/pci-bridge/dec.c
index 84492d5..ab39185 100644
--- a/hw/pci-bridge/dec.c
+++ b/hw/pci-bridge/dec.c
@@ -31,16 +31,6 @@
 #include "hw/pci/pci_bridge.h"
 #include "hw/pci/pci_bus.h"
 
-/* debug DEC */
-//#define DEBUG_DEC
-
-#ifdef DEBUG_DEC
-#define DEC_DPRINTF(fmt, ...)                               \
-    do { printf("DEC: " fmt , ## __VA_ARGS__); } while (0)
-#else
-#define DEC_DPRINTF(fmt, ...)
-#endif
-
 #define DEC_21154(obj) OBJECT_CHECK(DECState, (obj), TYPE_DEC_21154)
 
 typedef struct DECState {
-- 
1.8.3.1

Re: [Qemu-devel] [PATCH] pci-bridge/dec: remove unused code

Posted by Marcel Apfelbaum 7 years, 2 months ago


On 08/22/2018 04:14 PM, Peng Hao wrote:
> Signed-off-by: Peng Hao <peng.hao2@zte.com.cn>
> ---
>   hw/pci-bridge/dec.c | 10 ----------
>   1 file changed, 10 deletions(-)
>
> diff --git a/hw/pci-bridge/dec.c b/hw/pci-bridge/dec.c
> index 84492d5..ab39185 100644
> --- a/hw/pci-bridge/dec.c
> +++ b/hw/pci-bridge/dec.c
> @@ -31,16 +31,6 @@
>   #include "hw/pci/pci_bridge.h"
>   #include "hw/pci/pci_bus.h"
>   
> -/* debug DEC */
> -//#define DEBUG_DEC
> -
> -#ifdef DEBUG_DEC
> -#define DEC_DPRINTF(fmt, ...)                               \
> -    do { printf("DEC: " fmt , ## __VA_ARGS__); } while (0)
> -#else
> -#define DEC_DPRINTF(fmt, ...)
> -#endif
> -
>   #define DEC_21154(obj) OBJECT_CHECK(DECState, (obj), TYPE_DEC_21154)
>   
>   typedef struct DECState {

Reviewed-by: Marcel Apfelbaum<marcel.apfelbaum@gmail.com>


Thanks,
Marcel