vfio coverity reported error fix

[Qemu-devel] [PULL 0/1] vfio coverity reported error fix

Alex Williamson posted 1 patch 7 years, 2 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/153486991405.14686.16930315204565109405.stgit@gimli.home

Test docker-clang@ubuntu failed

Test checkpatch passed

hw/vfio/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[Qemu-devel] [PULL 0/1] vfio coverity reported error fix

Posted by Alex Williamson 7 years, 2 months ago

The following changes since commit ee135aa0428fe5af2af7be04ff16d2b596a9330a:

  Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-3.1-20180821' into staging (2018-08-21 13:27:11 +0100)

are available in the Git repository at:

  git://github.com/awilliam/qemu-vfio.git tags/vfio-fix-20180821.0

for you to fetch changes up to 5d6023cf74cf403fd3aee903050f43278d359e6a:

  vfio/pci: Handle subsystem realpath() returning NULL (2018-08-21 10:29:26 -0600)

----------------------------------------------------------------
VFIO fix 2018-08-21

 - Fix coverity reported issue with use of realpath (Alex Williamson)

----------------------------------------------------------------
Alex Williamson (1):
      vfio/pci: Handle subsystem realpath() returning NULL

 hw/vfio/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Qemu-devel] [PULL 0/1] vfio coverity reported error fix

Posted by Alex Williamson 7 years, 2 months ago

On Tue, 21 Aug 2018 10:47:10 -0600
Alex Williamson <alex.williamson@redhat.com> wrote:

> The following changes since commit ee135aa0428fe5af2af7be04ff16d2b596a9330a:
> 
>   Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-3.1-20180821' into staging (2018-08-21 13:27:11 +0100)
> 
> are available in the Git repository at:
> 
>   git://github.com/awilliam/qemu-vfio.git tags/vfio-fix-20180821.0
> 
> for you to fetch changes up to 5d6023cf74cf403fd3aee903050f43278d359e6a:
> 
>   vfio/pci: Handle subsystem realpath() returning NULL (2018-08-21 10:29:26 -0600)
> 
> ----------------------------------------------------------------
> VFIO fix 2018-08-21
> 
>  - Fix coverity reported issue with use of realpath (Alex Williamson)
> 
> ----------------------------------------------------------------
> Alex Williamson (1):
>       vfio/pci: Handle subsystem realpath() returning NULL
> 
>  hw/vfio/pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Put a halt on this, nothing wrong with the fix but I notice a separate
bug in the original commit (not closing an fd on error).  I'll post
the fix and send another pull request with both.  Thanks,

Alex