Make the pm_smbus code more correct

[Qemu-devel] [PATCH v2 0/8] Make the pm_smbus code more correct

Posted by minyard@acm.org 7 years, 2 months ago

These changes make the pm_smbus device work more like the real thing,
adding block transfers, I2C block transfers, and interrupts.

It also adds vmstate transfer for the smbus device in patch 5.
That patch could probably be left out if that is not desirable.

Patch 7 works around a change made to work around an AMIBIOS bug and
is necessary for interrupts to work.

Patches 9 and 10 add vmstate transfer for SMBus EEPROMs, and obviously
requires patch 5 to work properly.  These could also be left out.

Re: [Qemu-devel] [PATCH v2 0/8] Make the pm_smbus code more correct

Posted by Paolo Bonzini 7 years, 2 months ago

On 20/08/2018 22:26, minyard@acm.org wrote:
> These changes make the pm_smbus device work more like the real thing,
> adding block transfers, I2C block transfers, and interrupts.
> 
> It also adds vmstate transfer for the smbus device in patch 5.
> That patch could probably be left out if that is not desirable.
> 
> Patch 7 works around a change made to work around an AMIBIOS bug and
> is necessary for interrupts to work.
> 
> Patches 9 and 10 add vmstate transfer for SMBus EEPROMs, and obviously
> requires patch 5 to work properly.  These could also be left out.


I have applied 1-6/7/8 for now.  Thanks!

Paolo