[Qemu-devel] [PULL 00/19] MIPS queue for QEMU upstream, August 14, 2018

Aleksandar Markovic posted 19 patches 7 years, 2 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1534270621-27332-1-git-send-email-aleksandar.markovic@rt-rk.com
Test checkpatch passed
Test docker-mingw@fedora passed
Test docker-clang@ubuntu failed
Test docker-quick@centos7 passed
.mailmap                       |   7 +-
MAINTAINERS                    |   9 +-
include/elf.h                  |  24 ++-
linux-user/mips/syscall_nr.h   |   9 +
linux-user/mips64/syscall_nr.h |  18 ++
linux-user/strace.c            |  14 +-
linux-user/syscall.c           |  29 +++
qemu-doc.texi                  |  13 +-
target/mips/cpu.h              | 162 ++++++++-------
target/mips/helper.c           |   4 +-
target/mips/internal.h         |   9 +-
target/mips/machine.c          |   5 +-
target/mips/op_helper.c        |  12 +-
target/mips/translate.c        | 443 ++++++++++++++++++++++++++++++++++-------
14 files changed, 598 insertions(+), 160 deletions(-)
[Qemu-devel] [PULL 00/19] MIPS queue for QEMU upstream, August 14, 2018
Posted by Aleksandar Markovic 7 years, 2 months ago
From: Aleksandar Markovic <amarkovic@wavecomp.com>

The following changes since commit 38441756b70eec5807b5f60dad11a93a91199866:

  Update version for v3.0.0 release (2018-08-14 16:38:43 +0100)

are available in the git repository at:

  https://github.com/AMarkovic/qemu tags/mips-queue-aug-14-2018

for you to fetch changes up to 20d4e01b6486b15d1f3d9ff2d51bba2bf00ebf94:

  qemu-doc: Amend MIPS-related items (2018-08-14 19:59:03 +0200)

----------------------------------------------------------------
MIPS queue for QEMU upstream, August 14, 2018

This is the first part of nanoMIPS support for QEMU. It contains
various fixes and improvements that are related to nanoMIPS support,
or are discovered while working on nanoMIPS support. Most of them are
fairly simple changes, but each of them has its own significance and
importance for nanoMIPS support.

The second part that contains QEMU support for core nanoMIPS
functionality will remain under review for some time.

The third part that mainly contains Linux user support will likely
remain under review for some longer period.

----------------------------------------------------------------

Aleksandar Markovic (9):
  MAINTAINERS: Update target/mips maintainer's email addresses
  target/mips: Avoid case statements formulated by ranges - part 1
  target/mips: Mark switch fallthroughs with interpretable comments
  target/mips: Fix two instances of shadow variables
  target/mips: Update some CP0 registers bit definitions
  elf: Remove duplicate preprocessor constant definition
  elf: Add ELF flags for MIPS machine variants
  linux-user: Update MIPS syscall numbers up to kernel 4.18 headers
  qemu-doc: Amend MIPS-related items

Aleksandar Rikalo (5):
  target/mips: Avoid case statements formulated by ranges - part 2
  target/mips: Add support for availability control via bit XNP
  target/mips: Add support for availability control via bit MT
  target/mips: Fix MT ASE instructions' availability control
  linux-user: Add preprocessor availability control to some syscalls

Stefan Markovic (3):
  target/mips: Add CP0 BadInstrX register
  target/mips: Implement CP0 Config1.WR bit functionality
  target/mips: Add gen_op_addr_addi()

Yongbok Kim (2):
  target/mips: Don't update BadVAddr register in Debug Mode
  target/mips: Check ELPA flag only in some cases of MFHC0 and MTHC0

 .mailmap                       |   7 +-
 MAINTAINERS                    |   9 +-
 include/elf.h                  |  24 ++-
 linux-user/mips/syscall_nr.h   |   9 +
 linux-user/mips64/syscall_nr.h |  18 ++
 linux-user/strace.c            |  14 +-
 linux-user/syscall.c           |  29 +++
 qemu-doc.texi                  |  13 +-
 target/mips/cpu.h              | 162 ++++++++-------
 target/mips/helper.c           |   4 +-
 target/mips/internal.h         |   9 +-
 target/mips/machine.c          |   5 +-
 target/mips/op_helper.c        |  12 +-
 target/mips/translate.c        | 443 ++++++++++++++++++++++++++++++++++-------
 14 files changed, 598 insertions(+), 160 deletions(-)

-- 
2.7.4


Re: [Qemu-devel] [PULL 00/19] MIPS queue for QEMU upstream, August 14, 2018
Posted by Peter Maydell 7 years, 2 months ago
On 14 August 2018 at 19:16, Aleksandar Markovic
<aleksandar.markovic@rt-rk.com> wrote:
> From: Aleksandar Markovic <amarkovic@wavecomp.com>
>
> The following changes since commit 38441756b70eec5807b5f60dad11a93a91199866:
>
>   Update version for v3.0.0 release (2018-08-14 16:38:43 +0100)
>
> are available in the git repository at:
>
>   https://github.com/AMarkovic/qemu tags/mips-queue-aug-14-2018
>
> for you to fetch changes up to 20d4e01b6486b15d1f3d9ff2d51bba2bf00ebf94:
>
>   qemu-doc: Amend MIPS-related items (2018-08-14 19:59:03 +0200)
>
> ----------------------------------------------------------------
> MIPS queue for QEMU upstream, August 14, 2018
>
> This is the first part of nanoMIPS support for QEMU. It contains
> various fixes and improvements that are related to nanoMIPS support,
> or are discovered while working on nanoMIPS support. Most of them are
> fairly simple changes, but each of them has its own significance and
> importance for nanoMIPS support.
>
> The second part that contains QEMU support for core nanoMIPS
> functionality will remain under review for some time.
>
> The third part that mainly contains Linux user support will likely
> remain under review for some longer period.
>
> ----------------------------------------------------------------

Hi; this fails to build on clang:

/home/petmay01/linaro/qemu-for-merges/target/mips/translate.c:1749:20:
error: unused function 'gen_op_addr_addi' [-Werror,-Wunused-funct
ion]
static inline void gen_op_addr_addi(DisasContext *ctx, TCGv ret, TCGv base,
                   ^
/home/petmay01/linaro/qemu-for-merges/target/mips/translate.c:1921:20:
error: unused function 'check_xnp' [-Werror,-Wunused-function]
static inline void check_xnp(DisasContext *ctx)
                   ^
2 errors generated.

The functions do appear to be genuinely unused.

thanks
-- PMM

Re: [Qemu-devel]?==?utf-8?q? [PULL?==?utf-8?q? 00/19] MIPS queue for QEMU upstream, August 14, 2018
Posted by Aleksandar Markovic 7 years, 2 months ago
These functions are used in the patches that follow in nanoMIPS series, but not submitted in this pull request.

Ok, I will reorganize the patches so that there is no such case, and will send the new pull request soon.

Do we require that bisect works for clang builds too (meaning that after each patch, clang build must be success)?

Aleksandar

-------- Original Message --------
Subject: Re: [PULL 00/19] MIPS queue for QEMU upstream, August 14, 2018
Date: Wednesday, August 15, 2018 21:20 CEST
From: Peter Maydell <peter.maydell@linaro.org>
To: Aleksandar Markovic <aleksandar.markovic@rt-rk.com>
CC: QEMU Developers <qemu-devel@nongnu.org>
References: <1534270621-27332-1-git-send-email-aleksandar.markovic@rt-rk.com>


 On 14 August 2018 at 19:16, Aleksandar Markovic
<aleksandar.markovic@rt-rk.com> wrote:
> From: Aleksandar Markovic <amarkovic@wavecomp.com>
>
> The following changes since commit 38441756b70eec5807b5f60dad11a93a91199866:
>
> Update version for v3.0.0 release (2018-08-14 16:38:43 +0100)
>
> are available in the git repository at:
>
> https://github.com/AMarkovic/qemu tags/mips-queue-aug-14-2018
>
> for you to fetch changes up to 20d4e01b6486b15d1f3d9ff2d51bba2bf00ebf94:
>
> qemu-doc: Amend MIPS-related items (2018-08-14 19:59:03 +0200)
>
> ----------------------------------------------------------------
> MIPS queue for QEMU upstream, August 14, 2018
>
> This is the first part of nanoMIPS support for QEMU. It contains
> various fixes and improvements that are related to nanoMIPS support,
> or are discovered while working on nanoMIPS support. Most of them are
> fairly simple changes, but each of them has its own significance and
> importance for nanoMIPS support.
>
> The second part that contains QEMU support for core nanoMIPS
> functionality will remain under review for some time.
>
> The third part that mainly contains Linux user support will likely
> remain under review for some longer period.
>
> ----------------------------------------------------------------

Hi; this fails to build on clang:

/home/petmay01/linaro/qemu-for-merges/target/mips/translate.c:1749:20:
error: unused function 'gen_op_addr_addi' [-Werror,-Wunused-funct
ion]
static inline void gen_op_addr_addi(DisasContext *ctx, TCGv ret, TCGv base,
^
/home/petmay01/linaro/qemu-for-merges/target/mips/translate.c:1921:20:
error: unused function 'check_xnp' [-Werror,-Wunused-function]
static inline void check_xnp(DisasContext *ctx)
^
2 errors generated.

The functions do appear to be genuinely unused.

thanks
-- PMM


 
Re: [Qemu-devel] [PULL 00/19] MIPS queue for QEMU upstream, August 14, 2018
Posted by Peter Maydell 7 years, 2 months ago
On 15 August 2018 at 20:35, Aleksandar Markovic
<Aleksandar.Markovic@rt-rk.com> wrote:
> These functions are used in the patches that follow in nanoMIPS series, but
> not submitted in this pull request.
>
> Ok, I will reorganize the patches so that there is no such case, and will
> send the new pull request soon.
>
> Do we require that bisect works for clang builds too (meaning that after
> each patch, clang build must be success)?

Yes, please. (As usual with breaking-bisection, if you get it wrong by
accident we may well not notice, but it's worth trying to get right.)

thanks
-- PMM