[Qemu-devel] [PATCH v7 79/80] qemu-doc: Amend MIPS-related items

Aleksandar Markovic posted 80 patches 7 years, 3 months ago
There is a newer version of this series
[Qemu-devel] [PATCH v7 79/80] qemu-doc: Amend MIPS-related items
Posted by Aleksandar Markovic 7 years, 3 months ago
From: Aleksandar Markovic <amarkovic@wavecomp.com>

Amend MIPS-related items in qemu-doc.texi

Signed-off-by: Aleksandar Markovic <amarkovic@wavecomp.com>
Signed-off-by: Stefan Markovic <smarkovic@wavecomp.com>
---
 qemu-doc.texi | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/qemu-doc.texi b/qemu-doc.texi
index abfd2db..8ea6bfa 100644
--- a/qemu-doc.texi
+++ b/qemu-doc.texi
@@ -2693,8 +2693,17 @@ The binary format is detected automatically.
 @command{qemu-microblaze} TODO.
 
 @cindex user mode (MIPS)
-@command{qemu-mips} TODO.
-@command{qemu-mipsel} TODO.
+@command{qemu-mips} executes 32-bit big endian MIPS binaries (MIPS O32 ABI).
+
+@command{qemu-mipsel} executes 32-bit little endian MIPS binaries (MIPS O32 ABI).
+
+@command{qemu-mips64} executes 64-bit big endian MIPS binaries (MIPS O64 ABI).
+
+@command{qemu-mips64el} executes 64-bit little endian MIPS binaries (MIPS O64 ABI).
+
+@command{qemu-mipsn32} executes 32-bit big endian MIPS binaries (MIPS N32 ABI).
+
+@command{qemu-mipsn32el} executes 32-bit little endian MIPS binaries (MIPS N32 ABI).
 
 @cindex user mode (NiosII)
 @command{qemu-nios2} TODO.
-- 
2.7.4


Re: [Qemu-devel] [PATCH v7 79/80] qemu-doc: Amend MIPS-related items
Posted by Aleksandar Markovic 7 years, 2 months ago
Paul, Richard, Thomas,

Can some of you review this patch (https://lists.gnu.org/archive/html/qemu-devel/2018-08/msg00777.html) and another (https://lists.gnu.org/archive/html/qemu-devel/2018-08/msg00783.html)?

Those are just very basic statements in our user documentation, related to earlier MIPS platforms, and the new nanoMIPS.

I find it important for a new feature to be mentioned in the docs, even with just a short statement like these.

I can't review the patches since I am their author.

Yours,
Aleksandar Markovic

P.S. Paul, perhaps a section on Boston board would fitt in well in this file?


> From: Aleksandar Markovic <aleksandar.markovic@rt-rk.com>
> Sent: Monday, August 6, 2018 7:00 PM
> 
> Subject: [PATCH v7 79/80] qemu-doc: Amend MIPS-related items
> 
> From: Aleksandar Markovic <amarkovic@wavecomp.com>
> 
> Amend MIPS-related items in qemu-doc.texi
> 
> Signed-off-by: Aleksandar Markovic <amarkovic@wavecomp.com>
> Signed-off-by: Stefan Markovic <smarkovic@wavecomp.com>
> ---
>  qemu-doc.texi | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/qemu-doc.texi b/qemu-doc.texi
> index abfd2db..8ea6bfa 100644
> --- a/qemu-doc.texi
> +++ b/qemu-doc.texi
> @@ -2693,8 +2693,17 @@ The binary format is detected automatically.
>  @command{qemu-microblaze} TODO.
> 
>  @cindex user mode (MIPS)
> -@command{qemu-mips} TODO.
> -@command{qemu-mipsel} TODO.
> +@command{qemu-mips} executes 32-bit big endian MIPS binaries (MIPS O32 ABI).
> +
> +@command{qemu-mipsel} executes 32-bit little endian MIPS binaries (MIPS O32 ABI).
> +
> +@command{qemu-mips64} executes 64-bit big endian MIPS binaries (MIPS O64 ABI).
> +
> +@command{qemu-mips64el} executes 64-bit little endian MIPS binaries (MIPS O64 ABI).
> +
> +@command{qemu-mipsn32} executes 32-bit big endian MIPS binaries (MIPS N32 ABI).
> +
> +@command{qemu-mipsn32el} executes 32-bit little endian MIPS binaries (MIPS N32 ABI).
> 
>  @cindex user mode (NiosII)
>  @command{qemu-nios2} TODO.
> --
> 2.7.4
> 

Re: [Qemu-devel] [PATCH v7 79/80] qemu-doc: Amend MIPS-related items
Posted by Thomas Huth 7 years, 2 months ago
On 08/06/2018 07:00 PM, Aleksandar Markovic wrote:
> From: Aleksandar Markovic <amarkovic@wavecomp.com>
> 
> Amend MIPS-related items in qemu-doc.texi
> 
> Signed-off-by: Aleksandar Markovic <amarkovic@wavecomp.com>
> Signed-off-by: Stefan Markovic <smarkovic@wavecomp.com>

As far as I've understood the SoB process, your SoB should go last if
you're the last person who has touched this patch, Alexander. I think it
would also be good if you'd use the same e-mail for sending patches as
you used for the SoB in the patches (you sent with rt-rk.com, but used
wavecomp.com in the SoB).

> ---
>  qemu-doc.texi | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)
> 
> diff --git a/qemu-doc.texi b/qemu-doc.texi
> index abfd2db..8ea6bfa 100644
> --- a/qemu-doc.texi
> +++ b/qemu-doc.texi
> @@ -2693,8 +2693,17 @@ The binary format is detected automatically.
>  @command{qemu-microblaze} TODO.
>  
>  @cindex user mode (MIPS)
> -@command{qemu-mips} TODO.
> -@command{qemu-mipsel} TODO.
> +@command{qemu-mips} executes 32-bit big endian MIPS binaries (MIPS O32 ABI).
> +
> +@command{qemu-mipsel} executes 32-bit little endian MIPS binaries (MIPS O32 ABI).
> +
> +@command{qemu-mips64} executes 64-bit big endian MIPS binaries (MIPS O64 ABI).
> +
> +@command{qemu-mips64el} executes 64-bit little endian MIPS binaries (MIPS O64 ABI).
> +
> +@command{qemu-mipsn32} executes 32-bit big endian MIPS binaries (MIPS N32 ABI).
> +
> +@command{qemu-mipsn32el} executes 32-bit little endian MIPS binaries (MIPS N32 ABI).

Looks reasonable to me.

Reviewed-by: Thomas Huth <thuth@redhat.com>