[v6] Add nanoMIPS support to QEMU

[Qemu-devel] [PATCH v6 00/77] Add nanoMIPS support to QEMU

Posted by Stefan Markovic 7 years, 3 months ago

From: Stefan Markovic <smarkovic@wavecomp.com>

v5->v6:

  - used names offset and imm instead of rd and rs when
  appropriate
  - used gen_op_addr_addi when appropriate in one more place
  - avoided usage of tcg_temp_local_new
  - avoided unnecesary sign extension related to addr_add
  - fixed unprotected storing to cpu_gpr[0]
  - removed some unnecesary testing for ISA_NANOMIPS
  - updated patch for LLWP and SCWP
  - extract32 inserted instead of shift/mask in DSP patches
  - removed useless casts from DSP patches
  - reorganized functions to eliminated duplicated loading of
  gpr values into tcg variables in DSP patches
  - check Config1.WR bit for Watch registers only when using
  in runtime
  - removed duplicated check for bad address in PC register
  - added support for statx system call
  - updated script qemu-binfmt-conf.sh for nanoMIPS
  - rebased to the latest code

v4->v5:

  - merged series "Mips maintenance and misc fixes and improvements"
    and this one for easier handling (there are build dependencies)
  - eliminated shadow variables from translate.c
  - replaced shift/mask combination with extract32()
  - added new function gen_op_addr_addi()
  - added "fall through" comments at appropriate places
  - eliminated micromips flag from I7200 definition
  - numerous other enhancements originating from reviewer's
    comments
  - some of the patches split into two or more for easier
    handling and review
  - rebased to the latest code

v3->v4:

  - added support for nanoMIPS user mode functionality and
    configuration
  - DSP patch split into three for easier review and handling
  - corrected indentation in all decoding engine patches
  - shift/mask replaced with equivalent extract32() in some
    patches
  - added missing default cases in some patches
  - refactored invocation logic aroung decode_nanomips_opc()
  - improved comments before decode_gpr_XXX() utilities
  - all four decode_gpr_XXX() are now in a single patch
  - two patches on updating BadInstr and related registers
    are now merged, and execution logic improved
  - minor formatting corrections
  - rebased to the latest code

v2->v3:

  - added support for nanoMIPS-specifics in ELF headers
  - added support for CP0 Config0.WR bit
  - updated I7200 definition
  - improved indentation of some switch statements
  - slight reorganization of patches (splitting, order)
  - rebased to the latest code

v1->v2:

  - added DSP ASE support
  - added MT ASE support
  - added GDB XML support
  - order of patches changed
  - commit messages and patch title improved accross the board
  - obsolete email addresses for authors and cosigners replaced
    with the right ones
  - some functions renamed to reflect better the documentation
  - some macros renamed to reflect better their nanoMIPS nature
  - streamlined formatting
  - some of other reviewer's comments addressed, but the majority
    was not; this is because the focus of this version was on
    completing the functionality as much as possible; remaining
    comments will be addressed in the subsequent versions of this
    series

This series of patches implements recently announced nanoMIPS on QEMU.
nanoMIPS is a variable length ISA containing 16, 32 and 48-bit wide
instructions. It is designed to be portable at assembly level with
other MIPS and microMIPS code, but contains a number of changes that
enhance code density and efficiency. The largest portion of patches
is nanoMIPS decoding engine.

For more information, please refer to the following link:

https://www.mips.com/products/architectures/nanomips/

Aleksandar Markovic (14):
  MAINTAINERS: Update target/mips maintainer's email addresses
  target/mips: Avoid case statements formulated by ranges
  target/mips: Mark switch fallthroughs with interpretable comments
  target/mips: Fix two instances of shadow variables
  target/mips: Update some CP0 registers bit definitions
  elf: Remove duplicate preprocessor constant definition
  elf: Add ELF flags for MIPS machine variants
  linux-user: Update MIPS syscall numbers up to kernel 4.18 headers
  target/mips: Add preprocessor constants for nanoMIPS
  target/mips: Add placeholder and invocation of decode_nanomips_opc()
  target/mips: Add nanoMIPS decoding and extraction utilities
  elf: Relax MIPS' elf_check_arch() to accept EM_NANOMIPS too
  elf: Don't check FCR31_NAN2008 bit for nanoMIPS
  linux-user: Update syscall_defs.h header for nanoMIPS

Aleksandar Rikalo (13):
  linux-user: Add preprocessor availability control to some syscalls
  target/mips: Implement emulation of nanoMIPS LLWP/SCWP pair
  elf: Add nanoMIPS specific variations in ELF header fields
  linux-user: Add syscall numbers for nanoMIPS
  linux-user: Add target_signal.h header for nanoMIPS
  linux-user: Add termbits.h header for nanoMIPS
  linux-user: Add target_fcntl.h header for nanoMIPS
  linux-user: Add sockbits.h header for nanoMIPS
  linux-user: Add target_syscall.h header for nanoMIPS
  linux-user: Add support for nanoMIPS signal trampoline
  linux-user: Amend support for sigaction() syscall for nanoMIPS
  linux-user: Add support for statx() syscall for all platforms
  linux-user: Add nanoMIPS support in scripts/qemu-binfmt-conf.sh

Dimitrije Nikolic (5):
  linux-user: Add target_cpu.h header for nanoMIPS
  linux-user: Add target_structs.h header for nanoMIPS
  linux-user: Add target_elf.h header for nanoMIPS
  linux-user: Add signal.c for nanoMIPS
  linux-user: Add cpu_loop.c for nanoMIPS

James Hogan (5):
  target/mips: Implement emulation of nanoMIPS EXTW instruction
  target/mips: Adjust exception_resume_pc() for nanoMIPS
  target/mips: Adjust set_hflags_for_handler() for nanoMIPS
  target/mips: Adjust set_pc() for nanoMIPS
  gdbstub: Disable handling of nanoMIPS ISA bit in the MIPS gdbstub

Matthew Fortune (4):
  target/mips: Add emulation of nanoMIPS 16-bit save and restore
    instructions
  target/mips: Implement emulation of nanoMIPS ROTX instruction
  target/mips: Add handling of branch delay slots for nanoMIPS
  mips_malta: Add basic nanoMIPS boot code for MIPS' Malta

Paul Burton (1):
  mips_malta: Setup GT64120 BARs in nanoMIPS bootloader

Stefan Markovic (16):
  target/mips: Add CP0 BadInstrX register
  target/mips: Add gen_op_addr_addi()
  target/mips: Add nanoMIPS DSP ASE opcodes
  target/mips: Implement MT ASE support for nanoMIPS
  target/mips: Add emulation of DSP ASE for nanoMIPS - part 1
  target/mips: Add emulation of DSP ASE for nanoMIPS - part 2
  target/mips: Add emulation of DSP ASE for nanoMIPS - part 3
  target/mips: Add emulation of DSP ASE for nanoMIPS - part 4
  target/mips: Add emulation of DSP ASE for nanoMIPS - part 5
  target/mips: Add emulation of DSP ASE for nanoMIPS - part 6
  target/mips: Add updating BadInstr, BadInstrP, BadInstrX for nanoMIPS
  target/mips: Implement CP0 Config1.WR bit functionality
  mips_malta: Fix semihosting argument passing for nanoMIPS bare metal
  gdbstub: Add XML support for GDB for nanoMIPS
  target/mips: Add definition of nanoMIPS I7200 CPU
  linux-user: Add nanoMIPS linux user mode configuration support

Yongbok Kim (19):
  target/mips: Don't update BadVAddr register in Debug Mode
  target/mips: Check ELPA flag only in some cases of MFHC0 and MTHC0
  target/mips: Add nanoMIPS base instruction set opcodes
  target/mips: Add emulation of nanoMIPS 16-bit arithmetic instructions
  target/mips: Add emulation of nanoMIPS 16-bit branch instructions
  target/mips: Add emulation of nanoMIPS 16-bit shift instructions
  target/mips: Add emulation of nanoMIPS 16-bit misc instructions
  target/mips: Add emulation of nanoMIPS 16-bit load and store
    instructions
  target/mips: Add emulation of nanoMIPS 16-bit logic instructions
  target/mips: Add emulation of some common nanoMIPS 32-bit instructions
  target/mips: Add emulation of nanoMIPS instructions MOVE.P and
    MOVE.PREV
  target/mips: Add emulation of nanoMIPS 48-bit instructions
  target/mips: Add emulation of nanoMIPS FP instructions
  target/mips: Add emulation of misc nanoMIPS instructions (pool32a0)
  target/mips: Add emulation of misc nanoMIPS instructions (pool32axf)
  target/mips: Add emulation of misc nanoMIPS instructions (p_lsx)
  target/mips: Add emulation of nanoMIPS 32-bit load and store
    instructions
  target/mips: Add emulation of nanoMIPS 32-bit branch instructions
  target/mips: Fix ERET/ERETNC behavior related to ADEL exception

 .mailmap                                |    7 +-
 MAINTAINERS                             |   12 +-
 configure                               |   13 +-
 default-configs/nanomips-linux-user.mak |    1 +
 gdb-xml/nanomips-cp0.xml                |   13 +
 gdb-xml/nanomips-cpu.xml                |   44 +
 gdb-xml/nanomips-dsp.xml                |   20 +
 gdb-xml/nanomips-fpu.xml                |   45 +
 gdb-xml/nanomips-linux.xml              |   20 +
 hw/mips/mips_malta.c                    |  153 +-
 include/elf.h                           |   44 +-
 linux-user/elfload.c                    |    2 +
 linux-user/mips/cpu_loop.c              |   36 +-
 linux-user/mips/signal.c                |   36 +-
 linux-user/mips/syscall_nr.h            |    9 +
 linux-user/mips/termbits.h              |    4 +
 linux-user/mips64/syscall_nr.h          |   18 +
 linux-user/nanomips/cpu_loop.c          |    1 +
 linux-user/nanomips/signal.c            |    1 +
 linux-user/nanomips/sockbits.h          |    1 +
 linux-user/nanomips/syscall_nr.h        |  275 ++
 linux-user/nanomips/target_cpu.h        |   21 +
 linux-user/nanomips/target_elf.h        |   14 +
 linux-user/nanomips/target_fcntl.h      |   38 +
 linux-user/nanomips/target_signal.h     |   22 +
 linux-user/nanomips/target_structs.h    |    1 +
 linux-user/nanomips/target_syscall.h    |   30 +
 linux-user/nanomips/termbits.h          |    1 +
 linux-user/strace.c                     |   14 +-
 linux-user/syscall.c                    |  129 +-
 linux-user/syscall_defs.h               |   95 +-
 scripts/qemu-binfmt-conf.sh             |   12 +-
 target/mips/cpu.h                       |  160 +-
 target/mips/gdbstub.c                   |   13 +-
 target/mips/helper.c                    |   36 +-
 target/mips/helper.h                    |    2 +
 target/mips/machine.c                   |    5 +-
 target/mips/mips-defs.h                 |    4 +
 target/mips/op_helper.c                 |  113 +-
 target/mips/translate.c                 | 4887 ++++++++++++++++++++++++++++++-
 target/mips/translate_init.inc.c        |   39 +
 41 files changed, 6145 insertions(+), 246 deletions(-)
 create mode 100644 default-configs/nanomips-linux-user.mak
 create mode 100644 gdb-xml/nanomips-cp0.xml
 create mode 100644 gdb-xml/nanomips-cpu.xml
 create mode 100644 gdb-xml/nanomips-dsp.xml
 create mode 100644 gdb-xml/nanomips-fpu.xml
 create mode 100644 gdb-xml/nanomips-linux.xml
 create mode 100644 linux-user/nanomips/cpu_loop.c
 create mode 100644 linux-user/nanomips/signal.c
 create mode 100644 linux-user/nanomips/sockbits.h
 create mode 100644 linux-user/nanomips/syscall_nr.h
 create mode 100644 linux-user/nanomips/target_cpu.h
 create mode 100644 linux-user/nanomips/target_elf.h
 create mode 100644 linux-user/nanomips/target_fcntl.h
 create mode 100644 linux-user/nanomips/target_signal.h
 create mode 100644 linux-user/nanomips/target_structs.h
 create mode 100644 linux-user/nanomips/target_syscall.h
 create mode 100644 linux-user/nanomips/termbits.h

-- 
1.9.1

Re: [Qemu-devel] [PATCH v6 00/77] Add nanoMIPS support to QEMU

Posted by no-reply@patchew.org 7 years, 3 months ago

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1533219424-7627-1-git-send-email-stefan.markovic@rt-rk.com
Subject: [Qemu-devel] [PATCH v6 00/77] Add nanoMIPS support to QEMU

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
64eda72870 linux-user: Add nanoMIPS support in scripts/qemu-binfmt-conf.sh
e1a8cee4e5 linux-user: Add nanoMIPS linux user mode configuration support
df0e845f6e linux-user: Add support for statx() syscall for all platforms
32fec98ab2 linux-user: Amend support for sigaction() syscall for nanoMIPS
d4bfe737f2 linux-user: Add cpu_loop.c for nanoMIPS
4e1a987087 linux-user: Add support for nanoMIPS signal trampoline
aab0010a40 linux-user: Add signal.c for nanoMIPS
532eab67e7 linux-user: Add target_elf.h header for nanoMIPS
ddf77d7ac3 linux-user: Add target_structs.h header for nanoMIPS
84769d57a3 linux-user: Add target_cpu.h header for nanoMIPS
1fb20c1a72 linux-user: Add target_syscall.h header for nanoMIPS
d953da1580 linux-user: Add sockbits.h header for nanoMIPS
b0efc906fd linux-user: Add target_fcntl.h header for nanoMIPS
9d02c1e8eb linux-user: Update syscall_defs.h header for nanoMIPS
08fa324773 linux-user: Add termbits.h header for nanoMIPS
4821ebaae2 linux-user: Add target_signal.h header for nanoMIPS
06a0c46995 linux-user: Add syscall numbers for nanoMIPS
73be124213 target/mips: Add definition of nanoMIPS I7200 CPU
dbb82d28a4 gdbstub: Add XML support for GDB for nanoMIPS
186274afc1 gdbstub: Disable handling of nanoMIPS ISA bit in the MIPS gdbstub
7c8e071621 mips_malta: Fix semihosting argument passing for nanoMIPS bare metal
12091e1b6a mips_malta: Setup GT64120 BARs in nanoMIPS bootloader
c6323a3d69 mips_malta: Add basic nanoMIPS boot code for MIPS' Malta
0b61ee6473 elf: Don't check FCR31_NAN2008 bit for nanoMIPS
e8981250f1 elf: Relax MIPS' elf_check_arch() to accept EM_NANOMIPS too
d420a2f219 elf: Add nanoMIPS specific variations in ELF header fields
ed34b57a9c target/mips: Fix ERET/ERETNC behavior related to ADEL exception
b87394bad8 target/mips: Adjust set_pc() for nanoMIPS
e4f7784168 target/mips: Adjust set_hflags_for_handler() for nanoMIPS
2092c88d8f target/mips: Adjust exception_resume_pc() for nanoMIPS
9e4037a9d7 target/mips: Implement CP0 Config1.WR bit functionality
d5283f3176 target/mips: Add updating BadInstr, BadInstrP, BadInstrX for nanoMIPS
42416dd9c3 target/mips: Implement emulation of nanoMIPS LLWP/SCWP pair
69c9bcbca8 target/mips: Add handling of branch delay slots for nanoMIPS
e3054474bc target/mips: Add emulation of DSP ASE for nanoMIPS - part 6
a59cf3890e target/mips: Add emulation of DSP ASE for nanoMIPS - part 5
fb3e985dcd target/mips: Add emulation of DSP ASE for nanoMIPS - part 4
6ab266466c target/mips: Add emulation of DSP ASE for nanoMIPS - part 3
04a64ebd5f target/mips: Add emulation of DSP ASE for nanoMIPS - part 2
9a77858051 target/mips: Add emulation of DSP ASE for nanoMIPS - part 1
faaa015779 target/mips: Implement MT ASE support for nanoMIPS
2b4090fbff target/mips: Add emulation of nanoMIPS 32-bit branch instructions
4d8ddca2e1 target/mips: Add emulation of nanoMIPS 32-bit load and store instructions
c0fd0eea21 target/mips: Implement emulation of nanoMIPS EXTW instruction
f06df895ec target/mips: Implement emulation of nanoMIPS ROTX instruction
4bd3210913 target/mips: Add emulation of misc nanoMIPS instructions (p_lsx)
8860af1984 target/mips: Add emulation of misc nanoMIPS instructions (pool32axf)
7600a72911 target/mips: Add emulation of misc nanoMIPS instructions (pool32a0)
3a16a5a7c1 target/mips: Add emulation of nanoMIPS FP instructions
5752ef6f96 target/mips: Add emulation of nanoMIPS 48-bit instructions
8416c94b0b target/mips: Add emulation of nanoMIPS instructions MOVE.P and MOVE.PREV
5e5735abfd target/mips: Add emulation of some common nanoMIPS 32-bit instructions
111050a1a4 target/mips: Add emulation of nanoMIPS 16-bit save and restore instructions
43c3921546 target/mips: Add emulation of nanoMIPS 16-bit logic instructions
701b37e40e target/mips: Add emulation of nanoMIPS 16-bit load and store instructions
9a3ed3ef5b target/mips: Add emulation of nanoMIPS 16-bit misc instructions
46fbf41e0b target/mips: Add emulation of nanoMIPS 16-bit shift instructions
4e4bb7d89e target/mips: Add emulation of nanoMIPS 16-bit branch instructions
d025bf6095 target/mips: Add emulation of nanoMIPS 16-bit arithmetic instructions
a8e7c69cde target/mips: Add nanoMIPS decoding and extraction utilities
1a10ec177a target/mips: Add placeholder and invocation of decode_nanomips_opc()
35d6929b49 target/mips: Add nanoMIPS DSP ASE opcodes
b21f9ea00f target/mips: Add nanoMIPS base instruction set opcodes
0c8be110d8 target/mips: Add preprocessor constants for nanoMIPS
3e7d1af77a linux-user: Add preprocessor availability control to some syscalls
286793a63d linux-user: Update MIPS syscall numbers up to kernel 4.18 headers
62ca346b44 elf: Add ELF flags for MIPS machine variants
99d6e75f45 elf: Remove duplicate preprocessor constant definition
8a93d61b15 target/mips: Check ELPA flag only in some cases of MFHC0 and MTHC0
5dc3e9663e target/mips: Don't update BadVAddr register in Debug Mode
a817c46476 target/mips: Add gen_op_addr_addi()
1978cd96ba target/mips: Add CP0 BadInstrX register
1149b1e3e4 target/mips: Update some CP0 registers bit definitions
f68c083414 target/mips: Fix two instances of shadow variables
06abdd383a target/mips: Mark switch fallthroughs with interpretable comments
a52ac50ccd target/mips: Avoid case statements formulated by ranges
e2d6fa289c MAINTAINERS: Update target/mips maintainer's email addresses

=== OUTPUT BEGIN ===
Checking PATCH 1/77: MAINTAINERS: Update target/mips maintainer's email addresses...
Checking PATCH 2/77: target/mips: Avoid case statements formulated by ranges...
Checking PATCH 3/77: target/mips: Mark switch fallthroughs with interpretable comments...
Checking PATCH 4/77: target/mips: Fix two instances of shadow variables...
Checking PATCH 5/77: target/mips: Update some CP0 registers bit definitions...
Checking PATCH 6/77: target/mips: Add CP0 BadInstrX register...
Checking PATCH 7/77: target/mips: Add gen_op_addr_addi()...
Checking PATCH 8/77: target/mips: Don't update BadVAddr register in Debug Mode...
Checking PATCH 9/77: target/mips: Check ELPA flag only in some cases of MFHC0 and MTHC0...
Checking PATCH 10/77: elf: Remove duplicate preprocessor constant definition...
Checking PATCH 11/77: elf: Add ELF flags for MIPS machine variants...
Checking PATCH 12/77: linux-user: Update MIPS syscall numbers up to kernel 4.18 headers...
Checking PATCH 13/77: linux-user: Add preprocessor availability control to some syscalls...
Checking PATCH 14/77: target/mips: Add preprocessor constants for nanoMIPS...
Checking PATCH 15/77: target/mips: Add nanoMIPS base instruction set opcodes...
Checking PATCH 16/77: target/mips: Add nanoMIPS DSP ASE opcodes...
Checking PATCH 17/77: target/mips: Add placeholder and invocation of decode_nanomips_opc()...
Checking PATCH 18/77: target/mips: Add nanoMIPS decoding and extraction utilities...
Checking PATCH 19/77: target/mips: Add emulation of nanoMIPS 16-bit arithmetic instructions...
Checking PATCH 20/77: target/mips: Add emulation of nanoMIPS 16-bit branch instructions...
Checking PATCH 21/77: target/mips: Add emulation of nanoMIPS 16-bit shift instructions...
Checking PATCH 22/77: target/mips: Add emulation of nanoMIPS 16-bit misc instructions...
Checking PATCH 23/77: target/mips: Add emulation of nanoMIPS 16-bit load and store instructions...
Checking PATCH 24/77: target/mips: Add emulation of nanoMIPS 16-bit logic instructions...
Checking PATCH 25/77: target/mips: Add emulation of nanoMIPS 16-bit save and restore instructions...
Checking PATCH 26/77: target/mips: Add emulation of some common nanoMIPS 32-bit instructions...
Checking PATCH 27/77: target/mips: Add emulation of nanoMIPS instructions MOVE.P and MOVE.PREV...
Checking PATCH 28/77: target/mips: Add emulation of nanoMIPS 48-bit instructions...
Checking PATCH 29/77: target/mips: Add emulation of nanoMIPS FP instructions...
Checking PATCH 30/77: target/mips: Add emulation of misc nanoMIPS instructions (pool32a0)...
Checking PATCH 31/77: target/mips: Add emulation of misc nanoMIPS instructions (pool32axf)...
Checking PATCH 32/77: target/mips: Add emulation of misc nanoMIPS instructions (p_lsx)...
Checking PATCH 33/77: target/mips: Implement emulation of nanoMIPS ROTX instruction...
Checking PATCH 34/77: target/mips: Implement emulation of nanoMIPS EXTW instruction...
Checking PATCH 35/77: target/mips: Add emulation of nanoMIPS 32-bit load and store instructions...
Checking PATCH 36/77: target/mips: Add emulation of nanoMIPS 32-bit branch instructions...
Checking PATCH 37/77: target/mips: Implement MT ASE support for nanoMIPS...
Checking PATCH 38/77: target/mips: Add emulation of DSP ASE for nanoMIPS - part 1...
Checking PATCH 39/77: target/mips: Add emulation of DSP ASE for nanoMIPS - part 2...
Checking PATCH 40/77: target/mips: Add emulation of DSP ASE for nanoMIPS - part 3...
Checking PATCH 41/77: target/mips: Add emulation of DSP ASE for nanoMIPS - part 4...
Checking PATCH 42/77: target/mips: Add emulation of DSP ASE for nanoMIPS - part 5...
Checking PATCH 43/77: target/mips: Add emulation of DSP ASE for nanoMIPS - part 6...
Checking PATCH 44/77: target/mips: Add handling of branch delay slots for nanoMIPS...
Checking PATCH 45/77: target/mips: Implement emulation of nanoMIPS LLWP/SCWP pair...
Checking PATCH 46/77: target/mips: Add updating BadInstr, BadInstrP, BadInstrX for nanoMIPS...
Checking PATCH 47/77: target/mips: Implement CP0 Config1.WR bit functionality...
Checking PATCH 48/77: target/mips: Adjust exception_resume_pc() for nanoMIPS...
Checking PATCH 49/77: target/mips: Adjust set_hflags_for_handler() for nanoMIPS...
Checking PATCH 50/77: target/mips: Adjust set_pc() for nanoMIPS...
Checking PATCH 51/77: target/mips: Fix ERET/ERETNC behavior related to ADEL exception...
Checking PATCH 52/77: elf: Add nanoMIPS specific variations in ELF header fields...
Checking PATCH 53/77: elf: Relax MIPS' elf_check_arch() to accept EM_NANOMIPS too...
Checking PATCH 54/77: elf: Don't check FCR31_NAN2008 bit for nanoMIPS...
Checking PATCH 55/77: mips_malta: Add basic nanoMIPS boot code for MIPS' Malta...
Checking PATCH 56/77: mips_malta: Setup GT64120 BARs in nanoMIPS bootloader...
Checking PATCH 57/77: mips_malta: Fix semihosting argument passing for nanoMIPS bare metal...
Checking PATCH 58/77: gdbstub: Disable handling of nanoMIPS ISA bit in the MIPS gdbstub...
Checking PATCH 59/77: gdbstub: Add XML support for GDB for nanoMIPS...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#34: 
new file mode 100644

total: 0 errors, 1 warnings, 157 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 60/77: target/mips: Add definition of nanoMIPS I7200 CPU...
Checking PATCH 61/77: linux-user: Add syscall numbers for nanoMIPS...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#16: 
new file mode 100644

total: 0 errors, 1 warnings, 275 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 62/77: linux-user: Add target_signal.h header for nanoMIPS...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#16: 
new file mode 100644

total: 0 errors, 1 warnings, 22 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 63/77: linux-user: Add termbits.h header for nanoMIPS...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30: 
new file mode 100644

total: 0 errors, 1 warnings, 11 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 64/77: linux-user: Update syscall_defs.h header for nanoMIPS...
Checking PATCH 65/77: linux-user: Add target_fcntl.h header for nanoMIPS...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14: 
new file mode 100644

total: 0 errors, 1 warnings, 38 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 66/77: linux-user: Add sockbits.h header for nanoMIPS...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14: 
new file mode 100644

total: 0 errors, 1 warnings, 1 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 67/77: linux-user: Add target_syscall.h header for nanoMIPS...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14: 
new file mode 100644

total: 0 errors, 1 warnings, 30 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 68/77: linux-user: Add target_cpu.h header for nanoMIPS...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14: 
new file mode 100644

total: 0 errors, 1 warnings, 21 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 69/77: linux-user: Add target_structs.h header for nanoMIPS...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15: 
new file mode 100644

total: 0 errors, 1 warnings, 1 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 70/77: linux-user: Add target_elf.h header for nanoMIPS...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15: 
new file mode 100644

total: 0 errors, 1 warnings, 14 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 71/77: linux-user: Add signal.c for nanoMIPS...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#113: 
new file mode 100644

total: 0 errors, 1 warnings, 84 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 72/77: linux-user: Add support for nanoMIPS signal trampoline...
Checking PATCH 73/77: linux-user: Add cpu_loop.c for nanoMIPS...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#54: 
new file mode 100644

total: 0 errors, 1 warnings, 33 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 74/77: linux-user: Amend support for sigaction() syscall for nanoMIPS...
Checking PATCH 75/77: linux-user: Add support for statx() syscall for all platforms...
WARNING: architecture specific defines should be avoided
#36: FILE: linux-user/syscall.c:10032:
+#if defined(__NR_statx)

WARNING: architecture specific defines should be avoided
#49: FILE: linux-user/syscall.c:10045:
+#if defined(__NR_statx)

total: 0 errors, 2 warnings, 154 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 76/77: linux-user: Add nanoMIPS linux user mode configuration support...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#60: 
new file mode 100644

total: 0 errors, 1 warnings, 38 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 77/77: linux-user: Add nanoMIPS support in scripts/qemu-binfmt-conf.sh...
WARNING: line over 80 characters
#30: FILE: scripts/qemu-binfmt-conf.sh:79:
+nanomips_magic='\x7fELF\x01\x01\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\xf9\x00'

ERROR: line over 90 characters
#31: FILE: scripts/qemu-binfmt-conf.sh:80:
+nanomips_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff'

WARNING: line over 80 characters
#34: FILE: scripts/qemu-binfmt-conf.sh:83:
+nanomipseb_magic='\x7fELF\x01\x02\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\xf9'

ERROR: line over 90 characters
#35: FILE: scripts/qemu-binfmt-conf.sh:84:
+nanomipseb_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff'

total: 2 errors, 2 warnings, 30 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PATCH v6 00/77] Add nanoMIPS support to QEMU

Posted by Stefan Markovic 7 years, 3 months ago

Hi,

This series seems to have some coding style problems.

Yes, we are aware of those issues:

1. "Does MAINTAINERS need an update" warning for several patches: The answer is there is no need to update MAINTAINERS file. These warnings will persist in any version of this series. We will not fix any patch. Please ignore these warnings.

2. "Lines longer than 80 characters" warning in patch 77/77: Because of the nature of the file affected by this patch, those lines longer than 80 characters needs to exist. We will not fix any patch. Please ignore these warnings.

Regards,
Stefan


________________________________
From: no-reply@patchew.org <no-reply@patchew.org>
Sent: Thursday, August 2, 2018 8:02:34 PM
To: stefan.markovic@rt-rk.com
Cc: famz@redhat.com; qemu-devel@nongnu.org; Paul Burton; Stefan Markovic; riku.voipio@iki.fi; richard.henderson@linaro.org; laurent@vivier.eu; Aleksandar Rikalo; philippe.mathieu.daude@gmail.com; Aleksandar Markovic; Petar Jovanovic; aurelien@aurel32.net
Subject: Re: [Qemu-devel] [PATCH v6 00/77] Add nanoMIPS support to QEMU

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1533219424-7627-1-git-send-email-stefan.markovic@rt-rk.com
Subject: [Qemu-devel] [PATCH v6 00/77] Add nanoMIPS support to QEMU

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
64eda72870 linux-user: Add nanoMIPS support in scripts/qemu-binfmt-conf.sh
e1a8cee4e5 linux-user: Add nanoMIPS linux user mode configuration support
df0e845f6e linux-user: Add support for statx() syscall for all platforms
32fec98ab2 linux-user: Amend support for sigaction() syscall for nanoMIPS
d4bfe737f2 linux-user: Add cpu_loop.c for nanoMIPS
4e1a987087 linux-user: Add support for nanoMIPS signal trampoline
aab0010a40 linux-user: Add signal.c for nanoMIPS
532eab67e7 linux-user: Add target_elf.h header for nanoMIPS
ddf77d7ac3 linux-user: Add target_structs.h header for nanoMIPS
84769d57a3 linux-user: Add target_cpu.h header for nanoMIPS
1fb20c1a72 linux-user: Add target_syscall.h header for nanoMIPS
d953da1580 linux-user: Add sockbits.h header for nanoMIPS
b0efc906fd linux-user: Add target_fcntl.h header for nanoMIPS
9d02c1e8eb linux-user: Update syscall_defs.h header for nanoMIPS
08fa324773 linux-user: Add termbits.h header for nanoMIPS
4821ebaae2 linux-user: Add target_signal.h header for nanoMIPS
06a0c46995 linux-user: Add syscall numbers for nanoMIPS
73be124213 target/mips: Add definition of nanoMIPS I7200 CPU
dbb82d28a4 gdbstub: Add XML support for GDB for nanoMIPS
186274afc1 gdbstub: Disable handling of nanoMIPS ISA bit in the MIPS gdbstub
7c8e071621 mips_malta: Fix semihosting argument passing for nanoMIPS bare metal
12091e1b6a mips_malta: Setup GT64120 BARs in nanoMIPS bootloader
c6323a3d69 mips_malta: Add basic nanoMIPS boot code for MIPS' Malta
0b61ee6473 elf: Don't check FCR31_NAN2008 bit for nanoMIPS
e8981250f1 elf: Relax MIPS' elf_check_arch() to accept EM_NANOMIPS too
d420a2f219 elf: Add nanoMIPS specific variations in ELF header fields
ed34b57a9c target/mips: Fix ERET/ERETNC behavior related to ADEL exception
b87394bad8 target/mips: Adjust set_pc() for nanoMIPS
e4f7784168 target/mips: Adjust set_hflags_for_handler() for nanoMIPS
2092c88d8f target/mips: Adjust exception_resume_pc() for nanoMIPS
9e4037a9d7 target/mips: Implement CP0 Config1.WR bit functionality
d5283f3176 target/mips: Add updating BadInstr, BadInstrP, BadInstrX for nanoMIPS
42416dd9c3 target/mips: Implement emulation of nanoMIPS LLWP/SCWP pair
69c9bcbca8 target/mips: Add handling of branch delay slots for nanoMIPS
e3054474bc target/mips: Add emulation of DSP ASE for nanoMIPS - part 6
a59cf3890e target/mips: Add emulation of DSP ASE for nanoMIPS - part 5
fb3e985dcd target/mips: Add emulation of DSP ASE for nanoMIPS - part 4
6ab266466c target/mips: Add emulation of DSP ASE for nanoMIPS - part 3
04a64ebd5f target/mips: Add emulation of DSP ASE for nanoMIPS - part 2
9a77858051 target/mips: Add emulation of DSP ASE for nanoMIPS - part 1
faaa015779 target/mips: Implement MT ASE support for nanoMIPS
2b4090fbff target/mips: Add emulation of nanoMIPS 32-bit branch instructions
4d8ddca2e1 target/mips: Add emulation of nanoMIPS 32-bit load and store instructions
c0fd0eea21 target/mips: Implement emulation of nanoMIPS EXTW instruction
f06df895ec target/mips: Implement emulation of nanoMIPS ROTX instruction
4bd3210913 target/mips: Add emulation of misc nanoMIPS instructions (p_lsx)
8860af1984 target/mips: Add emulation of misc nanoMIPS instructions (pool32axf)
7600a72911 target/mips: Add emulation of misc nanoMIPS instructions (pool32a0)
3a16a5a7c1 target/mips: Add emulation of nanoMIPS FP instructions
5752ef6f96 target/mips: Add emulation of nanoMIPS 48-bit instructions
8416c94b0b target/mips: Add emulation of nanoMIPS instructions MOVE.P and MOVE.PREV
5e5735abfd target/mips: Add emulation of some common nanoMIPS 32-bit instructions
111050a1a4 target/mips: Add emulation of nanoMIPS 16-bit save and restore instructions
43c3921546 target/mips: Add emulation of nanoMIPS 16-bit logic instructions
701b37e40e target/mips: Add emulation of nanoMIPS 16-bit load and store instructions
9a3ed3ef5b target/mips: Add emulation of nanoMIPS 16-bit misc instructions
46fbf41e0b target/mips: Add emulation of nanoMIPS 16-bit shift instructions
4e4bb7d89e target/mips: Add emulation of nanoMIPS 16-bit branch instructions
d025bf6095 target/mips: Add emulation of nanoMIPS 16-bit arithmetic instructions
a8e7c69cde target/mips: Add nanoMIPS decoding and extraction utilities
1a10ec177a target/mips: Add placeholder and invocation of decode_nanomips_opc()
35d6929b49 target/mips: Add nanoMIPS DSP ASE opcodes
b21f9ea00f target/mips: Add nanoMIPS base instruction set opcodes
0c8be110d8 target/mips: Add preprocessor constants for nanoMIPS
3e7d1af77a linux-user: Add preprocessor availability control to some syscalls
286793a63d linux-user: Update MIPS syscall numbers up to kernel 4.18 headers
62ca346b44 elf: Add ELF flags for MIPS machine variants
99d6e75f45 elf: Remove duplicate preprocessor constant definition
8a93d61b15 target/mips: Check ELPA flag only in some cases of MFHC0 and MTHC0
5dc3e9663e target/mips: Don't update BadVAddr register in Debug Mode
a817c46476 target/mips: Add gen_op_addr_addi()
1978cd96ba target/mips: Add CP0 BadInstrX register
1149b1e3e4 target/mips: Update some CP0 registers bit definitions
f68c083414 target/mips: Fix two instances of shadow variables
06abdd383a target/mips: Mark switch fallthroughs with interpretable comments
a52ac50ccd target/mips: Avoid case statements formulated by ranges
e2d6fa289c MAINTAINERS: Update target/mips maintainer's email addresses

=== OUTPUT BEGIN ===
Checking PATCH 1/77: MAINTAINERS: Update target/mips maintainer's email addresses...
Checking PATCH 2/77: target/mips: Avoid case statements formulated by ranges...
Checking PATCH 3/77: target/mips: Mark switch fallthroughs with interpretable comments...
Checking PATCH 4/77: target/mips: Fix two instances of shadow variables...
Checking PATCH 5/77: target/mips: Update some CP0 registers bit definitions...
Checking PATCH 6/77: target/mips: Add CP0 BadInstrX register...
Checking PATCH 7/77: target/mips: Add gen_op_addr_addi()...
Checking PATCH 8/77: target/mips: Don't update BadVAddr register in Debug Mode...
Checking PATCH 9/77: target/mips: Check ELPA flag only in some cases of MFHC0 and MTHC0...
Checking PATCH 10/77: elf: Remove duplicate preprocessor constant definition...
Checking PATCH 11/77: elf: Add ELF flags for MIPS machine variants...
Checking PATCH 12/77: linux-user: Update MIPS syscall numbers up to kernel 4.18 headers...
Checking PATCH 13/77: linux-user: Add preprocessor availability control to some syscalls...
Checking PATCH 14/77: target/mips: Add preprocessor constants for nanoMIPS...
Checking PATCH 15/77: target/mips: Add nanoMIPS base instruction set opcodes...
Checking PATCH 16/77: target/mips: Add nanoMIPS DSP ASE opcodes...
Checking PATCH 17/77: target/mips: Add placeholder and invocation of decode_nanomips_opc()...
Checking PATCH 18/77: target/mips: Add nanoMIPS decoding and extraction utilities...
Checking PATCH 19/77: target/mips: Add emulation of nanoMIPS 16-bit arithmetic instructions...
Checking PATCH 20/77: target/mips: Add emulation of nanoMIPS 16-bit branch instructions...
Checking PATCH 21/77: target/mips: Add emulation of nanoMIPS 16-bit shift instructions...
Checking PATCH 22/77: target/mips: Add emulation of nanoMIPS 16-bit misc instructions...
Checking PATCH 23/77: target/mips: Add emulation of nanoMIPS 16-bit load and store instructions...
Checking PATCH 24/77: target/mips: Add emulation of nanoMIPS 16-bit logic instructions...
Checking PATCH 25/77: target/mips: Add emulation of nanoMIPS 16-bit save and restore instructions...
Checking PATCH 26/77: target/mips: Add emulation of some common nanoMIPS 32-bit instructions...
Checking PATCH 27/77: target/mips: Add emulation of nanoMIPS instructions MOVE.P and MOVE.PREV...
Checking PATCH 28/77: target/mips: Add emulation of nanoMIPS 48-bit instructions...
Checking PATCH 29/77: target/mips: Add emulation of nanoMIPS FP instructions...
Checking PATCH 30/77: target/mips: Add emulation of misc nanoMIPS instructions (pool32a0)...
Checking PATCH 31/77: target/mips: Add emulation of misc nanoMIPS instructions (pool32axf)...
Checking PATCH 32/77: target/mips: Add emulation of misc nanoMIPS instructions (p_lsx)...
Checking PATCH 33/77: target/mips: Implement emulation of nanoMIPS ROTX instruction...
Checking PATCH 34/77: target/mips: Implement emulation of nanoMIPS EXTW instruction...
Checking PATCH 35/77: target/mips: Add emulation of nanoMIPS 32-bit load and store instructions...
Checking PATCH 36/77: target/mips: Add emulation of nanoMIPS 32-bit branch instructions...
Checking PATCH 37/77: target/mips: Implement MT ASE support for nanoMIPS...
Checking PATCH 38/77: target/mips: Add emulation of DSP ASE for nanoMIPS - part 1...
Checking PATCH 39/77: target/mips: Add emulation of DSP ASE for nanoMIPS - part 2...
Checking PATCH 40/77: target/mips: Add emulation of DSP ASE for nanoMIPS - part 3...
Checking PATCH 41/77: target/mips: Add emulation of DSP ASE for nanoMIPS - part 4...
Checking PATCH 42/77: target/mips: Add emulation of DSP ASE for nanoMIPS - part 5...
Checking PATCH 43/77: target/mips: Add emulation of DSP ASE for nanoMIPS - part 6...
Checking PATCH 44/77: target/mips: Add handling of branch delay slots for nanoMIPS...
Checking PATCH 45/77: target/mips: Implement emulation of nanoMIPS LLWP/SCWP pair...
Checking PATCH 46/77: target/mips: Add updating BadInstr, BadInstrP, BadInstrX for nanoMIPS...
Checking PATCH 47/77: target/mips: Implement CP0 Config1.WR bit functionality...
Checking PATCH 48/77: target/mips: Adjust exception_resume_pc() for nanoMIPS...
Checking PATCH 49/77: target/mips: Adjust set_hflags_for_handler() for nanoMIPS...
Checking PATCH 50/77: target/mips: Adjust set_pc() for nanoMIPS...
Checking PATCH 51/77: target/mips: Fix ERET/ERETNC behavior related to ADEL exception...
Checking PATCH 52/77: elf: Add nanoMIPS specific variations in ELF header fields...
Checking PATCH 53/77: elf: Relax MIPS' elf_check_arch() to accept EM_NANOMIPS too...
Checking PATCH 54/77: elf: Don't check FCR31_NAN2008 bit for nanoMIPS...
Checking PATCH 55/77: mips_malta: Add basic nanoMIPS boot code for MIPS' Malta...
Checking PATCH 56/77: mips_malta: Setup GT64120 BARs in nanoMIPS bootloader...
Checking PATCH 57/77: mips_malta: Fix semihosting argument passing for nanoMIPS bare metal...
Checking PATCH 58/77: gdbstub: Disable handling of nanoMIPS ISA bit in the MIPS gdbstub...
Checking PATCH 59/77: gdbstub: Add XML support for GDB for nanoMIPS...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#34:
new file mode 100644

total: 0 errors, 1 warnings, 157 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 60/77: target/mips: Add definition of nanoMIPS I7200 CPU...
Checking PATCH 61/77: linux-user: Add syscall numbers for nanoMIPS...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#16:
new file mode 100644

total: 0 errors, 1 warnings, 275 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 62/77: linux-user: Add target_signal.h header for nanoMIPS...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#16:
new file mode 100644

total: 0 errors, 1 warnings, 22 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 63/77: linux-user: Add termbits.h header for nanoMIPS...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#30:
new file mode 100644

total: 0 errors, 1 warnings, 11 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 64/77: linux-user: Update syscall_defs.h header for nanoMIPS...
Checking PATCH 65/77: linux-user: Add target_fcntl.h header for nanoMIPS...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14:
new file mode 100644

total: 0 errors, 1 warnings, 38 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 66/77: linux-user: Add sockbits.h header for nanoMIPS...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14:
new file mode 100644

total: 0 errors, 1 warnings, 1 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 67/77: linux-user: Add target_syscall.h header for nanoMIPS...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14:
new file mode 100644

total: 0 errors, 1 warnings, 30 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 68/77: linux-user: Add target_cpu.h header for nanoMIPS...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14:
new file mode 100644

total: 0 errors, 1 warnings, 21 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 69/77: linux-user: Add target_structs.h header for nanoMIPS...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15:
new file mode 100644

total: 0 errors, 1 warnings, 1 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 70/77: linux-user: Add target_elf.h header for nanoMIPS...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15:
new file mode 100644

total: 0 errors, 1 warnings, 14 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 71/77: linux-user: Add signal.c for nanoMIPS...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#113:
new file mode 100644

total: 0 errors, 1 warnings, 84 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 72/77: linux-user: Add support for nanoMIPS signal trampoline...
Checking PATCH 73/77: linux-user: Add cpu_loop.c for nanoMIPS...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#54:
new file mode 100644

total: 0 errors, 1 warnings, 33 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 74/77: linux-user: Amend support for sigaction() syscall for nanoMIPS...
Checking PATCH 75/77: linux-user: Add support for statx() syscall for all platforms...
WARNING: architecture specific defines should be avoided
#36: FILE: linux-user/syscall.c:10032:
+#if defined(__NR_statx)

WARNING: architecture specific defines should be avoided
#49: FILE: linux-user/syscall.c:10045:
+#if defined(__NR_statx)

total: 0 errors, 2 warnings, 154 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 76/77: linux-user: Add nanoMIPS linux user mode configuration support...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#60:
new file mode 100644

total: 0 errors, 1 warnings, 38 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 77/77: linux-user: Add nanoMIPS support in scripts/qemu-binfmt-conf.sh...
WARNING: line over 80 characters
#30: FILE: scripts/qemu-binfmt-conf.sh:79:
+nanomips_magic='\x7fELF\x01\x01\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\xf9\x00'

ERROR: line over 90 characters
#31: FILE: scripts/qemu-binfmt-conf.sh:80:
+nanomips_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff'

WARNING: line over 80 characters
#34: FILE: scripts/qemu-binfmt-conf.sh:83:
+nanomipseb_magic='\x7fELF\x01\x02\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\xf9'

ERROR: line over 90 characters
#35: FILE: scripts/qemu-binfmt-conf.sh:84:
+nanomipseb_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff\xff'

total: 2 errors, 2 warnings, 30 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com