hw/sd: Mark sd-card as storage device

[Qemu-devel] [PATCH] hw/sd: Mark sd-card as storage device

Posted by Guenter Roeck 7 years, 3 months ago

sd-card is currently listed as uncategorized device.
Mark it as storage device.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
 hw/sd/sd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index d4356e9..aaab15f 100644
--- a/hw/sd/sd.c
+++ b/hw/sd/sd.c
@@ -2121,6 +2121,7 @@ static void sd_class_init(ObjectClass *klass, void *data)
     dc->vmsd = &sd_vmstate;
     dc->reset = sd_reset;
     dc->bus_type = TYPE_SD_BUS;
+    set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
 
     sc->set_voltage = sd_set_voltage;
     sc->get_dat_lines = sd_get_dat_lines;
-- 
2.7.4

Re: [Qemu-devel] [PATCH] hw/sd: Mark sd-card as storage device

Posted by Philippe Mathieu-Daudé 6 years, 11 months ago

On Wed, Aug 1, 2018 at 12:37 AM Guenter Roeck <linux@roeck-us.net> wrote:
>
> sd-card is currently listed as uncategorized device.
> Mark it as storage device.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>  hw/sd/sd.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/hw/sd/sd.c b/hw/sd/sd.c
> index d4356e9..aaab15f 100644
> --- a/hw/sd/sd.c
> +++ b/hw/sd/sd.c
> @@ -2121,6 +2121,7 @@ static void sd_class_init(ObjectClass *klass, void *data)
>      dc->vmsd = &sd_vmstate;
>      dc->reset = sd_reset;
>      dc->bus_type = TYPE_SD_BUS;
> +    set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
>
>      sc->set_voltage = sd_set_voltage;
>      sc->get_dat_lines = sd_get_dat_lines;
> --
> 2.7.4
>

Re: [Qemu-devel] [PATCH] hw/sd: Mark sd-card as storage device

Posted by Stefan Hajnoczi 6 years, 11 months ago

On Thu, Nov 15, 2018 at 03:24:25PM +0100, Philippe Mathieu-Daudé wrote:
> On Wed, Aug 1, 2018 at 12:37 AM Guenter Roeck <linux@roeck-us.net> wrote:
> >
> > sd-card is currently listed as uncategorized device.
> > Mark it as storage device.
> >
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> 
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Do you send pull requests for the SD card subsystem or who will pick up
this patch?

Stefan

Re: [Qemu-devel] [PATCH-for-4.2] hw/sd: Mark sd-card as storage device

Posted by Philippe Mathieu-Daudé 6 years, 3 months ago

Hi Stefan,

On 11/15/18 4:14 PM, Stefan Hajnoczi wrote:
> On Thu, Nov 15, 2018 at 03:24:25PM +0100, Philippe Mathieu-Daudé wrote:
>> On Wed, Aug 1, 2018 at 12:37 AM Guenter Roeck <linux@roeck-us.net> wrote:
>>>
>>> sd-card is currently listed as uncategorized device.
>>> Mark it as storage device.
>>>
>>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>>
>> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> 
> Do you send pull requests for the SD card subsystem or who will pick up
> this patch?

Usually SD patches go via the ARM tree, this one could go via the
Trivial tree too (Cc'ing them).