xics: don't include "target/ppc/cpu-qom.h" in "hw/ppc/xics.h"

[Qemu-devel] [PATCH for-3.1] xics: don't include "target/ppc/cpu-qom.h" in "hw/ppc/xics.h"

Greg Kurz posted 1 patch 7 years, 3 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/153303460952.379428.12331310797981914812.stgit@bahia

Test checkpatch passed

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Test docker-quick@centos7 passed

include/hw/ppc/xics.h |    1 -
1 file changed, 1 deletion(-)

Expand all Fold all

[Qemu-devel] [PATCH for-3.1] xics: don't include "target/ppc/cpu-qom.h" in "hw/ppc/xics.h"

Posted by Greg Kurz 7 years, 3 months ago

The last user of the PowerPCCPU typedef in "hw/ppc/xics.h" vanished with
commit b1fd36c363d73969841468146ebfb9fd84a5ee52. It isn't necessary to
include "target/ppc/cpu-qom.h" there anymore.

Signed-off-by: Greg Kurz <groug@kaod.org>
---
 include/hw/ppc/xics.h |    1 -
 1 file changed, 1 deletion(-)

diff --git a/include/hw/ppc/xics.h b/include/hw/ppc/xics.h
index 6ac8a9392da6..9c2916c9b23a 100644
--- a/include/hw/ppc/xics.h
+++ b/include/hw/ppc/xics.h
@@ -29,7 +29,6 @@
 #define XICS_H
 
 #include "hw/qdev.h"
-#include "target/ppc/cpu-qom.h"
 
 #define XICS_IPI        0x2
 #define XICS_BUID       0x1

Re: [Qemu-devel] [PATCH for-3.1] xics: don't include "target/ppc/cpu-qom.h" in "hw/ppc/xics.h"

Posted by David Gibson 7 years, 3 months ago

On Tue, Jul 31, 2018 at 12:56:49PM +0200, Greg Kurz wrote:
> The last user of the PowerPCCPU typedef in "hw/ppc/xics.h" vanished with
> commit b1fd36c363d73969841468146ebfb9fd84a5ee52. It isn't necessary to
> include "target/ppc/cpu-qom.h" there anymore.
> 
> Signed-off-by: Greg Kurz <groug@kaod.org>

Applied to ppc-for-3.1.

> ---
>  include/hw/ppc/xics.h |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/hw/ppc/xics.h b/include/hw/ppc/xics.h
> index 6ac8a9392da6..9c2916c9b23a 100644
> --- a/include/hw/ppc/xics.h
> +++ b/include/hw/ppc/xics.h
> @@ -29,7 +29,6 @@
>  #define XICS_H
>  
>  #include "hw/qdev.h"
> -#include "target/ppc/cpu-qom.h"
>  
>  #define XICS_IPI        0x2
>  #define XICS_BUID       0x1
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson