block/vvfat: Disable debug message by default

[Qemu-devel] [PATCH] block/vvfat: Disable debug message by default

Thomas Huth posted 1 patch 5 years, 9 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1531926509-8280-1-git-send-email-thuth@redhat.com

Test checkpatch passed

Test docker-mingw@fedora passed

Test docker-quick@centos7 passed

block/vvfat.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH] block/vvfat: Disable debug message by default

Posted by Thomas Huth 5 years, 9 months ago

It's annoying to see this debug message every time you use vvfat.
Disable it with the DLOG() macro by default, as it is done with the
other debug messages in this file.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 block/vvfat.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/block/vvfat.c b/block/vvfat.c
index c7d2ed2..fc41841 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -1245,8 +1245,8 @@ static int vvfat_open(BlockDriverState *bs, QDict *options, int flags,
     s->fat2 = NULL;
     s->downcase_short_names = 1;
 
-    fprintf(stderr, "vvfat %s chs %d,%d,%d\n",
-            dirname, cyls, heads, secs);
+    DLOG(fprintf(stderr, "vvfat %s chs %d,%d,%d\n",
+                 dirname, cyls, heads, secs));
 
     s->sector_count = cyls * heads * secs - s->offset_to_bootsector;
 
-- 
1.8.3.1

Re: [Qemu-devel] [Qemu-block] [PATCH] block/vvfat: Disable debug message by default

Posted by John Snow 5 years, 9 months ago


On 07/18/2018 11:08 AM, Thomas Huth wrote:
> It's annoying to see this debug message every time you use vvfat.
> Disable it with the DLOG() macro by default, as it is done with the
> other debug messages in this file.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  block/vvfat.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/block/vvfat.c b/block/vvfat.c
> index c7d2ed2..fc41841 100644
> --- a/block/vvfat.c
> +++ b/block/vvfat.c
> @@ -1245,8 +1245,8 @@ static int vvfat_open(BlockDriverState *bs, QDict *options, int flags,
>      s->fat2 = NULL;
>      s->downcase_short_names = 1;
>  
> -    fprintf(stderr, "vvfat %s chs %d,%d,%d\n",
> -            dirname, cyls, heads, secs);
> +    DLOG(fprintf(stderr, "vvfat %s chs %d,%d,%d\n",
> +                 dirname, cyls, heads, secs));
>  
>      s->sector_count = cyls * heads * secs - s->offset_to_bootsector;
>  
> 

Makes sense as a minimal change without doing more... real work here.

Reviewed-by: John Snow <jsnow@redhat.com>

Re: [Qemu-devel] [PATCH] block/vvfat: Disable debug message by default

Posted by Kevin Wolf 5 years, 9 months ago

Am 18.07.2018 um 17:08 hat Thomas Huth geschrieben:
> It's annoying to see this debug message every time you use vvfat.
> Disable it with the DLOG() macro by default, as it is done with the
> other debug messages in this file.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>

Thanks, applied to the block branch.

Kevin