qapi/block-core.json: Add missing documentation for blklogwrites log-append option

[Qemu-devel] [PATCH] qapi/block-core.json: Add missing documentation for blklogwrites log-append option

Posted by Ari Sundholm 7 years, 4 months ago

This was accidentally omitted. Thanks to Eric Blake for spotting this.

Signed-off-by: Ari Sundholm <ari@tuxera.com>
---
 qapi/block-core.json | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/qapi/block-core.json b/qapi/block-core.json
index 38b3125..62a92fa 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -3057,6 +3057,8 @@
 # @log-sector-size: sector size used in logging writes to @file, determines
 #                   granularity of offsets and sizes of writes (default: 512)
 #
+# @log-append:      append to an existing log (default: false)
+#
 # @log-super-update-interval: interval of write requests after which the log
 #                             super block is updated to disk (default: 4096)
 #
-- 
2.7.4

Re: [Qemu-devel] [PATCH] qapi/block-core.json: Add missing documentation for blklogwrites log-append option

Posted by Eric Blake 7 years, 4 months ago

On 07/06/2018 07:21 AM, Ari Sundholm wrote:
> This was accidentally omitted. Thanks to Eric Blake for spotting this.
> 
> Signed-off-by: Ari Sundholm <ari@tuxera.com>
> ---
>   qapi/block-core.json | 2 ++
>   1 file changed, 2 insertions(+)
> 

Reviewed-by: Eric Blake <eblake@redhat.com>

> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 38b3125..62a92fa 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -3057,6 +3057,8 @@
>   # @log-sector-size: sector size used in logging writes to @file, determines
>   #                   granularity of offsets and sizes of writes (default: 512)
>   #
> +# @log-append:      append to an existing log (default: false)
> +#
>   # @log-super-update-interval: interval of write requests after which the log
>   #                             super block is updated to disk (default: 4096)
>   #
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [PATCH] qapi/block-core.json: Add missing documentation for blklogwrites log-append option

Posted by Markus Armbruster 7 years, 3 months ago

Ari Sundholm <ari@tuxera.com> writes:

> This was accidentally omitted. Thanks to Eric Blake for spotting this.
>
> Signed-off-by: Ari Sundholm <ari@tuxera.com>
> ---
>  qapi/block-core.json | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 38b3125..62a92fa 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -3057,6 +3057,8 @@
>  # @log-sector-size: sector size used in logging writes to @file, determines
>  #                   granularity of offsets and sizes of writes (default: 512)
>  #
> +# @log-append:      append to an existing log (default: false)
> +#
>  # @log-super-update-interval: interval of write requests after which the log
>  #                             super block is updated to disk (default: 4096)
>  #

Applied to qapi-next.  Thanks!

Re: [Qemu-devel] [PATCH] qapi/block-core.json: Add missing documentation for blklogwrites log-append option

Posted by Ari Sundholm 7 years, 3 months ago

On 07/09/2018 10:07 AM, Markus Armbruster wrote:
> Ari Sundholm <ari@tuxera.com> writes:
> 
>> This was accidentally omitted. Thanks to Eric Blake for spotting this.
>>
>> Signed-off-by: Ari Sundholm <ari@tuxera.com>
>> ---
>>   qapi/block-core.json | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/qapi/block-core.json b/qapi/block-core.json
>> index 38b3125..62a92fa 100644
>> --- a/qapi/block-core.json
>> +++ b/qapi/block-core.json
>> @@ -3057,6 +3057,8 @@
>>   # @log-sector-size: sector size used in logging writes to @file, determines
>>   #                   granularity of offsets and sizes of writes (default: 512)
>>   #
>> +# @log-append:      append to an existing log (default: false)
>> +#
>>   # @log-super-update-interval: interval of write requests after which the log
>>   #                             super block is updated to disk (default: 4096)
>>   #
> 
> Applied to qapi-next.  Thanks!
> 

Thanks. Does this mean that the patch be queued for 3.0 or should I take 
some additional steps to ensure this?

Re: [Qemu-devel] [PATCH] qapi/block-core.json: Add missing documentation for blklogwrites log-append option

Posted by Markus Armbruster 7 years, 3 months ago

Ari Sundholm <ari@tuxera.com> writes:

> On 07/09/2018 10:07 AM, Markus Armbruster wrote:
>> Ari Sundholm <ari@tuxera.com> writes:
>>
>>> This was accidentally omitted. Thanks to Eric Blake for spotting this.
>>>
>>> Signed-off-by: Ari Sundholm <ari@tuxera.com>
>>> ---
>>>   qapi/block-core.json | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/qapi/block-core.json b/qapi/block-core.json
>>> index 38b3125..62a92fa 100644
>>> --- a/qapi/block-core.json
>>> +++ b/qapi/block-core.json
>>> @@ -3057,6 +3057,8 @@
>>>   # @log-sector-size: sector size used in logging writes to @file, determines
>>>   #                   granularity of offsets and sizes of writes (default: 512)
>>>   #
>>> +# @log-append:      append to an existing log (default: false)
>>> +#
>>>   # @log-super-update-interval: interval of write requests after which the log
>>>   #                             super block is updated to disk (default: 4096)
>>>   #
>>
>> Applied to qapi-next.  Thanks!
>>
>
> Thanks. Does this mean that the patch be queued for 3.0 or should I
> take some additional steps to ensure this?

When a maintainer (like me) accepts your patch, he also accepts
resposibility to get it merged into master.  The patch submitter (you)
should not have to do anything to get that done.

"Should" only because maintainers aren't infallible :) I keep tracking
my own patches until they reach master.  Pretty much always they just
do.  Only once in a great while I have to ask a maintainer what's up.

In this case, your patch should be in my next QAPI pull request, and you
should receive a copy.