[Qemu-devel] [PATCH v2 08/20] ioapic: fix up includes

Michael S. Tsirkin posted 20 patches 7 years, 5 months ago
[Qemu-devel] [PATCH v2 08/20] ioapic: fix up includes
Posted by Michael S. Tsirkin 7 years, 5 months ago
include files shouldn't have the "include/" part,
that is implied.

Also, drop an unused include.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 hw/intc/ioapic.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c
index 36139a4..c45f073 100644
--- a/hw/intc/ioapic.c
+++ b/hw/intc/ioapic.c
@@ -28,9 +28,8 @@
 #include "hw/i386/apic.h"
 #include "hw/i386/ioapic.h"
 #include "hw/i386/ioapic_internal.h"
-#include "include/hw/pci/msi.h"
+#include "hw/pci/msi.h"
 #include "sysemu/kvm.h"
-#include "target/i386/cpu.h"
 #include "hw/i386/apic-msidef.h"
 #include "hw/i386/x86-iommu.h"
 #include "trace.h"
-- 
MST


Re: [Qemu-devel] [PATCH v2 08/20] ioapic: fix up includes
Posted by Philippe Mathieu-Daudé 7 years, 5 months ago
On 05/25/2018 01:47 PM, Michael S. Tsirkin wrote:
> include files shouldn't have the "include/" part,
> that is implied.
> 
> Also, drop an unused include.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> ---
>  hw/intc/ioapic.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/hw/intc/ioapic.c b/hw/intc/ioapic.c
> index 36139a4..c45f073 100644
> --- a/hw/intc/ioapic.c
> +++ b/hw/intc/ioapic.c
> @@ -28,9 +28,8 @@
>  #include "hw/i386/apic.h"
>  #include "hw/i386/ioapic.h"
>  #include "hw/i386/ioapic_internal.h"
> -#include "include/hw/pci/msi.h"
> +#include "hw/pci/msi.h"
>  #include "sysemu/kvm.h"
> -#include "target/i386/cpu.h"
>  #include "hw/i386/apic-msidef.h"
>  #include "hw/i386/x86-iommu.h"
>  #include "trace.h"
>