libqtest: verify QEMU exit status

[Qemu-devel] [PATCH v4 0/3] libqtest: verify QEMU exit status

Michael S. Tsirkin posted 3 patches 7 years, 8 months ago

Download series mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1527186303-192100-1-git-send-email-mst@redhat.com

Test checkpatch passed

Test docker-mingw@fedora passed

Test docker-quick@centos7 passed

Test s390x passed

include/qemu/osdep.h | 10 ++++++++++
tests/libqtest.c     | 19 ++++++++++++++++++-
2 files changed, 28 insertions(+), 1 deletion(-)

Expand all Fold all

[Qemu-devel] [PATCH v4 0/3] libqtest: verify QEMU exit status

Posted by Michael S. Tsirkin 7 years, 8 months ago

Whenever QEMU coredumps, the test would previously succeed.
With this patchset applied, one sees:
    assertion failed: !WCOREDUMP(wstatus)

Changes from v3:
- add osdep stubs for non-linux platforms, suggested by Thomas

Changes from v2:
- bugfix
- assert returned pid
- rework complex asserts for clarity

Changes from v1:
- drop SIGTERM as suggested by Eric

Michael S. Tsirkin (3):
  osdep: add wait.h compat macros
  libqtest: fail if child coredumps
  libqtest: add more exit status checks

 include/qemu/osdep.h | 10 ++++++++++
 tests/libqtest.c     | 19 ++++++++++++++++++-
 2 files changed, 28 insertions(+), 1 deletion(-)

-- 
MST