[Qemu-devel] [PULL 00/28] pc, pci, virtio, vhost: fixes, features

Michael S. Tsirkin posted 28 patches 7 years, 5 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1527086545-68024-1-git-send-email-mst@redhat.com
Test checkpatch failed
Test docker-mingw@fedora passed
Test docker-quick@centos7 passed
Test s390x passed
docs/specs/pci-ids.txt                             |   1 +
docs/virtio-balloon-stats.txt                      |   2 +
include/hw/i386/intel_iommu.h                      |  19 +-
include/hw/mem/nvdimm.h                            |   2 +-
include/hw/pci/pci.h                               |   1 +
include/hw/virtio/virtio-bus.h                     |   2 +
include/hw/virtio/virtio.h                         |   2 +
include/qemu/iova-tree.h                           | 134 ++++
.../standard-headers}/asm-x86/kvm_para.h           |  49 +-
include/standard-headers/linux/virtio_balloon.h    |   4 +-
include/sysemu/kvm.h                               |   1 -
linux-headers/asm-arm/bitsperlong.h                |   1 +
linux-headers/asm-arm/kvm_para.h                   |   2 -
linux-headers/asm-arm64/bitsperlong.h              |  24 +
linux-headers/asm-arm64/kvm_para.h                 |   1 -
linux-headers/asm-generic/bitsperlong.h            |  16 +
linux-headers/asm-generic/kvm_para.h               |   4 -
linux-headers/asm-generic/unistd.h                 | 781 +++++++++++++++++++++
linux-headers/asm-mips/bitsperlong.h               |   9 +
linux-headers/asm-mips/kvm.h                       |  25 +-
linux-headers/asm-mips/kvm_para.h                  |   5 -
linux-headers/asm-mips/sgidefs.h                   |  45 ++
linux-headers/asm-mips/unistd.h                    |  44 +-
linux-headers/asm-powerpc/bitsperlong.h            |  13 +
linux-headers/asm-powerpc/epapr_hcalls.h           |  99 ---
linux-headers/asm-powerpc/kvm_para.h               |  98 ---
linux-headers/asm-s390/bitsperlong.h               |  14 +
linux-headers/asm-s390/kvm_para.h                  |   8 -
linux-headers/asm-s390/unistd_32.h                 |   1 +
linux-headers/asm-s390/unistd_64.h                 |   1 +
linux-headers/asm-x86/bitsperlong.h                |  14 +
linux-headers/linux/kvm_para.h                     |  35 -
target/i386/cpu.h                                  |   2 -
target/i386/kvm_i386.h                             |   6 -
contrib/libvhost-user/libvhost-user.c              |  16 +-
contrib/vhost-user-blk/vhost-user-blk.c            |   7 +
hw/i386/intel_iommu.c                              | 396 ++++++++---
hw/i386/kvm/clock.c                                |   2 +-
hw/mem/nvdimm.c                                    |   2 +-
hw/pci-host/q35.c                                  |  17 +-
hw/virtio/vhost-user.c                             |  45 +-
hw/virtio/vhost.c                                  |   7 +
hw/virtio/virtio-balloon.c                         |   2 +
hw/virtio/virtio-pci.c                             |  22 +
hw/virtio/virtio.c                                 |  13 +
net/vhost-user.c                                   |  38 +-
target/i386/cpu.c                                  |   4 +-
target/i386/kvm.c                                  |   4 +-
util/iova-tree.c                                   | 114 +++
MAINTAINERS                                        |   6 +
hw/i386/trace-events                               |   5 +-
hw/virtio/trace-events                             |   1 +
scripts/update-linux-headers.sh                    |  20 +-
util/Makefile.objs                                 |   1 +
54 files changed, 1731 insertions(+), 456 deletions(-)
create mode 100644 include/qemu/iova-tree.h
rename {linux-headers => include/standard-headers}/asm-x86/kvm_para.h (80%)
create mode 100644 linux-headers/asm-arm/bitsperlong.h
delete mode 100644 linux-headers/asm-arm/kvm_para.h
create mode 100644 linux-headers/asm-arm64/bitsperlong.h
delete mode 100644 linux-headers/asm-arm64/kvm_para.h
create mode 100644 linux-headers/asm-generic/bitsperlong.h
delete mode 100644 linux-headers/asm-generic/kvm_para.h
create mode 100644 linux-headers/asm-generic/unistd.h
create mode 100644 linux-headers/asm-mips/bitsperlong.h
delete mode 100644 linux-headers/asm-mips/kvm_para.h
create mode 100644 linux-headers/asm-mips/sgidefs.h
create mode 100644 linux-headers/asm-powerpc/bitsperlong.h
delete mode 100644 linux-headers/asm-powerpc/epapr_hcalls.h
delete mode 100644 linux-headers/asm-powerpc/kvm_para.h
create mode 100644 linux-headers/asm-s390/bitsperlong.h
delete mode 100644 linux-headers/asm-s390/kvm_para.h
create mode 100644 linux-headers/asm-x86/bitsperlong.h
delete mode 100644 linux-headers/linux/kvm_para.h
create mode 100644 util/iova-tree.c
[Qemu-devel] [PULL 00/28] pc, pci, virtio, vhost: fixes, features
Posted by Michael S. Tsirkin 7 years, 5 months ago
The following changes since commit 4f50c1673a89b07f376ce5c42d22d79a79cd466d:

  Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request' into staging (2018-05-22 09:43:58 +0100)

are available in the git repository at:

  git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream

for you to fetch changes up to 63b88968f139b6a77f2f81e6f1eedf70c0170a85:

  intel-iommu: rework the page walk logic (2018-05-23 17:34:05 +0300)

----------------------------------------------------------------
pc, pci, virtio, vhost: fixes, features

Beginning of merging vDPA, new PCI ID, a new virtio balloon stat, intel
iommu rework fixing a couple of security problems (no CVEs yet), fixes
all over the place.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

----------------------------------------------------------------
Changpeng Liu (1):
      contrib/vhost-user-blk: enable protocol feature for vhost-user-blk

Dr. David Alan Gilbert (2):
      vhost-user+postcopy: Use qemu_set_nonblock
      libvhost-user: Send messages with no data

Gerd Hoffmann (1):
      allocate pci id for mdpy

Jonathan Helman (1):
      virtio-balloon: add hugetlb page allocation counts

Michael S. Tsirkin (7):
      update-linux-headers.sh: drop kvm_para.h hacks
      include/standard-headers: add asm-x86/kvm_para.h
      x86/cpu: use standard-headers/asm-x86.kvm_para.h
      linux-headers: drop kvm_para.h
      update-linux-headers.sh: unistd.h, kvm consistency
      linux-headers: add unistd.h on all arches
      linux-headers: add kvm header for mips

Peter Xu (10):
      vhost: add trace for IOTLB miss
      intel-iommu: send PSI always even if across PDEs
      intel-iommu: remove IntelIOMMUNotifierNode
      intel-iommu: add iommu lock
      intel-iommu: only do page walk for MAP notifiers
      intel-iommu: introduce vtd_page_walk_info
      intel-iommu: pass in address space when page walk
      intel-iommu: trace domain id during page walk
      util: implement simple iova tree
      intel-iommu: rework the page walk logic

Richard Henderson (1):
      hw/virtio: Fix brace Werror with clang 6.0.0

Ross Zwisler (1):
      nvdimm: fix typo in label-size definition

Tiwei Bie (3):
      vhost-user: add Net prefix to internal state structure
      vhost-user: support receiving file descriptors in slave_read
      virtio: support setting memory region based host notifier

Zihan Yang (1):
      hw/pci-host/q35: Replace hardcoded value with macro

 docs/specs/pci-ids.txt                             |   1 +
 docs/virtio-balloon-stats.txt                      |   2 +
 include/hw/i386/intel_iommu.h                      |  19 +-
 include/hw/mem/nvdimm.h                            |   2 +-
 include/hw/pci/pci.h                               |   1 +
 include/hw/virtio/virtio-bus.h                     |   2 +
 include/hw/virtio/virtio.h                         |   2 +
 include/qemu/iova-tree.h                           | 134 ++++
 .../standard-headers}/asm-x86/kvm_para.h           |  49 +-
 include/standard-headers/linux/virtio_balloon.h    |   4 +-
 include/sysemu/kvm.h                               |   1 -
 linux-headers/asm-arm/bitsperlong.h                |   1 +
 linux-headers/asm-arm/kvm_para.h                   |   2 -
 linux-headers/asm-arm64/bitsperlong.h              |  24 +
 linux-headers/asm-arm64/kvm_para.h                 |   1 -
 linux-headers/asm-generic/bitsperlong.h            |  16 +
 linux-headers/asm-generic/kvm_para.h               |   4 -
 linux-headers/asm-generic/unistd.h                 | 781 +++++++++++++++++++++
 linux-headers/asm-mips/bitsperlong.h               |   9 +
 linux-headers/asm-mips/kvm.h                       |  25 +-
 linux-headers/asm-mips/kvm_para.h                  |   5 -
 linux-headers/asm-mips/sgidefs.h                   |  45 ++
 linux-headers/asm-mips/unistd.h                    |  44 +-
 linux-headers/asm-powerpc/bitsperlong.h            |  13 +
 linux-headers/asm-powerpc/epapr_hcalls.h           |  99 ---
 linux-headers/asm-powerpc/kvm_para.h               |  98 ---
 linux-headers/asm-s390/bitsperlong.h               |  14 +
 linux-headers/asm-s390/kvm_para.h                  |   8 -
 linux-headers/asm-s390/unistd_32.h                 |   1 +
 linux-headers/asm-s390/unistd_64.h                 |   1 +
 linux-headers/asm-x86/bitsperlong.h                |  14 +
 linux-headers/linux/kvm_para.h                     |  35 -
 target/i386/cpu.h                                  |   2 -
 target/i386/kvm_i386.h                             |   6 -
 contrib/libvhost-user/libvhost-user.c              |  16 +-
 contrib/vhost-user-blk/vhost-user-blk.c            |   7 +
 hw/i386/intel_iommu.c                              | 396 ++++++++---
 hw/i386/kvm/clock.c                                |   2 +-
 hw/mem/nvdimm.c                                    |   2 +-
 hw/pci-host/q35.c                                  |  17 +-
 hw/virtio/vhost-user.c                             |  45 +-
 hw/virtio/vhost.c                                  |   7 +
 hw/virtio/virtio-balloon.c                         |   2 +
 hw/virtio/virtio-pci.c                             |  22 +
 hw/virtio/virtio.c                                 |  13 +
 net/vhost-user.c                                   |  38 +-
 target/i386/cpu.c                                  |   4 +-
 target/i386/kvm.c                                  |   4 +-
 util/iova-tree.c                                   | 114 +++
 MAINTAINERS                                        |   6 +
 hw/i386/trace-events                               |   5 +-
 hw/virtio/trace-events                             |   1 +
 scripts/update-linux-headers.sh                    |  20 +-
 util/Makefile.objs                                 |   1 +
 54 files changed, 1731 insertions(+), 456 deletions(-)
 create mode 100644 include/qemu/iova-tree.h
 rename {linux-headers => include/standard-headers}/asm-x86/kvm_para.h (80%)
 create mode 100644 linux-headers/asm-arm/bitsperlong.h
 delete mode 100644 linux-headers/asm-arm/kvm_para.h
 create mode 100644 linux-headers/asm-arm64/bitsperlong.h
 delete mode 100644 linux-headers/asm-arm64/kvm_para.h
 create mode 100644 linux-headers/asm-generic/bitsperlong.h
 delete mode 100644 linux-headers/asm-generic/kvm_para.h
 create mode 100644 linux-headers/asm-generic/unistd.h
 create mode 100644 linux-headers/asm-mips/bitsperlong.h
 delete mode 100644 linux-headers/asm-mips/kvm_para.h
 create mode 100644 linux-headers/asm-mips/sgidefs.h
 create mode 100644 linux-headers/asm-powerpc/bitsperlong.h
 delete mode 100644 linux-headers/asm-powerpc/epapr_hcalls.h
 delete mode 100644 linux-headers/asm-powerpc/kvm_para.h
 create mode 100644 linux-headers/asm-s390/bitsperlong.h
 delete mode 100644 linux-headers/asm-s390/kvm_para.h
 create mode 100644 linux-headers/asm-x86/bitsperlong.h
 delete mode 100644 linux-headers/linux/kvm_para.h
 create mode 100644 util/iova-tree.c


Re: [Qemu-devel] [PULL 00/28] pc, pci, virtio, vhost: fixes, features
Posted by no-reply@patchew.org 7 years, 5 months ago
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1527086545-68024-1-git-send-email-mst@redhat.com
Subject: [Qemu-devel] [PULL 00/28] pc, pci, virtio, vhost: fixes, features

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/1527086545-68024-1-git-send-email-mst@redhat.com -> patchew/1527086545-68024-1-git-send-email-mst@redhat.com
 t [tag update]            patchew/20180523031805.27101-1-peterx@redhat.com -> patchew/20180523031805.27101-1-peterx@redhat.com
Switched to a new branch 'test'
4c9a6a2ffe intel-iommu: rework the page walk logic
5650cac9fb util: implement simple iova tree
88534312e0 intel-iommu: trace domain id during page walk
8ac709ee1c intel-iommu: pass in address space when page walk
1947a6e8f5 intel-iommu: introduce vtd_page_walk_info
9625294a9c intel-iommu: only do page walk for MAP notifiers
dde4ff462d intel-iommu: add iommu lock
f2f4e4a75c intel-iommu: remove IntelIOMMUNotifierNode
e38afacae2 intel-iommu: send PSI always even if across PDEs
0d36159676 nvdimm: fix typo in label-size definition
471bf9c78b contrib/vhost-user-blk: enable protocol feature for vhost-user-blk
a9ae0b2add hw/virtio: Fix brace Werror with clang 6.0.0
7cbfe1743d libvhost-user: Send messages with no data
195b5bd713 vhost-user+postcopy: Use qemu_set_nonblock
011e39054e virtio: support setting memory region based host notifier
7ecf626817 vhost-user: support receiving file descriptors in slave_read
2f00a166ec vhost-user: add Net prefix to internal state structure
d30090016d linux-headers: add kvm header for mips
6d6f92c8b0 linux-headers: add unistd.h on all arches
0e21fd6465 update-linux-headers.sh: unistd.h, kvm consistency
082496d2b5 linux-headers: drop kvm_para.h
0365135fac x86/cpu: use standard-headers/asm-x86.kvm_para.h
2317795f33 include/standard-headers: add asm-x86/kvm_para.h
1be5f83d10 update-linux-headers.sh: drop kvm_para.h hacks
964e0ee4cf vhost: add trace for IOTLB miss
e679e9a70f virtio-balloon: add hugetlb page allocation counts
a800e0a24e allocate pci id for mdpy
b33c444024 hw/pci-host/q35: Replace hardcoded value with macro

=== OUTPUT BEGIN ===
Checking PATCH 1/28: hw/pci-host/q35: Replace hardcoded value with macro...
WARNING: line over 80 characters
#27: FILE: hw/pci-host/q35.c:538:
+                             mch->pci_address_space, MCH_HOST_BRIDGE_SMRAM_C_BASE,

WARNING: line over 80 characters
#29: FILE: hw/pci-host/q35.c:540:
+    memory_region_add_subregion_overlap(mch->system_memory, MCH_HOST_BRIDGE_SMRAM_C_BASE,

total: 0 errors, 2 warnings, 35 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/28: allocate pci id for mdpy...
Checking PATCH 3/28: virtio-balloon: add hugetlb page allocation counts...
Checking PATCH 4/28: vhost: add trace for IOTLB miss...
Checking PATCH 5/28: update-linux-headers.sh: drop kvm_para.h hacks...
ERROR: line over 90 characters
#48: FILE: scripts/update-linux-headers.sh:121:
+        cp_portable "$tmpdir/include/asm/kvm_para.h" "$output/include/standard-headers/asm-$arch"

total: 1 errors, 0 warnings, 44 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 6/28: include/standard-headers: add asm-x86/kvm_para.h...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13: 
new file mode 100644

total: 0 errors, 1 warnings, 121 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 7/28: x86/cpu: use standard-headers/asm-x86.kvm_para.h...
Checking PATCH 8/28: linux-headers: drop kvm_para.h...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#12: 
deleted file mode 100644

total: 0 errors, 1 warnings, 0 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 9/28: update-linux-headers.sh: unistd.h, kvm consistency...
Checking PATCH 10/28: linux-headers: add unistd.h on all arches...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14: 
new file mode 100644

total: 0 errors, 1 warnings, 1017 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 11/28: linux-headers: add kvm header for mips...
Checking PATCH 12/28: vhost-user: add Net prefix to internal state structure...
Checking PATCH 13/28: vhost-user: support receiving file descriptors in slave_read...
Checking PATCH 14/28: virtio: support setting memory region based host notifier...
Checking PATCH 15/28: vhost-user+postcopy: Use qemu_set_nonblock...
Checking PATCH 16/28: libvhost-user: Send messages with no data...
Checking PATCH 17/28: hw/virtio: Fix brace Werror with clang 6.0.0...
Checking PATCH 18/28: contrib/vhost-user-blk: enable protocol feature for vhost-user-blk...
Checking PATCH 19/28: nvdimm: fix typo in label-size definition...
Checking PATCH 20/28: intel-iommu: send PSI always even if across PDEs...
Checking PATCH 21/28: intel-iommu: remove IntelIOMMUNotifierNode...
Checking PATCH 22/28: intel-iommu: add iommu lock...
Checking PATCH 23/28: intel-iommu: only do page walk for MAP notifiers...
Checking PATCH 24/28: intel-iommu: introduce vtd_page_walk_info...
Checking PATCH 25/28: intel-iommu: pass in address space when page walk...
Checking PATCH 26/28: intel-iommu: trace domain id during page walk...
Checking PATCH 27/28: util: implement simple iova tree...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#32: 
new file mode 100644

total: 0 errors, 1 warnings, 265 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 28/28: intel-iommu: rework the page walk logic...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Re: [Qemu-devel] [PULL 00/28] pc, pci, virtio, vhost: fixes, features
Posted by Peter Maydell 7 years, 5 months ago
On 23 May 2018 at 15:42, Michael S. Tsirkin <mst@redhat.com> wrote:
> The following changes since commit 4f50c1673a89b07f376ce5c42d22d79a79cd466d:
>
>   Merge remote-tracking branch 'remotes/ehabkost/tags/x86-next-pull-request' into staging (2018-05-22 09:43:58 +0100)
>
> are available in the git repository at:
>
>   git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream
>
> for you to fetch changes up to 63b88968f139b6a77f2f81e6f1eedf70c0170a85:
>
>   intel-iommu: rework the page walk logic (2018-05-23 17:34:05 +0300)
>
> ----------------------------------------------------------------
> pc, pci, virtio, vhost: fixes, features
>
> Beginning of merging vDPA, new PCI ID, a new virtio balloon stat, intel
> iommu rework fixing a couple of security problems (no CVEs yet), fixes
> all over the place.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>

Applied, thanks.

-- PMM