Hi~ All~

COLO Frame, block replication and COLO proxy(colo-compare,filter-mirror,
filter-redirector,filter-rewriter) have been exist in qemu
for long time, it's time to integrate these three parts to make COLO really works.

In this series, we have some optimizations for COLO frame, including separating the
process of saving ram and device state, using an COLO_EXIT event to notify users that
VM exits COLO, for these parts, most of them have been reviewed long time ago in old version,
but since this series have just rebased on upstream which had merged a new series of migration,
parts of pathes in this series deserve review again.

We use notifier/callback method for COLO compare to notify COLO frame about
net packets inconsistent event, and add a handle_event method for NetFilterClass to
help COLO frame to notify filters and colo-compare about checkpoint/failover event, 
it is flexible.

For the neweset version, please refer to:
https://github.com/zhangckid/qemu/tree/qemu-colo-18may1-rebase

Please review, thanks.

V7:
 - Addressed Markus's comments in 11/17.
 - Rebased on upstream.

V6:
 - Addressed Eric Blake's comments, use the enum to feedback in patch 11/17.
 - Fixed QAPI command separator problem in patch 11/17.


Zhang Chen (12):
  filter-rewriter: fix memory leak for connection in
    connection_track_table
  colo-compare: implement the process of checkpoint
  colo-compare: use notifier to notify packets comparing result
  COLO: integrate colo compare with colo frame
  COLO: Add block replication into colo process
  COLO: Remove colo_state migration struct
  COLO: Load dirty pages into SVM's RAM cache firstly
  ram/COLO: Record the dirty pages that SVM received
  COLO: Flush memory data from ram cache
  qapi: Add new command to query colo status
  filter: Add handle_event method for NetFilterClass
  filter-rewriter: handle checkpoint and failover event

zhanghailiang (5):
  qmp event: Add COLO_EXIT event to notify users while exited COLO
  savevm: split the process of different stages for loadvm/savevm
  COLO: flush host dirty ram from cache
  COLO: notify net filters about checkpoint/failover event
  COLO: quick failover process by kick COLO thread

 include/exec/ram_addr.h  |   1 +
 include/migration/colo.h |  11 ++-
 include/net/filter.h     |   5 ++
 migration/Makefile.objs  |   2 +-
 migration/colo-comm.c    |  76 ----------------
 migration/colo.c         | 219 ++++++++++++++++++++++++++++++++++++++++++++---
 migration/migration.c    |  38 +++++++-
 migration/ram.c          | 183 ++++++++++++++++++++++++++++++++++++++-
 migration/ram.h          |   4 +
 migration/savevm.c       |  55 ++++++++++--
 migration/savevm.h       |   5 ++
 migration/trace-events   |   3 +
 net/colo-compare.c       | 108 +++++++++++++++++++++--
 net/colo-compare.h       |  24 ++++++
 net/colo.h               |   4 +
 net/filter-rewriter.c    | 109 +++++++++++++++++++++--
 net/filter.c             |  17 ++++
 net/net.c                |  28 ++++++
 qapi/migration.json      |  70 +++++++++++++++
 vl.c                     |   2 -
 20 files changed, 846 insertions(+), 118 deletions(-)
 delete mode 100644 migration/colo-comm.c
 create mode 100644 net/colo-compare.h

-- 
2.7.4

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1526268228-27951-1-git-send-email-zhangckid@gmail.com
Subject: [Qemu-devel] [PATCH V7 00/17] COLO: integrate colo frame with block replication and COLO proxy

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/1526268228-27951-1-git-send-email-zhangckid@gmail.com -> patchew/1526268228-27951-1-git-send-email-zhangckid@gmail.com
 t [tag update]            patchew/20180513085032.27773-1-sw@weilnetz.de -> patchew/20180513085032.27773-1-sw@weilnetz.de
Switched to a new branch 'test'
d4ddea2a1a COLO: quick failover process by kick COLO thread
0f2e1983ea COLO: notify net filters about checkpoint/failover event
c122b558f5 filter-rewriter: handle checkpoint and failover event
191fa37245 filter: Add handle_event method for NetFilterClass
c12e3da392 COLO: flush host dirty ram from cache
2324bc5e36 savevm: split the process of different stages for loadvm/savevm
19f435ca08 qapi: Add new command to query colo status
9fa29026c0 qmp event: Add COLO_EXIT event to notify users while exited COLO
3ec0bd3b60 COLO: Flush memory data from ram cache
445775dcd7 ram/COLO: Record the dirty pages that SVM received
f14876f270 COLO: Load dirty pages into SVM's RAM cache firstly
f03200f394 COLO: Remove colo_state migration struct
cdeb27e766 COLO: Add block replication into colo process
be854ac29e COLO: integrate colo compare with colo frame
551fe70729 colo-compare: use notifier to notify packets comparing result
6c5ccec4e6 colo-compare: implement the process of checkpoint
922a703d44 filter-rewriter: fix memory leak for connection in connection_track_table

=== OUTPUT BEGIN ===
Checking PATCH 1/17: filter-rewriter: fix memory leak for connection in connection_track_table...
Checking PATCH 2/17: colo-compare: implement the process of checkpoint...
Checking PATCH 3/17: colo-compare: use notifier to notify packets comparing result...
Checking PATCH 4/17: COLO: integrate colo compare with colo frame...
Checking PATCH 5/17: COLO: Add block replication into colo process...
Checking PATCH 6/17: COLO: Remove colo_state migration struct...
Checking PATCH 7/17: COLO: Load dirty pages into SVM's RAM cache firstly...
Checking PATCH 8/17: ram/COLO: Record the dirty pages that SVM received...
Checking PATCH 9/17: COLO: Flush memory data from ram cache...
Checking PATCH 10/17: qmp event: Add COLO_EXIT event to notify users while exited COLO...
Checking PATCH 11/17: qapi: Add new command to query colo status...
ERROR: suspect code indent for conditional statements (4, 9)
#38: FILE: migration/colo.c:250:
+    } else if (get_colo_mode() == COLO_MODE_PRIMARY) {
+         state = migrate_get_current()->state;

total: 1 errors, 0 warnings, 82 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 12/17: savevm: split the process of different stages for loadvm/savevm...
Checking PATCH 13/17: COLO: flush host dirty ram from cache...
Checking PATCH 14/17: filter: Add handle_event method for NetFilterClass...
Checking PATCH 15/17: filter-rewriter: handle checkpoint and failover event...
Checking PATCH 16/17: COLO: notify net filters about checkpoint/failover event...
Checking PATCH 17/17: COLO: quick failover process by kick COLO thread...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com