[v2] virtio-balloon: fix internal stat name array to match Linux kernel

[Qemu-devel] [PATCH V2 0/1] virtio-balloon: fix internal stat name array to match Linux kernel

Posted by Thomas Tai 7 years, 5 months ago

Hi Michael,
As you have suggested I have imported the kernel header
file and use the new macro to create the string array.
Would you kindly review the patch for me? Please feel
free to comment.

Thank you,
Thomas

Re: [Qemu-devel] [PATCH V2 0/1] virtio-balloon: fix internal stat name array to match Linux kernel

Posted by no-reply@patchew.org 7 years, 5 months ago

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1525895585-79023-1-git-send-email-thomas.tai@oracle.com
Subject: [Qemu-devel] [PATCH V2 0/1] virtio-balloon: fix internal stat name array to match Linux kernel

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/1525895585-79023-1-git-send-email-thomas.tai@oracle.com -> patchew/1525895585-79023-1-git-send-email-thomas.tai@oracle.com
 t [tag update]            patchew/20180509182002.8044-1-mreitz@redhat.com -> patchew/20180509182002.8044-1-mreitz@redhat.com
Switched to a new branch 'test'
6a374a628a virtio-balloon: fix internal stat name array to match Linux kernel

=== OUTPUT BEGIN ===
Checking PATCH 1/1: virtio-balloon: fix internal stat name array to match Linux kernel...
ERROR: code indent should never use tabs
#56: FILE: hw/virtio/virtio-balloon.c:47:
+^IVIRTIO_BALLOON_S_NAMES_WITH_PREFIX("stat-");$

total: 1 errors, 0 warnings, 52 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com