[Qemu-devel] [PATCH v5 0/6] s390x: vfio-ap: guest dedicated crypto adapters

Tony Krowiak posted 6 patches 7 years, 5 months ago
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1525782303-16940-1-git-send-email-akrowiak@linux.vnet.ibm.com
Test checkpatch failed
Test docker-mingw@fedora passed
Test docker-quick@centos7 passed
Test s390x passed
There is a newer version of this series
MAINTAINERS                       |   14 +
default-configs/s390x-softmmu.mak |    1 +
docs/vfio-ap.txt                  |  649 +++++++++++++++++++++++++++++++++++++
hw/s390x/Makefile.objs            |    1 +
hw/s390x/ap-device.c              |   39 +++
hw/vfio/Makefile.objs             |    1 +
hw/vfio/ap.c                      |  182 +++++++++++
include/hw/s390x/ap-device.h      |   38 +++
include/hw/vfio/vfio-common.h     |    1 +
linux-headers/asm-s390/kvm.h      |    2 +
linux-headers/linux/vfio.h        |    2 +
target/s390x/cpu_features.c       |    3 +
target/s390x/cpu_features_def.h   |    3 +
target/s390x/cpu_models.c         |    2 +
target/s390x/gen-features.c       |    3 +
target/s390x/kvm.c                |    1 +
16 files changed, 942 insertions(+), 0 deletions(-)
create mode 100644 docs/vfio-ap.txt
create mode 100644 hw/s390x/ap-device.c
create mode 100644 hw/vfio/ap.c
create mode 100644 include/hw/s390x/ap-device.h
[Qemu-devel] [PATCH v5 0/6] s390x: vfio-ap: guest dedicated crypto adapters
Posted by Tony Krowiak 7 years, 5 months ago
This patch series is the QEMU counterpart to the KVM/kernel support for 
guest dedicated crypto adapters. The KVM/kernel model is built on the 
VFIO mediated device framework and provides the infrastructure for 
granting exclusive guest access to crypto devices installed on the linux 
host. This patch series introduces a new QEMU command line option, QEMU 
object model and CPU model features to exploit the KVM/kernel model.

See the detailed specifications for AP virtualization provided by this 
patch set in docs/vfio-ap.txt for a more complete discussion of the 
design introduced by this patch series.

Note: This series implements the minimal viable product (MVP) and does not
      provide support for hot plug/unplug, migration, or VSIE. The goal
      of the MVP model is to solidify a base upon which these additional 
      features will be built.

v4 => v5 Change log:
===================
* Added MAINTAINERS entries for VFIO AP
* Added explanation for why we are only supporting zEC12 and newer CPU 
  models.
* Changed CPU model feature qci=on|off to apqci=on|off
* Misc. minor changes


Tony Krowiak (6):
  linux-headers: linux header updates for AP support
  s390x/ap: base Adjunct Processor (AP) object
  s390x/cpumodel: Set up CPU model for AP device support
  s390x/vfio: ap: Introduce VFIO AP device
  s390: doc: detailed specifications for AP virtualization
  MAINTAINERS: add entries for AP

 MAINTAINERS                       |   14 +
 default-configs/s390x-softmmu.mak |    1 +
 docs/vfio-ap.txt                  |  649 +++++++++++++++++++++++++++++++++++++
 hw/s390x/Makefile.objs            |    1 +
 hw/s390x/ap-device.c              |   39 +++
 hw/vfio/Makefile.objs             |    1 +
 hw/vfio/ap.c                      |  182 +++++++++++
 include/hw/s390x/ap-device.h      |   38 +++
 include/hw/vfio/vfio-common.h     |    1 +
 linux-headers/asm-s390/kvm.h      |    2 +
 linux-headers/linux/vfio.h        |    2 +
 target/s390x/cpu_features.c       |    3 +
 target/s390x/cpu_features_def.h   |    3 +
 target/s390x/cpu_models.c         |    2 +
 target/s390x/gen-features.c       |    3 +
 target/s390x/kvm.c                |    1 +
 16 files changed, 942 insertions(+), 0 deletions(-)
 create mode 100644 docs/vfio-ap.txt
 create mode 100644 hw/s390x/ap-device.c
 create mode 100644 hw/vfio/ap.c
 create mode 100644 include/hw/s390x/ap-device.h


Re: [Qemu-devel] [PATCH v5 0/6] s390x: vfio-ap: guest dedicated crypto adapters
Posted by no-reply@patchew.org 7 years, 5 months ago
Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1525782303-16940-1-git-send-email-akrowiak@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH v5 0/6] s390x: vfio-ap: guest dedicated crypto adapters

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/1525782303-16940-1-git-send-email-akrowiak@linux.vnet.ibm.com -> patchew/1525782303-16940-1-git-send-email-akrowiak@linux.vnet.ibm.com
Switched to a new branch 'test'
a99e8ebd51 MAINTAINERS: add entries for AP
813c09ef7e s390: doc: detailed specifications for AP virtualization
4217fb43ca s390x/vfio: ap: Introduce VFIO AP device
9b494088d9 s390x/cpumodel: Set up CPU model for AP device support
6ef6c4cdc2 s390x/ap: base Adjunct Processor (AP) object
b283bcc881 linux-headers: linux header updates for AP support

=== OUTPUT BEGIN ===
Checking PATCH 1/6: linux-headers: linux header updates for AP support...
Checking PATCH 2/6: s390x/ap: base Adjunct Processor (AP) object...
Checking PATCH 3/6: s390x/cpumodel: Set up CPU model for AP device support...
WARNING: line over 80 characters
#47: FILE: target/s390x/cpu_features.c:43:
+    FEAT_INIT("apqci", S390_FEAT_TYPE_STFL, 12, "Query AP Configuration facility"),

ERROR: line over 90 characters
#50: FILE: target/s390x/cpu_features.c:46:
+    FEAT_INIT("apft", S390_FEAT_TYPE_STFL, 15, "Adjunct Processor Facilities Test facility"),

total: 1 errors, 1 warnings, 58 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 4/6: s390x/vfio: ap: Introduce VFIO AP device...
Checking PATCH 5/6: s390: doc: detailed specifications for AP virtualization...
Checking PATCH 6/6: MAINTAINERS: add entries for AP...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com