include path cleanup

[Qemu-devel] [PATCH 41/67] tcg-pool.inc.c: replace command line flags with preprocessor

Posted by Michael S. Tsirkin 7 years, 5 months ago

Each target is currently built with a different set of include
directories, this is what makes it possible to pull in a separate copy
of cpu.h depending on the target.

Replace with per-target ifdefs which are easier to understand.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 include/tcg-pool.inc.c | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 include/tcg-pool.inc.c

diff --git a/include/tcg-pool.inc.c b/include/tcg-pool.inc.c
new file mode 100644
index 0000000..d04a981
--- /dev/null
+++ b/include/tcg-pool.inc.c
@@ -0,0 +1 @@
+#include_next "../tcg/tcg-pool.inc.c"
-- 
MST

Re: [Qemu-devel] [PATCH 41/67] tcg-pool.inc.c: replace command line flags with preprocessor

Posted by Eric Blake 7 years, 5 months ago

On 05/03/2018 02:51 PM, Michael S. Tsirkin wrote:
> Each target is currently built with a different set of include
> directories, this is what makes it possible to pull in a separate copy
> of cpu.h depending on the target.
> 
> Replace with per-target ifdefs which are easier to understand.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>   include/tcg-pool.inc.c | 1 +
>   1 file changed, 1 insertion(+)
>   create mode 100644 include/tcg-pool.inc.c
> 
> diff --git a/include/tcg-pool.inc.c b/include/tcg-pool.inc.c
> new file mode 100644
> index 0000000..d04a981
> --- /dev/null
> +++ b/include/tcg-pool.inc.c
> @@ -0,0 +1 @@
> +#include_next "../tcg/tcg-pool.inc.c"

Bad copy-and-paste in the commit message?

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

Re: [Qemu-devel] [PATCH 41/67] tcg-pool.inc.c: replace command line flags with preprocessor

Posted by Michael S. Tsirkin 7 years, 5 months ago

On Thu, May 03, 2018 at 03:12:16PM -0500, Eric Blake wrote:
> On 05/03/2018 02:51 PM, Michael S. Tsirkin wrote:
> > Each target is currently built with a different set of include
> > directories, this is what makes it possible to pull in a separate copy
> > of cpu.h depending on the target.
> > 
> > Replace with per-target ifdefs which are easier to understand.
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >   include/tcg-pool.inc.c | 1 +
> >   1 file changed, 1 insertion(+)
> >   create mode 100644 include/tcg-pool.inc.c
> > 
> > diff --git a/include/tcg-pool.inc.c b/include/tcg-pool.inc.c
> > new file mode 100644
> > index 0000000..d04a981
> > --- /dev/null
> > +++ b/include/tcg-pool.inc.c
> > @@ -0,0 +1 @@
> > +#include_next "../tcg/tcg-pool.inc.c"
> 
> Bad copy-and-paste in the commit message?

Yes :(

> -- 
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3266
> Virtualization:  qemu.org | libvirt.org