include path cleanup

[Qemu-devel] [PATCH 38/67] helper: replace command line flags with preprocessor

Posted by Michael S. Tsirkin 7 years, 5 months ago

Each target is currently built with a different set of include
directories, this is what makes it possible to pull in a separate copy
of helper.h depending on the target.

Replace with per-target ifdefs which are easier to understand.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 include/exec/helper.h | 2 ++
 1 file changed, 2 insertions(+)
 create mode 100644 include/exec/helper.h

diff --git a/include/exec/helper.h b/include/exec/helper.h
new file mode 100644
index 0000000..55a48a0
--- /dev/null
+++ b/include/exec/helper.h
@@ -0,0 +1,2 @@
+#include "target-dir.h"
+#include TARGET_DIR(helper.h)
-- 
MST

Re: [Qemu-devel] [PATCH 38/67] helper: replace command line flags with preprocessor

Posted by Eric Blake 7 years, 5 months ago

On 05/03/2018 02:51 PM, Michael S. Tsirkin wrote:
> Each target is currently built with a different set of include
> directories, this is what makes it possible to pull in a separate copy
> of helper.h depending on the target.
> 
> Replace with per-target ifdefs which are easier to understand.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>   include/exec/helper.h | 2 ++
>   1 file changed, 2 insertions(+)
>   create mode 100644 include/exec/helper.h

Out-of-order patch; target-dir.h isn't created yet...

> 
> diff --git a/include/exec/helper.h b/include/exec/helper.h
> new file mode 100644
> index 0000000..55a48a0
> --- /dev/null
> +++ b/include/exec/helper.h
> @@ -0,0 +1,2 @@
> +#include "target-dir.h"
> +#include TARGET_DIR(helper.h)
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org