backends/cryptodev: fix coverity issue

[Qemu-devel] [PATCH] backends/cryptodev: fix coverity issue

Jay Zhou posted 1 patch 7 years, 6 months ago

Download mbox

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1524894864-7492-1-git-send-email-jianjay.zhou@huawei.com

Test checkpatch passed

Test docker-build@min-glib passed

Test docker-mingw@fedora passed

Test s390x passed

backends/cryptodev-vhost-user.c | 5 -----
1 file changed, 5 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH] backends/cryptodev: fix coverity issue

Posted by Jay Zhou 7 years, 6 months ago

This patch removes the dead code, which fixes Coverity (CID 1390600) issue.

Signed-off-by: Jay Zhou <jianjay.zhou@huawei.com>
---
 backends/cryptodev-vhost-user.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/backends/cryptodev-vhost-user.c b/backends/cryptodev-vhost-user.c
index 862d4f2..67e65c6 100644
--- a/backends/cryptodev-vhost-user.c
+++ b/backends/cryptodev-vhost-user.c
@@ -155,7 +155,6 @@ static void cryptodev_vhost_user_event(void *opaque, int event)
 {
     CryptoDevBackendVhostUser *s = opaque;
     CryptoDevBackend *b = CRYPTODEV_BACKEND(s);
-    Error *err = NULL;
     int queues = b->conf.peers.queues;
 
     assert(queues < MAX_CRYPTO_QUEUE_NUM);
@@ -172,10 +171,6 @@ static void cryptodev_vhost_user_event(void *opaque, int event)
         cryptodev_vhost_user_stop(queues, s);
         break;
     }
-
-    if (err) {
-        error_report_err(err);
-    }
 }
 
 static void cryptodev_vhost_user_init(
-- 
1.8.3.1

Re: [Qemu-devel] [PATCH] backends/cryptodev: fix coverity issue

Posted by Stefan Hajnoczi 7 years, 5 months ago

On Sat, Apr 28, 2018 at 01:54:24PM +0800, Jay Zhou wrote:
> This patch removes the dead code, which fixes Coverity (CID 1390600) issue.
> 
> Signed-off-by: Jay Zhou <jianjay.zhou@huawei.com>
> ---
>  backends/cryptodev-vhost-user.c | 5 -----
>  1 file changed, 5 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>