On 04/27/2018 05:40 AM, Thomas Huth wrote:
> With one of my clean-up patches (see commit 1454509726719e0933c800), I
> recently accidentially broke the "-cdrom" parameter (more precisely
> "-drive if=scsi") on a couple of boards, since there was no error
> detected during the "make check" regression testing. This is clearly an
> indication that we are lacking tests in this area.
> So this small patch series now introduces some tests for CD-ROM drives:
> The first two patches introduce the possibility to check that booting
> from CD-ROM drives still works fine for x86 and s390x, and the third
> patch adds a test that certain machines can at least still be started
> with the "-cdrom" parameter (i.e. that test would have catched the
> mistake that I did with my SCSI cleanup patch).
>
> v3:
> - Rebased to current master branch
> - Add a final patch that adds an entry to the MAINTAINERS file
>
> v2:
> - Use g_spawn_sync() instead of execlp() to run genisoimage
> - The "-cdrom" parameter test is now run on all architectures (with
> machine "none" for the machines that are not explicitly checked)
> - Some rewordings and improved comments here and there
>
> Thomas Huth (4):
> tests/boot-sector: Add magic bytes to s390x boot code header
> tests/cdrom-test: Test booting from CD-ROM ISO image file
> tests/cdrom-test: Test that -cdrom parameter is working
> MAINTAINERS: Add the cdrom-test to John's section
>
> MAINTAINERS | 1 +
> tests/Makefile.include | 2 +
> tests/boot-sector.c | 9 +-
> tests/cdrom-test.c | 222 +++++++++++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 231 insertions(+), 3 deletions(-)
> create mode 100644 tests/cdrom-test.c
>
*coughs*
Thanks, applied to my IDE tree:
https://github.com/jnsnow/qemu/commits/ide
https://github.com/jnsnow/qemu.git
--js